September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddTemplate: Remove unused dest sd handling
by amureini＠redhat.com 11 Sep '13

11 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddTemplate: Remove unused dest sd handling ...................................................................... core: AddTemplate: Remove unused dest sd handling Change-Id I523814cd3c1f64c1ae40624ba50f239f2cebaed7 removed the setting of the destinationId in the constructor. This left that variable unused, so it can safely be removed. Change-Id: Id8440f9ece2fbe21c5bca6acde43d3a45ac2126a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8440f9ece2fbe21c5bca6acde43d3a45ac2126a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : VdsUpdateRuntimeInfo updates the data of a specific...
by yzaslavs＠redhat.com 11 Sep '13

11 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : VdsUpdateRuntimeInfo updates the data of a specific VDS. ...................................................................... engine : VdsUpdateRuntimeInfo updates the data of a specific VDS. This change migrates all VM updates the VdsUpdateRuntimeInfo process does to batch updates - improving performance. Change-Id: Ie3e9735f4174ebabbe293d397d931aba72bbbd7b Signed-off-by: lzelkha(a)redhat.com <liran.zelkha(a)gmail.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterOptionDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkStatisticsDaoDbFacadeImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 17 files changed, 233 insertions(+), 67 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3e9735f4174ebabbe293d397d931aba72bbbd7b Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fixing job dao test
by yzaslavs＠redhat.com 11 Sep '13

11 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing job dao test ...................................................................... core: Fixing job dao test Job dao test relies that the first job is always the same - this assumption may cause a test to fail Change-Id: Iaebd1263c3a046dd8908af1258016b17dc198a20 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/JobDaoTest.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaebd1263c3a046dd8908af1258016b17dc198a20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: move version of ws-commons-util to master pom
by yzaslavs＠redhat.com 11 Sep '13

11 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: build: move version of ws-commons-util to master pom ...................................................................... build: move version of ws-commons-util to master pom Change-Id: Ib0e5c840ba5d83cc5d21f418bbb92dc7bc652948 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dependencies/pom.xml M pom.xml 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0e5c840ba5d83cc5d21f418bbb92dc7bc652948 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: agent, broker: api to retrieve host status
by gpadgett＠redhat.com 11 Sep '13

11 Sep '13

Greg Padgett has submitted this change and it was merged. Change subject: agent, broker: api to retrieve host status ...................................................................... agent, broker: api to retrieve host status Add client library with api to retrieve host status from storage. This required some refactoring to move selected agent logic to a shared location in the source tree. Change-Id: I03997f51a4e512d5456f59d6794dce6ce8495287 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M configure.ac M ovirt_hosted_engine_ha/Makefile.am M ovirt_hosted_engine_ha/agent/Makefile.am M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/broker/constants.py.in M ovirt_hosted_engine_ha/broker/listener.py C ovirt_hosted_engine_ha/client/Makefile.am A ovirt_hosted_engine_ha/client/__init__.py A ovirt_hosted_engine_ha/client/client.py C ovirt_hosted_engine_ha/env/Makefile.am A ovirt_hosted_engine_ha/env/__init__.py R ovirt_hosted_engine_ha/env/config.py R ovirt_hosted_engine_ha/env/constants.py.in A ovirt_hosted_engine_ha/env/path.py M ovirt_hosted_engine_ha/lib/Makefile.am R ovirt_hosted_engine_ha/lib/brokerlink.py M ovirt_hosted_engine_ha/lib/exceptions.py A ovirt_hosted_engine_ha/lib/metadata.py M ovirt_hosted_engine_ha/lib/vds_client.py 20 files changed, 289 insertions(+), 82 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/18731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03997f51a4e512d5456f59d6794dce6ce8495287 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-hosted-engine-ha[master]: agent, broker: additional vm control including migration
by gpadgett＠redhat.com 11 Sep '13

11 Sep '13

Greg Padgett has submitted this change and it was merged. Change subject: agent, broker: additional vm control including migration ...................................................................... agent, broker: additional vm control including migration Add logic to handle migration and fix up other transition logic. Broker files were changed only to move run_vds_client_cmd() to lib. Change-Id: I842f30e6d1533ae4be227508999cd96b3e4963c3 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M .gitignore M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/broker/Makefile.am M ovirt_hosted_engine_ha/broker/constants.py.in M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py M ovirt_hosted_engine_ha/broker/submonitors/mem_free.py M ovirt_hosted_engine_ha/broker/submonitors/mem_load.py M ovirt_hosted_engine_ha/broker/submonitors/mgmt_bridge.py M ovirt_hosted_engine_ha/lib/Makefile.am A ovirt_hosted_engine_ha/lib/constants.py.in R ovirt_hosted_engine_ha/lib/vds_client.py 12 files changed, 333 insertions(+), 82 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I842f30e6d1533ae4be227508999cd96b3e4963c3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-hosted-engine-ha[master]: agent: update logic and use state machine
by gpadgett＠redhat.com 11 Sep '13

11 Sep '13

Greg Padgett has submitted this change and it was merged. Change subject: agent: update logic and use state machine ...................................................................... agent: update logic and use state machine Change logic to make transitions smoother, as well as refactoring the code to control the vm using a state machine rather than procedural code. This makes the control flow more clear and makes logic changes easier to implement. Change-Id: Iad9906d50a5fffb4c9f362b43f0064bf6be4dbde Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 208 insertions(+), 70 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad9906d50a5fffb4c9f362b43f0064bf6be4dbde Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-hosted-engine-ha[master]: agent: store metadata on storage domain, sync with sanlock
by gpadgett＠redhat.com 11 Sep '13

11 Sep '13

Greg Padgett has submitted this change and it was merged. Change subject: agent: store metadata on storage domain, sync with sanlock ...................................................................... agent: store metadata on storage domain, sync with sanlock Instead of requiring an additional shared storage location to hold the agent metadata, store it on the storage domain holding the engine vm. Sanlock is used to assist in coordination of the storage and guarantee host_id uniqueness amongst hosts. A new directory named 'ha_agent' will be created on the storage domain by the ha setup package. Two files reside within, one for the lockspace (named 'hosted-engine.lockspace') and one for the metadata (similarly named 'hosted-engine.metadata'). The metadata file is shared by all hosts participating in the engine high availability cluster. Each host is assigned a 4KiB chunk according to its host id, with a corresponding offset of host_id*4KiB. The initial 4KiB of the file are reserved for shared state such as a global engine ha maintenance bit. Change-Id: I9f09e736f6556c0bf9a435d3a88035d9dbd53883 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in M ovirt_hosted_engine_ha/agent/brokerlink.py M ovirt_hosted_engine_ha/agent/config.py M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/broker/constants.py.in M ovirt_hosted_engine_ha/broker/storage_broker.py 7 files changed, 171 insertions(+), 81 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f09e736f6556c0bf9a435d3a88035d9dbd53883 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-backup - support old md5sum
by oschreib＠redhat.com 11 Sep '13

11 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-backup - support old md5sum ...................................................................... packaging: engine-backup - support old md5sum Removed '--strict' md5sum option, which isn't supported on earlier versions of md5sum. Change-Id: I723bc81e84be05aa2fb3ca2ceb8210a2bfe7adc9 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> Bug-URL: https://bugzilla.redhat.com/1003869 --- M packaging/bin/engine-backup.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I723bc81e84be05aa2fb3ca2ceb8210a2bfe7adc9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: Adding Unit Tests and Functional Tests
by bazulay＠redhat.com 11 Sep '13

11 Sep '13

Barak Azulay has submitted this change and it was merged. Change subject: Adding Unit Tests and Functional Tests ...................................................................... Adding Unit Tests and Functional Tests The functional tests so far are testing the retrieval of data from the underlying system and ensures the structure of the data. It does not however validate the content. It ensures that the messages sent over the VirtIO Serial channel have the format defined. If we change the format it will break the unit tests. Additionally a check for the unicode filtering. Change-Id: I4c1d740c948e33aed8a04a1013b22276cf7d85e3 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M Makefile.am M configure.ac M ovirt-guest-agent/VirtIoChannel.py A tests/Makefile.am A tests/encoding_test.py A tests/guest_agent_test.py A tests/message_validator.py A tests/test_port.py A tests/testrunner.py A tests/unittest.bat 10 files changed, 491 insertions(+), 12 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c1d740c948e33aed8a04a1013b22276cf7d85e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0