January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Add external id to users and groups
by juan.hernandez＠redhat.com 15 Jan '14

15 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add external id to users and groups ...................................................................... restapi: Add external id to users and groups Eairlier changes have added the external identifier field to the user and group entities, but it wasn't returned by the RESTAPI yet. This patch adds support for that. Change-Id: I799219080a57c6ec4ef0e16c742f1f44d11f1080 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java 9 files changed, 11 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I799219080a57c6ec4ef0e16c742f1f44d11f1080 Gerrit-PatchSet: 32 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core+webadmin: importing glance image as a template
by oourfali＠redhat.com 15 Jan '14

15 Jan '14

Oved Ourfali has submitted this change and it was merged. Change subject: core+webadmin: importing glance image as a template ...................................................................... core+webadmin: importing glance image as a template This patch allows to import a glance image as a new template. The template properties are identical to the Blank template. The only disk in this new template is a copy of the glance image. Change-Id: I537094bf9f738335833330665d29a1d39c65678d Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportRepoImageParameters.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ExportRepoImageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportExportRepoImageBaseModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportRepoImageModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.ui.xml 8 files changed, 119 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I537094bf9f738335833330665d29a1d39c65678d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Removing deprecated image_group_id
by mlipchuk＠redhat.com 15 Jan '14

15 Jan '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Removing deprecated image_group_id ...................................................................... core: Removing deprecated image_group_id Use getId instead deprecated image_group_id Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I5774b52059bb52b346f9dbc560cf8ee494547ff1 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5774b52059bb52b346f9dbc560cf8ee494547ff1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove old prefix from error log
by mlipchuk＠redhat.com 15 Jan '14

15 Jan '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove old prefix from error log ...................................................................... core: Remove old prefix from error log Removing unneeded class name from log error. Removing also wrong method name. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Ie917ee4ce2455c0ec9768da6277c57e089c6b0c0 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 2 files changed, 2 insertions(+), 7 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie917ee4ce2455c0ec9768da6277c57e089c6b0c0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use runVdsCommand method
by mlipchuk＠redhat.com 15 Jan '14

15 Jan '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use runVdsCommand method ...................................................................... core: Use runVdsCommand method Use runVdsCommand instead full getBackend().getResourceManager().RunVdsCommand Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I887f068749524bc3c6c9490caf694f899f21a46b --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java 1 file changed, 7 insertions(+), 11 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I887f068749524bc3c6c9490caf694f899f21a46b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix virtio-scsi validation on update VM
by derez＠redhat.com 15 Jan '14

15 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: core: fix virtio-scsi validation on update VM ...................................................................... core: fix virtio-scsi validation on update VM Fix VirtIO-SCSI validation when updating a running VM: * Added a new signature for vmDeviceChanged method which gets also a specific VmDeviceType. ** Needed for using getVmDeviceByVmIdTypeAndDevice method from VmDeviceDao. I.e. instead of fetching all devices of VmDeviceGeneralType.CONTROLLER, filter also by VmDeviceType.VIRTIOSCSI specifically. * Added new test-cases for updating a running VM. Change-Id: I6f2247319b014f59d5c19c0054ee9e63d1dfe204 Bug-Url: https://bugzilla.redhat.com/1049272 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 2 files changed, 64 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f2247319b014f59d5c19c0054ee9e63d1dfe204 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: agent: use certificate common name to identify host
by gpadgett＠redhat.com 15 Jan '14

15 Jan '14

Greg Padgett has submitted this change and it was merged. Change subject: agent: use certificate common name to identify host ...................................................................... agent: use certificate common name to identify host The name the host calls itself in the global metadata must match the libvirt certificate's Common Name, else migrations will fail. Use this name when available, and fall back to the hostname in other cases. Change-Id: Ie9de4537685b11f8ecbe55b3c1b6845654f59311 Bug-Url: https://bugzilla.redhat.com/1039614 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py 2 files changed, 35 insertions(+), 1 deletion(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9de4537685b11f8ecbe55b3c1b6845654f59311 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Improve UI Plugin vs. REST API integration
by vszocs＠redhat.com 15 Jan '14

15 Jan '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Improve UI Plugin vs. REST API integration ...................................................................... webadmin: Improve UI Plugin vs. REST API integration This patch provides client-side fix for following use case: a. assume restapi-session-timeout > engine-session-timeout - UI Plugin infra uses restapi-session-timeout=360min - by default, engine-session-timeout=30min b. user logs into WebAdmin, WebAdmin's UI Plugin infra acquires REST API session (using GUI login credentials) c. user is inactive for engine-session-timeout [min] - Engine session will be invalidated - however, REST API session is still active d. WebAdmin detects that Engine session is invalid and takes the user back to login screen e. user logs into WebAdmin again, WebAdmin's UI Plugin infra tries to acquire REST API session again - REST API session (JSESSIONID cookie) is still active so backend will reuse it - REST API backend attempts to validate the Engine session, the Engine session is invalid so backend sends HTTP 401 "Auth Required" response to client f. as a result: - user sees "Auth Required" browser-specific popup in browser - UI Plugin vs. REST API integration is broken for current user login session, i.e. WebAdmin didn't receive JSESSIONID response header from REST API backend This patch makes following changes: - detect current Engine session timeout, embed it into WebAdmin host page and read it during WebAdmin startup - tell RestApiSessionManager to acquire REST API session using timeout = current-engine-session-timeout - while the user stays authenticated in WebAdmin GUI, keep REST API *and* Engine session alive via heartbeat requests [1] This has following implications on existing UI plugins: - REST API session timeout is no longer 360min (it's now equal to current-engine-session-timeout) so plugins and/or other systems utilizing REST API session should be prepared to deal with shorter timeout periods [2] - plugins and/or other systems utilizing REST API session can now rely on session keep-alive behavior implemented in GUI [3] [1] keep-alive behavior re-introduced after changes in patch http://gerrit.ovirt.org/#/c/14411/ [2] in practice, REST API session is usable only as long as the associated Engine session is active [3] keep-alive active as long as the user stays authenticated while having WebAdmin GUI open in the browser Change-Id: I0b913e78c0ddb54011670c421d6ff5d12c965d6b Bug-Url: https://bugzilla.redhat.com/1011058 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/EngineSessionTimeoutData.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java 8 files changed, 121 insertions(+), 9 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b913e78c0ddb54011670c421d6ff5d12c965d6b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove UserSessionTimeOutInvalidationInterval
by vszocs＠redhat.com 15 Jan '14

15 Jan '14

Vojtech Szocs has submitted this change and it was merged. Change subject: engine: Remove UserSessionTimeOutInvalidationInterval ...................................................................... engine: Remove UserSessionTimeOutInvalidationInterval Currently, there are two different config options for controlling Engine user session expiration: 1. UserSessionTimeOutInterval: - delay between Engine startup and first execution of "cleanExpiredUsersSessions" job - allowed values -1,1..100000 (-1 = disable) - default value is 30 min 2. UserSessionTimeOutInvalidationInterval: - delay between subsequent executions of "cleanExpiredUsersSessions" job - allowed values -1,1..100000 (-1 = disable) - default value is 30 min This patch removes the second config option, using first option to represent both delay intervals. While it makes little sense to use -1 to disable Engine user session expiration entirely (as this essentially generates memory leaks), this patch preserves the original "-1,1..100000" range for backward compatibility. Change-Id: Ic6eb6273653bfffe0d1fa1b8a4dc39e085c19496 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 4 files changed, 2 insertions(+), 11 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6eb6273653bfffe0d1fa1b8a4dc39e085c19496 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: SPICE ActiveX plugin IE 11 workaround
by vszocs＠redhat.com 15 Jan '14

15 Jan '14

Vojtech Szocs has submitted this change and it was merged. Change subject: frontend: SPICE ActiveX plugin IE 11 workaround ...................................................................... frontend: SPICE ActiveX plugin IE 11 workaround Currently SPICE ActiveX plugin cannot handle embedding into DOM without <PARAM NAME="SecurePort" VALUE="0"/> element inside <object ...> element. This patch adds this dummy <PARAM .../> element. Change-Id: Ibb63ac7c0dcd269de33ced50da215e86072476cc Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1052104 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb63ac7c0dcd269de33ced50da215e86072476cc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0