January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: user session is kept alive
by ecohen＠redhat.com 15 Jan '14

15 Jan '14

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: user session is kept alive ...................................................................... webadmin: user session is kept alive When events are updated we trigger RefreshActiveModelEvent event, which forcefully update current active model, and causes a refresh in user session. As far as I understand this event should only be called when running an action. The result set from events is no longer empty when no new events happened, instead it contains the last X event. Updated the logic that determines if a new event happened in the frontend. Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Signed-off-by: Alexander Wels <awels(a)redhat.com> Change-Id: Ib99861bfdc41b98ceac0df7103acff5b9074f851 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib99861bfdc41b98ceac0df7103acff5b9074f851 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: locale-independent log list of packages
by sbonazzo＠redhat.com 15 Jan '14

15 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: locale-independent log list of packages ...................................................................... packaging: setup: locale-independent log list of packages Bug-Url: https://bugzilla.redhat.com/1044478 Change-Id: Ib7eadd2aa2fafcc91d7efa3cf550ef89638f7b81 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/ovirt-engine-log-setup-event.sh.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7eadd2aa2fafcc91d7efa3cf550ef89638f7b81 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: increase memory settings
by yzaslavs＠redhat.com 15 Jan '14

15 Jan '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: increase memory settings ...................................................................... webadmin: increase memory settings Increased memory settings in order not to reach OutOfMemory upon compilation Change-Id: I605a10321a46392241511523e80c00cd50bd16fd Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M frontend/webadmin/modules/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I605a10321a46392241511523e80c00cd50bd16fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix findbugs issue for PolicyUnit.equals()
by gchaplik＠redhat.com 15 Jan '14

15 Jan '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: fix findbugs issue for PolicyUnit.equals() ...................................................................... core: fix findbugs issue for PolicyUnit.equals() PolicyUnitImpl is a decorator for PolicyUnit, but doesn't overrides 'equals' method. Fixed PolicyUnitImpl to only contain PolicyUnit. Change-Id: I2d31dfb51268929df30bd468b14bfbc3e336c273 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommand.java 4 files changed, 19 insertions(+), 108 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d31dfb51268929df30bd468b14bfbc3e336c273 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: only ask remote db password once
by ydary＠redhat.com 15 Jan '14

15 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: only ask remote db password once ...................................................................... packaging: setup: only ask remote db password once Change-Id: Ice74b0179c98071732445b52828f8c4bf9ade17b Bug-Url: https://bugzilla.redhat.com/1040943 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-reports-setup.py 2 files changed, 30 insertions(+), 33 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice74b0179c98071732445b52828f8c4bf9ade17b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Fix console issues
by tjelinek＠redhat.com 15 Jan '14

15 Jan '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix console issues ...................................................................... frontend: Fix console issues This patch fixes - an NPEx in the console cache refreshing code, - loading consoles state from local storage on VmConsoles creation to ensure the initial state corresponds to local storage, - fixes regression from 04d7c8c37d7ce18f014e505cd5c46e25610d7 that causes problems with loading UserPortalListModel and UserPortalBasicListModel items when no pools were present. Change-Id: I5219b77cd013744bec8a1336bfc578fca3ec4b2b Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 5 files changed, 96 insertions(+), 83 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5219b77cd013744bec8a1336bfc578fca3ec4b2b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: NPE in maintenanceNumOfVds command
by dfediuck＠redhat.com 15 Jan '14

15 Jan '14

Doron Fediuck has submitted this change and it was merged. Change subject: core: NPE in maintenanceNumOfVds command ...................................................................... core: NPE in maintenanceNumOfVds command Due to a recent change. Also since the update is always static false, there's no need to fetch the entity prior to the update. Change-Id: Ia916d44fb2ab23d34c99ef5096e4d9e193541fba Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia916d44fb2ab23d34c99ef5096e4d9e193541fba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: scheduling: VM Affinity Group filter and weight module
by dfediuck＠redhat.com 15 Jan '14

15 Jan '14

Doron Fediuck has submitted this change and it was merged. Change subject: core: scheduling: VM Affinity Group filter and weight module ...................................................................... core: scheduling: VM Affinity Group filter and weight module Filter filters out hosts that doen't comply with affinity rules. Weight module uses filter logic to give high weight to hosts that would have filtered out. Added by deafult to all cluster policies. For more information please refer to: http://www.ovirt.org/Features/VM-Affinity Change-Id: I9716523591852635496799412ad387850d6c372d Bug-Url: https://bugzilla.redhat.com/1036638 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityWeightPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_04_0460_add_affinity_group_filter_and_weight.sql 9 files changed, 248 insertions(+), 3 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9716523591852635496799412ad387850d6c372d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: ListModelSuggestBox to respond on key press
by lvernia＠redhat.com 15 Jan '14

15 Jan '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: ListModelSuggestBox to respond on key press ...................................................................... webadmin: ListModelSuggestBox to respond on key press Made the widget more responsive, so that on each key press a ValueChangedEvent is fired. Change-Id: Iadf50caf19cac07f1d65a20557276a6c4b4f8b70 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadf50caf19cac07f1d65a20557276a6c4b4f8b70 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Acknowledge labels in Setup Networks dialog
by lvernia＠redhat.com 15 Jan '14

15 Jan '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Acknowledge labels in Setup Networks dialog ...................................................................... webadmin: Acknowledge labels in Setup Networks dialog Modified the Setup Networks initiation to also take into account network labels, i.e. to create corresponding panels and populate them with their related networks. Change-Id: I4e7d712fcae59b4e03ff365408161f5472dc235d Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/BondNetworkInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkInterfaceModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkLabelModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ConnectorPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworkPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkLabelPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java 12 files changed, 224 insertions(+), 24 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e7d712fcae59b4e03ff365408161f5472dc235d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0