January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: synchronize lun device size on refreshLunsInfo
by derez＠redhat.com 05 Jan '14

05 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: core: synchronize lun device size on refreshLunsInfo ...................................................................... core: synchronize lun device size on refreshLunsInfo SyncLunsInfoForIscsiStorageDomainCommand: When detecting a mismatch in LUN device size, store the updated size data in DB. * Added 'updateLUNsDeviceSize' method to LunDAO. * Updated storages_san_sp.sql accordingly. Note: the command is invoked when activating iSCSI SD. Change-Id: I618880c7b49c226e39f0a0830f1d4f9b71a5f304 Bug-Url: https://bugzilla.redhat.com/961532 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/LunDAOTest.java M packaging/dbscripts/storages_san_sp.sql 6 files changed, 68 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I618880c7b49c226e39f0a0830f1d4f9b71a5f304 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: validate IQN on update iSCSI connection
by derez＠redhat.com 05 Jan '14

05 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: core: validate IQN on update iSCSI connection ...................................................................... core: validate IQN on update iSCSI connection * Add a canDo validation to UpdateStorageServerConnectionCommand for empty IQN (similar to AddStorageServerConnectionCommand). * Updated unit tests accordingly. Change-Id: I437d93f90f6199238cc7cbe9c264c5bf72cca71c Bug-Url: https://bugzilla.redhat.com/1005284 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java 2 files changed, 20 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I437d93f90f6199238cc7cbe9c264c5bf72cca71c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: system/exportfs: pep8 fixups
by oschreib＠redhat.com 05 Jan '14

05 Jan '14

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: system/exportfs: pep8 fixups ...................................................................... packaging: setup: system/exportfs: pep8 fixups Change-Id: Ia7130f80b1a03ab9e76a7ac66842af9969d027fe Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7130f80b1a03ab9e76a7ac66842af9969d027fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tomáš Došek <tdosek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: disk migrate - avoid ctor init on last task handler
by derez＠redhat.com 05 Jan '14

05 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: core: disk migrate - avoid ctor init on last task handler ...................................................................... core: disk migrate - avoid ctor init on last task handler LiveMigrateDiskCommand - avoid initialization on constructor in case of last task handler: * No need to fetch un-needed stale data after last task completion. * Prevent an NPE on getVm() -> getVmsListForDisk() [as getImageGroupId() can be null in case of deleting the source disk before the last task (deleteImage) has been completed]. Change-Id: I4c8f14fdcc5e7db3cca41d2ce2e37e97a034ca23 Bug-Url: https://bugzilla.redhat.com/971022 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c8f14fdcc5e7db3cca41d2ce2e37e97a034ca23 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: fix breakage by Iaca3c6eb719
by oschreib＠redhat.com 05 Jan '14

05 Jan '14

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: fix breakage by Iaca3c6eb719 ...................................................................... packaging: spec: fix breakage by Iaca3c6eb719 Change-Id: Ib6de1967701d66176fa082ffaa480e7fdb29a2ce Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6de1967701d66176fa082ffaa480e7fdb29a2ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Clear coverity warning
by mkolesni＠redhat.com 05 Jan '14

05 Jan '14

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Clear coverity warning ...................................................................... core: Clear coverity warning Coverity complains that RemoveNetworkParameters doesn't override VdcActionParametersBase.equals(Object) Change-Id: I41e00d5e3be113ea5c2dbacbab4cb5fddbf32803 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveNetworkParameters.java 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41e00d5e3be113ea5c2dbacbab4cb5fddbf32803 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Validate only supported nics are labeled
by masayag＠redhat.com 04 Jan '14

04 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: core: Validate only supported nics are labeled ...................................................................... core: Validate only supported nics are labeled Only interfaces or bonds can be labeled. Labeling slaves and vlans is not supported and should be blocked. Change-Id: Id510dd0ae8f24533aaf7b6760e6188d2e036b312 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 25 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/22868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id510dd0ae8f24533aaf7b6760e6188d2e036b312 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Introduces GetNetworkLabelsByNetworkIdQuery
by masayag＠redhat.com 04 Jan '14

04 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Introduces GetNetworkLabelsByNetworkIdQuery ...................................................................... engine: Introduces GetNetworkLabelsByNetworkIdQuery The query returns a list of labels of a specific network. Change-Id: I37c1466dfcfbb823feaedf38b77f937944fd1b5b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetNetworkLabelsByNetworkIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 28 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37c1466dfcfbb823feaedf38b77f937944fd1b5b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Introduce NetworkLabel entity
by masayag＠redhat.com 04 Jan '14

04 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: core: Introduce NetworkLabel entity ...................................................................... core: Introduce NetworkLabel entity The NetworkLabel entity is a plain container of the label id. The class designed to be transfered to the clients when querying for the label information which is managed either as part of the Network entity or as part of the VdsNetworkInterface. Having the label as an explicit entity will standardize data transfer between the restapi to the engine. Change-Id: I28f4e7688a02cdc8bf0475dbd237e09352add2e3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkLabel.java 1 file changed, 53 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28f4e7688a02cdc8bf0475dbd237e09352add2e3 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add Label and Unlabel network commands
by masayag＠redhat.com 04 Jan '14

04 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add Label and Unlabel network commands ...................................................................... engine: Add Label and Unlabel network commands The commands are added for labeling and unlabeling a network. The commands will be used from the rest api where the labels are a sub-collection of the network. Change-Id: I2064d24f0d357ca8d477266e4a9e18939bf21ad0 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/LabelNetworkCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UnlabelNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LabelNetworkParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UnlabelNetworkParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 15 files changed, 262 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2064d24f0d357ca8d477266e4a9e18939bf21ad0 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0