December 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: prevent possible NPE
by ahadas＠redhat.com 08 Dec '14

08 Dec '14

Arik Hadas has submitted this change and it was merged. Change subject: core: prevent possible NPE ...................................................................... core: prevent possible NPE Coverity scan founded that NPE might be thrown in ImportCommandBase#logImportEvents in case aliasesValuesMap is null. Thus, null check is added before using the aliasesValuesMap variable. Change-Id: I43a287f7245da2a4a0e10a71c58613c10df060f2 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/35953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43a287f7245da2a4a0e10a71c58613c10df060f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Expose configuration values for geo-rep sync
by kmayilsa＠redhat.com 08 Dec '14

08 Dec '14

Kanagaraj M has submitted this change and it was merged. Change subject: tools: Expose configuration values for geo-rep sync ...................................................................... tools: Expose configuration values for geo-rep sync Expose configuration values for geo-rep sync: - GlusterRefreshRateGeoRepStatus - GlusterRefreshRateGeoRepDiscovery Change-Id: Iea02f848bc7d23a226db320012a4b936888ac019 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/34505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea02f848bc7d23a226db320012a4b936888ac019 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: UI: datacenter/cluster running on host behavior
by shavivi＠redhat.com 08 Dec '14

08 Dec '14

Shahar Havivi has submitted this change and it was merged. Change subject: UI: datacenter/cluster running on host behavior ...................................................................... UI: datacenter/cluster running on host behavior When changing datacenter/cluster we need to fall back to "run on any host" selection and not stay with "run on specific host" if it was previously selected. Change-Id: I5ca584e0c98a4e9d3823b0333b92bff93db20872 Bug-Url: https://bugzilla.redhat.com/1136228 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/35876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ca584e0c98a4e9d3823b0333b92bff93db20872 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: hotfix daotests in VmStaticDAOTest
by ahadas＠redhat.com 08 Dec '14

08 Dec '14

Arik Hadas has submitted this change and it was merged. Change subject: core: hotfix daotests in VmStaticDAOTest ...................................................................... core: hotfix daotests in VmStaticDAOTest testGetOrderedVmGuidsForRunMultipleActionsByMigrationSupport which tested db logic for ordered VmGuids retrieval (with respect to MigrationSupport attribute) was failing because the number of tested vms was 4, but MigrationSupport has only 3 possible values. Therefore there were 2 VMs that were equal with respect to this ordering. Hot-fixed by restricting the number of test VMs to 3. Change-Id: I0ea611effabb69a693194a6a0639f2d3c17d08e5 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Frank Kobzik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ea611effabb69a693194a6a0639f2d3c17d08e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add 'import' functionality in vms tab
by ahadas＠redhat.com 08 Dec '14

08 Dec '14

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: add 'import' functionality in vms tab ...................................................................... webadmin: add 'import' functionality in vms tab Add 'import' button to the Virtual Machines tab that opens a dialog from which we can import VMs from different sources into the system. For now, this dialog allows to import VMs only from the export domain. Change-Id: I9aaae633518b1268e63b36894ba9e077884d4694 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateVmListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportSource.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/ImportVmsPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 17 files changed, 1,027 insertions(+), 10 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/29381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9aaae633518b1268e63b36894ba9e077884d4694 Gerrit-PatchSet: 33 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: build: fix fedora 21 build
by ydary＠redhat.com 08 Dec '14

08 Dec '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: fix fedora 21 build ...................................................................... build: fix fedora 21 build add missing files causing failure building on F21 Change-Id: Iefaa34e36223e88e5c81f2378d945be37faf86ab Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1163164 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-reports/EngineAuthentication/build.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefaa34e36223e88e5c81f2378d945be37faf86ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: rename RunVmCommandBase#processVmPoolOnStopVm
by ahadas＠redhat.com 07 Dec '14

07 Dec '14

Arik Hadas has submitted this change and it was merged. Change subject: core: rename RunVmCommandBase#processVmPoolOnStopVm ...................................................................... core: rename RunVmCommandBase#processVmPoolOnStopVm This method handles not only VMs from pool, but every VM that went down. Thus, its name is changed to processVmOnDown Change-Id: Ide45cda8a4fa5bb989d1a9eb8408717a9b071860 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/35928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide45cda8a4fa5bb989d1a9eb8408717a9b071860 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: move common things to ImportVmCommandBase
by ahadas＠redhat.com 07 Dec '14

07 Dec '14

Arik Hadas has submitted this change and it was merged. Change subject: core: move common things to ImportVmCommandBase ...................................................................... core: move common things to ImportVmCommandBase Things that should be commons for the different import commands are moved to ImportVmCommandBase class. Change-Id: Ie060ea182ea125db7f088ad5135e45a31a70b22b Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java 2 files changed, 199 insertions(+), 179 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/33054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie060ea182ea125db7f088ad5135e45a31a70b22b Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: fix findbug warning in ResourceManager
by rgolan＠redhat.com 07 Dec '14

07 Dec '14

Roy Golan has submitted this change and it was merged. Change subject: engine: fix findbug warning in ResourceManager ...................................................................... engine: fix findbug warning in ResourceManager - Findbugs is reporting a warning in ResourceManager this patch fixes the warning. Change-Id: I7ce68974540186251939e984add851d2c5d8789f Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ce68974540186251939e984add851d2c5d8789f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, userportal, webadmin: improper construction of file path
by lvernia＠redhat.com 07 Dec '14

07 Dec '14

Lior Vernia has submitted this change and it was merged. Change subject: core,userportal,webadmin: improper construction of file path ...................................................................... core,userportal,webadmin: improper construction of file path replaced string joining with proper construct Change-Id: Ifd073d100931003ab33cb6ea28df4260c7d5548a Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/DuplicateKeysTest.java M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/DuplicateKeysTest.java M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/DuplicateKeysTest.java 3 files changed, 17 insertions(+), 18 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd073d100931003ab33cb6ea28df4260c7d5548a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0