February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: Expose only Directory name via DirectoryEntry
by yzaslavs＠redhat.com 24 Feb '14

24 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Expose only Directory name via DirectoryEntry ...................................................................... aaa: Expose only Directory name via DirectoryEntry In many places of the code Directory is addresses as an entity. Since it holds only the directory name as a field, DirectoryEntry is changed to contain the DirectoryName. This is a step in order to move Directory from common to aaa. Topic: AAA Change-Id: Ic5a1226902597d148e9cf57c9dc1f5be4d76d31e Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/internal/InternalDirectory.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/nop/NopDirectory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/DirectoryUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalDirectory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryEntry.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryGroup.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryStub.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDomainGroupResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDomainUserResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/aaa/DirectoryGroup_CustomFieldSerializer.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/aaa/DirectoryUser_CustomFieldSerializer.java D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/aaa/DirectoryManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java 26 files changed, 49 insertions(+), 162 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5a1226902597d148e9cf57c9dc1f5be4d76d31e Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: renaming "authentication" to "aaa".
by yzaslavs＠redhat.com 24 Feb '14

24 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: renaming "authentication" to "aaa". ...................................................................... aaa: renaming "authentication" to "aaa". Renaming all places where "authentication" is used as package or module name to "aaa" (Authentication, Authorization, accounting). This is done as the "authentication" package/module deals not only with the authentication part, but also with authorization part (via the Directory class hierarchy) Topic: AAA Change-Id: Idd4410211deede8d17a4ce3a8ba1af32f0b497c5 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- R backend/manager/modules/aaa/exclude-filters.xml R backend/manager/modules/aaa/pom.xml R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticatedPrincipal.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticatedRequestWrapper.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationFilter.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfile.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileFactory.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileManager.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationResult.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticatorFactory.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticatorManager.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/DirectoryFactory.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/DirectoryManager.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/NegotiatingAuthenticator.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/NegotiationResult.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/PasswordAuthenticator.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/header/HeaderAuthenticator.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/header/HeaderAuthenticatorFactory.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/internal/InternalAuthenticator.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/internal/InternalAuthenticatorFactory.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/internal/InternalDirectory.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/internal/InternalDirectoryFactory.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/nop/NopAuthenticationResult.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/nop/NopAuthenticator.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/nop/NopAuthenticatorFactory.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/nop/NopDirectory.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/nop/NopDirectoryFactory.java R backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/result/BooleanAuthenticationResult.java R backend/manager/modules/aaa/src/main/modules/org/ovirt/engine/core/aaa/main/module.xml R backend/manager/modules/aaa/src/main/resources/META-INF/services/org.ovirt.engine.core.aaa.AuthenticatorFactory R backend/manager/modules/aaa/src/main/resources/META-INF/services/org.ovirt.engine.core.aaa.DirectoryFactory M backend/manager/modules/bll/pom.xml R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/DirectoryUtils.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalAuthenticationResult.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalAuthenticator.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalAuthenticatorFactory.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalDirectory.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalDirectoryFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutomaticLoginFilter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryGroupByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryUserByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DirectorySearchQueryTestBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDomainListQueryTest.java M backend/manager/modules/common/exclude-filters.xml R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/Directory.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryEntry.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryEntryStatus.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryGroup.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryStub.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java A backend/manager/modules/extension-manager/exclude-filters.xml M backend/manager/modules/extension-manager/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainGroupResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainUserResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainUsersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDomainGroupResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDomainUserResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml M ear/src/main/resources/META-INF/MANIFEST.MF M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/gwt-extension/pom.xml R frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/aaa/DirectoryGroup_CustomFieldSerializer.java R frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/aaa/DirectoryUser_CustomFieldSerializer.java R frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/aaa/DirectoryManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml 88 files changed, 266 insertions(+), 223 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd4410211deede8d17a4ce3a8ba1af32f0b497c5 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: creating extension-manager module
by yzaslavs＠redhat.com 24 Feb '14

24 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: creating extension-manager module ...................................................................... aaa: creating extension-manager module This module will hold all required classes for loading and managing extensions. Currnently this contains the Manage, Factory, and the Configuration related classes. The patch deals with the following: a. Moving these classes to the new module and fixing imports all over the code accordingly b. Fixing the MANIFEST.MF of the ear to add dependency on the new module. c. Fixing the get-extension to compile against authentication module as well, as currently DirectoryManager code resides there and needed for custom serialization of DirectoryUser and DirectoryGroup d. Adding a module dependency for authentication - to be dependent on extension-manager Topic: AAA Change-Id: I3c7258206880fd974934672de9fb5900192cca33 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/authentication/pom.xml M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticationProfileFactory.java M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticationProfileManager.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/Authenticator.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticatorFactory.java M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticatorManager.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/DirectoryFactory.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/DirectoryManager.java M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/header/HeaderAuthenticatorFactory.java M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/internal/InternalAuthenticatorFactory.java M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/internal/InternalDirectoryFactory.java M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/nop/NopAuthenticatorFactory.java M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/nop/NopDirectoryFactory.java M backend/manager/modules/authentication/src/main/modules/org/ovirt/engine/core/authentication/main/module.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/authentication/provisional/ProvisionalAuthenticatorFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/authentication/provisional/ProvisionalDirectoryFactory.java A backend/manager/modules/extension-manager/pom.xml R backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/Configuration.java R backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ConfigurationException.java R backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/Factory.java R backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/Manager.java R backend/manager/modules/extension-manager/src/test/java/org/ovirt/engine/core/extensions/mgr/ConfigurationTest.java M backend/manager/modules/pom.xml M ear/src/main/resources/META-INF/MANIFEST.MF M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/authentication/DirectoryGroup_CustomFieldSerializer.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/authentication/DirectoryUser_CustomFieldSerializer.java 28 files changed, 107 insertions(+), 21 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c7258206880fd974934672de9fb5900192cca33 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Cleaning up common from authentication code.
by yzaslavs＠redhat.com 24 Feb '14

24 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Cleaning up common from authentication code. ...................................................................... aaa: Cleaning up common from authentication code. Only "business entities" related code will remain in common Topic: AAA Change-Id: Icc27e54842bc036eb7ca71781f3eb028044b003c Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticatedPrincipal.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticatedRequestWrapper.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticationFilter.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticationProfile.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticationProfileFactory.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticationProfileManager.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticationResult.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticatorManager.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/NegotiatingAuthenticator.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/NegotiationResult.java R backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/PasswordAuthenticator.java M backend/manager/modules/bll/pom.xml M ear/src/main/resources/META-INF/MANIFEST.MF 13 files changed, 6 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc27e54842bc036eb7ca71781f3eb028044b003c Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: database: support get vdc option's versions
by sbonazzo＠redhat.com 24 Feb '14

24 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: database: support get vdc option's versions ...................................................................... packaging: setup: database: support get vdc option's versions Change-Id: I4c36d59afbc502f0bb28b0bbad1315f4e9c65702 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 39 insertions(+), 24 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c36d59afbc502f0bb28b0bbad1315f4e9c65702 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: added symlink to allow import in devel environment
by ydary＠redhat.com 24 Feb '14

24 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: added symlink to allow import in devel environment ...................................................................... reports: added symlink to allow import in devel environment Change-Id: Ie4f1c35e77ef54acb94ca06336091e37489dc3a4 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle.properties.data 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4f1c35e77ef54acb94ca06336091e37489dc3a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.1]: packaging: setup: disable firewalld in early misc stage
by sbonazzo＠redhat.com 24 Feb '14

24 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: disable firewalld in early misc stage ...................................................................... packaging: setup: disable firewalld in early misc stage otopi disables firewalld just before enabling iptables. We need to disable firewalld before entering misc stage because otherwise libvirt will rely on it also if it's stopped just after libvirt is started. Change-Id: Id74fcb192e09d27154d87ae8529a9722ae80a772 Bug-Url: https://bugzilla.redhat.com/1057139 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit f84e522ad12c29adbf4cb0044ed6a59a78a57fb1) --- M src/plugins/ovirt-hosted-engine-setup/network/Makefile.am M src/plugins/ovirt-hosted-engine-setup/network/__init__.py A src/plugins/ovirt-hosted-engine-setup/network/iptables.py 3 files changed, 82 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id74fcb192e09d27154d87ae8529a9722ae80a772 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: disable firewalld in early misc stage
by sbonazzo＠redhat.com 24 Feb '14

24 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: disable firewalld in early misc stage ...................................................................... packaging: setup: disable firewalld in early misc stage otopi disables firewalld just before enabling iptables. We need to disable firewalld before entering misc stage because otherwise libvirt will rely on it also if it's stopped just after libvirt is started. Change-Id: Id74fcb192e09d27154d87ae8529a9722ae80a772 Bug-Url: https://bugzilla.redhat.com/1057139 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/network/Makefile.am M src/plugins/ovirt-hosted-engine-setup/network/__init__.py A src/plugins/ovirt-hosted-engine-setup/network/iptables.py 3 files changed, 82 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Greg Padgett: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id74fcb192e09d27154d87ae8529a9722ae80a772 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Cloud init wants DNS inside interface
by iheim＠redhat.com 24 Feb '14

24 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Cloud init wants DNS inside interface ...................................................................... core: Cloud init wants DNS inside interface Cloud-init expects the DNS information inside the network interface definition, like this: iface eth0 inet static address 192.168.0.1 netmask 255.255.255.0 gateway 192.168.0.1 dns-nameservers 1.1.1.1 2.2.2.2 dns-search example.com auto eth0 But we put it outside, like this: dns-nameservers 1.1.1.1 2.2.2.2 dns-search example.com iface eth0 inet static address 192.168.0.1 netmask 255.255.255.0 gateway 192.168.0.1 auto eth0 The way we do it looks more correct, as the list of name servers and search domains isn't specific to a network interface, but common to all of them. But cloud-init doesn't like this. This patch changes the engine so that it generates the format that cloud-init wants. Change-Id: I79f758544496bedaf4e220639a9768a2518579f6 Bug-Url: https://bugzilla.redhat.com/1067906 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java 1 file changed, 17 insertions(+), 17 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Juan Hernandez: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79f758544496bedaf4e220639a9768a2518579f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Cloud init wants DNS inside interface
by iheim＠redhat.com 24 Feb '14

24 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Cloud init wants DNS inside interface ...................................................................... core: Cloud init wants DNS inside interface Cloud-init expects the DNS information inside the network interface definition, like this: iface eth0 inet static address 192.168.0.1 netmask 255.255.255.0 gateway 192.168.0.1 dns-nameservers 1.1.1.1 2.2.2.2 dns-search example.com auto eth0 But we put it outside, like this: dns-nameservers 1.1.1.1 2.2.2.2 dns-search example.com iface eth0 inet static address 192.168.0.1 netmask 255.255.255.0 gateway 192.168.0.1 auto eth0 The way we do it looks more correct, as the list of name servers and search domains isn't specific to a network interface, but common to all of them. But cloud-init doesn't like this. This patch changes the engine so that it generates the format that cloud-init wants. Change-Id: I79f758544496bedaf4e220639a9768a2518579f6 Bug-Url: https://bugzilla.redhat.com/1067906 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 4f34b420dab30ef40966aa3b5b7c8b0a0638bc65) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Juan Hernandez: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79f758544496bedaf4e220639a9768a2518579f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0