February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core, restapi: move destinationVdsId to RunVmOnceParams
by ofrenkel＠redhat.com 25 Feb '14

25 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core, restapi: move destinationVdsId to RunVmOnceParams ...................................................................... core, restapi: move destinationVdsId to RunVmOnceParams It should be possible to set destination VDS only when running VM in run once mode, but nevertheless this property resided in RunVmParams instead of RunVmOnceParams. Thus, it is moved. Change-Id: Id6bb75da2c2030f71da26c8690a6931319f6904f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java 5 files changed, 72 insertions(+), 50 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/24256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6bb75da2c2030f71da26c8690a6931319f6904f Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core:NPE when attempting to delete Everyone...
by iheim＠redhat.com 25 Feb '14

25 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core:NPE when attempting to delete Everyone... ...................................................................... core:NPE when attempting to delete Everyone... NPE when attempting to delete Everyone group from API This patch addresses an NPE thrown when trying to delete the Everyone group from the API. This exceptions cause the detail field to be skipped in the respond. Change-Id: Ic1faf6f97713f6adfce701126617b0463c118ce4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1060528 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified Juan Hernandez: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1faf6f97713f6adfce701126617b0463c118ce4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, restapi: Fix add permissions
by yzaslavs＠redhat.com 25 Feb '14

25 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core, restapi: Fix add permissions ...................................................................... core, restapi: Fix add permissions The refactoring of the authentication mechanism introduced two different identifiers for users and groups: one used internally by the engine and one used by the external directory. The RESTAPI wasn't correctly handling requests to add permissions when the provided identifier was the internal one. The patch fixes the RESTAPI and the backend so that they will accept both identifiers when adding users or groups. Change-Id: I0d05c4bf4ebd242fd3a01a2f9a8d679f687c4982 Bug-Url: https://bugzilla.redhat.com/1064829 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermissionMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/PermissionMapperTest.java 10 files changed, 335 insertions(+), 80 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d05c4bf4ebd242fd3a01a2f9a8d679f687c4982 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: cleanup module usage
by yzaslavs＠redhat.com 25 Feb '14

25 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: cleanup module usage ...................................................................... aaa: cleanup module usage broken by f97cc44c2. Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069305 Change-Id: Ie1c894aeeb76d10f877cc823177af73a889c65b2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/common/src/main/modules/org/ovirt/engine/core/common/main/module.xml A backend/manager/modules/extension-manager/src/main/modules/org/ovirt/engine/core/extension-manager/main/module.xml 2 files changed, 18 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1c894aeeb76d10f877cc823177af73a889c65b2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "core: When ActivateVDS fails, move VDS out of Unassi...
by emesika＠redhat.com 24 Feb '14

24 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: Revert "core: When ActivateVDS fails, move VDS out of Unassigned status" ...................................................................... Revert "core: When ActivateVDS fails, move VDS out of Unassigned status" This reverts commit ae49a3b702c166c87d5e2992a5d12591cd785a3b as this solution is not standard. Change-Id: I4a91e20142f36de1ddae12bfcf63f684823e4358 Signed-off-by: lzelkha(a)redhat.com --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/24936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a91e20142f36de1ddae12bfcf63f684823e4358 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add sPAPR VLAN in the REST API
by juan.hernandez＠redhat.com 24 Feb '14

24 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add sPAPR VLAN in the REST API ...................................................................... restapi: Add sPAPR VLAN in the REST API This patch introduces support for using sPAPR VLAN in the REST API when creating or updating NICs. Change-Id: I40a273c01247ee52b3f02671b48a35f387abbb88 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/NicInterface.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Vitor de Lima: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40a273c01247ee52b3f02671b48a35f387abbb88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[cli_3.4]: cli: Don't require /api
by juan.hernandez＠redhat.com 24 Feb '14

24 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Don't require /api ...................................................................... cli: Don't require /api Currently we perform an explicit validation of the URL of the API, and this requires that the path component of the URL is exactly /api. This doesn't work with the new URL schema of the engine, and won't work either if the user decides use any other base URL. This patch removes the validation of the path. Change-Id: I71fac959498d17e1176ea16584e5b4d2c36ddbf4 Bug-Url: https://bugzilla.redhat.com/1069171 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 95314e74e4699b7c828f88c27d01ceaf1bc416ed) --- M src/cli/messages.py M src/ovirtcli/command/connect.py M src/ovirtcli/infrastructure/options.py 3 files changed, 3 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71fac959498d17e1176ea16584e5b4d2c36ddbf4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: Don't require /api
by juan.hernandez＠redhat.com 24 Feb '14

24 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Don't require /api ...................................................................... cli: Don't require /api Currently we perform an explicit validation of the URL of the API, and this requires that the path component of the URL is exactly /api. This doesn't work with the new URL schema of the engine, and won't work either if the user decides use any other base URL. This patch removes the validation of the path. Change-Id: I71fac959498d17e1176ea16584e5b4d2c36ddbf4 Bug-Url: https://bugzilla.redhat.com/1069171 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/cli/messages.py M src/ovirtcli/command/connect.py M src/ovirtcli/infrastructure/options.py 3 files changed, 3 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71fac959498d17e1176ea16584e5b4d2c36ddbf4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: show command should retrieve sdk collection.get() metho...
by juan.hernandez＠redhat.com 24 Feb '14

24 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: show command should retrieve sdk collection.get() method's args dynamically ...................................................................... cli: show command should retrieve sdk collection.get() method's args dynamically show command should retrieve sdk collection.get() method's args dynamically, currently hardcoded id/name options being used. Change-Id: If9e0bce51f3a973049bffaa243aa1bd42e0ae25d Bug-Url: https://bugzilla.redhat.com/866448 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py M src/ovirtcli/shell/showcmdshell.py 2 files changed, 42 insertions(+), 8 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9e0bce51f3a973049bffaa243aa1bd42e0ae25d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: input control - fixed mistake in query
by ydary＠redhat.com 24 Feb '14

24 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: input control - fixed mistake in query ...................................................................... reports: input control - fixed mistake in query fixed a comment on is_deleted input control because it corrupted the reports. Change-Id: Ieb0a5507c09379959464c51eedd7106a6a4dc3fa Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/is_deleted.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb0a5507c09379959464c51eedd7106a6a4dc3fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0