February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core+setup: adding the public glance repository
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core+setup: adding the public glance repository ...................................................................... core+setup: adding the public glance repository This patch adds a stored procedure to add the public glance repository, and in addition a setup plugin that uses it, if needed. Change-Id: I415dd452f644e1adf150713f3dfdc094ae9af160 Bug-Url: https://bugzilla.redhat.com/1053544 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> (cherry picked from commit 146b9c89e8cc4ddfd05fb038cdaf6d6c126e2845) --- M packaging/dbscripts/inst_sp.sql M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/public_glance_repository.py 4 files changed, 113 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, but someone else must approve Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I415dd452f644e1adf150713f3dfdc094ae9af160 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: don't load disks for templates on search
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: don't load disks for templates on search ...................................................................... core: don't load disks for templates on search When searching for templates, the search loads all the disks for each template. this is not necessary as disks are a different collection that need to be fetched upon request, also the disks are not used currently by the search initiators, and it make the templates search slow for systems with many templates. this patch removes the disks population on templates search. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064907 Change-Id: Ia83a3117f2c65bbb17972095cf3271eb39449cd6 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia83a3117f2c65bbb17972095cf3271eb39449cd6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: fix cpu info for AMD Opterom Processor G5
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: fix cpu info for AMD Opterom Processor G5 ...................................................................... core: fix cpu info for AMD Opterom Processor G5 Fix for detecting AMD Opteron Processor G5 as AMD Opteron Processor G4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064880 Change-Id: Ica30c91f572229e9cbd0277dd84852c8f99bd50e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/24961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica30c91f572229e9cbd0277dd84852c8f99bd50e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: add template versions support
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: add template versions support ...................................................................... restapi: add template versions support Add to templates REST resource a new section that describes template version details. The user will be able to add this in POST (add template), update version name in PUT (update) and see version details in GET requests. Feature page: http://www.ovirt.org/Features/Template_Versions Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1037478 Change-Id: Id8e4c498c4a1856ac341237837db40db8375c6da Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java 6 files changed, 155 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Alissa Bonas: Verified Omer Frenkel: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8e4c498c4a1856ac341237837db40db8375c6da Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Don't duplicate directory name in the DB
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Don't duplicate directory name in the DB ...................................................................... core: Don't duplicate directory name in the DB Currently in the "users" table we store the directory name in the "domain" column and also, as a suffix added to the user name, in the in the "username" column. This duplication causes confusion, and makes the SQL schema a bit more non normalized. This patch removes that duplication and changes the places that need to display the directory name (GUI and RESTAPI) so that it is done explicitly. Bug-Url: https://bugzilla.redhat.com/1055881 Bug-Url: https://bugzilla.redhat.com/1059258 Change-Id: I53ebaf3254f829d73b2574230ae333f13cfcd546 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 2d36ccaecbf6a83340525083980f98ddff064e48) --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDomainUserResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/FormatUtils.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/CurrentUser.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java M packaging/dbscripts/common_sp.sql M packaging/dbscripts/create_functions.sql A packaging/dbscripts/upgrade/03_04_0640_remove_directory_suffix_from_login_name.sql 11 files changed, 98 insertions(+), 38 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Juan Hernandez: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53ebaf3254f829d73b2574230ae333f13cfcd546 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Correct utc_diff handling
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Correct utc_diff handling ...................................................................... engine: Correct utc_diff handling Now the utc_diff is always updated for running VMs (Linux or Windows) and reset on VM run. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1062615 Change-Id: I907cd1ab724b6c3217cc90bd886b678d4bb9d37a Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 2 files changed, 24 insertions(+), 24 deletions(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I907cd1ab724b6c3217cc90bd886b678d4bb9d37a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Allow both "type" and "data"
by juan.hernandez＠redhat.com 26 Feb '14

26 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Allow both "type" and "data" ...................................................................... restapi: Allow both "type" and "data" The "type" and "data" elements used when importing a VM from a configuration are both allowed and needed, but they are specified as a XML schema "choice" instead of a "sequence". This patch fixes that. Change-Id: I6d67b5b14b908c503c1e7d7fffb2a303cc026557 Bug-Url: https://bugzilla.redhat.com/1069522 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/25066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d67b5b14b908c503c1e7d7fffb2a303cc026557 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tools: Fix error if LDAP server cannot be resolved
by emesika＠redhat.com 26 Feb '14

26 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: tools: Fix error if LDAP server cannot be resolved ...................................................................... tools: Fix error if LDAP server cannot be resolved Fixes error message in engine-manage-domains if LDAP server cannot be resolved. Change-Id: I8a234d08979b97d8695bb3b7afb76e6998b38c87 Bug-Url: https://bugzilla.redhat.com/1001976 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a234d08979b97d8695bb3b7afb76e6998b38c87 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-scheduler-proxy[master]: Restructure sources and improve the build system
by msivak＠redhat.com 26 Feb '14

26 Feb '14

Martin Sivák has submitted this change and it was merged. Change subject: Restructure sources and improve the build system ...................................................................... Restructure sources and improve the build system This change adds VERSION file to the top level of the project that is then providin the version to all places - Makefile, setup.py and spec file It also moves the plugins that are needed for tests to the tests/ subdirectory and consolidates the documentation to doc/ directory. It then adds OSCHEDPROXY_PLUGINS environment variable that can be used to redefine the plugin directory location and uses it in the tests. Change-Id: I372e83f94c944056b2e5212c75139d23f05ae527 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M Makefile A VERSION R doc/PLUGINS.txt R doc/plugin_samples/even_vm_distribution.py R doc/plugin_samples/host_memory_balance.py R doc/plugin_samples/ksm_same_os_score.py R doc/plugin_samples/max_vm_filter.py R doc/plugin_samples/vm_balance.py R doc/rest_api_samples/singlehost.xml R doc/rest_api_samples/singlevm.xml R ovirt-scheduler-proxy.spec.in M setup.py M src/ovirtscheduler/oschedproxyd.py M src/ovirtscheduler/request_handler_test.py M src/ovirtscheduler/runner_test.py R tests/plugins/test_failing_plugin.py R tests/plugins/test_plugin.py 17 files changed, 50 insertions(+), 28 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jiří Moskovčák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I372e83f94c944056b2e5212c75139d23f05ae527 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: added new layout nightly repositories
by sbonazzo＠redhat.com 26 Feb '14

26 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: added new layout nightly repositories ...................................................................... added new layout nightly repositories Change-Id: I6f46ebdfc8bf957088799d56f912598fc30b96a6 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-release.spec.in M ovirt.repo.in 3 files changed, 50 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f46ebdfc8bf957088799d56f912598fc30b96a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0