February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: block reinitialize on uninitalized pool
by laravot＠redhat.com 26 Feb '14

26 Feb '14

Liron Ar has submitted this change and it was merged. Change subject: webadmin: block reinitialize on uninitalized pool ...................................................................... webadmin: block reinitialize on uninitalized pool When a pool is uninitalized there's no need to allow reinitializing it, any wanted domain can be attached to the pool. Allowing to perform reinitalize in that status caused to NPE in the engine which currently attempts to load the current master domain of the pool. As there's no meaning for recovery/reinitialize in that scenario, it can be blocked - as this issue was never encountered, we can add an engine verification if and when it will be necessary. Change-Id: I480b1f99ae881d43d34342ccb3bb248e60f556ce Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069581 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/25051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I480b1f99ae881d43d34342ccb3bb248e60f556ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fixing restore.sh log file location
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: fixing restore.sh log file location ...................................................................... core: fixing restore.sh log file location Setting default log file to be under /var/log/ovirt-engine if this directory exists Change-Id: I3cd0742896e2fb5cfa79c75147ced47b94c37155 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069714 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/dbcustomfunctions.sh 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Barak Azulay: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cd0742896e2fb5cfa79c75147ced47b94c37155 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: LocalConfig: apply defaults also if key is empty
by yzaslavs＠redhat.com 26 Feb '14

26 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: LocalConfig: apply defaults also if key is empty ...................................................................... utils: LocalConfig: apply defaults also if key is empty we use shell notation for configuration file, there is no difference between missing and empty variable. Change-Id: Ia71bd03f3a0a73af02a4543706815e58489a1396 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia71bd03f3a0a73af02a4543706815e58489a1396 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: fix broken aaa jars
by sbonazzo＠redhat.com 25 Feb '14

25 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: fix broken aaa jars ...................................................................... packaging: spec: fix broken aaa jars Broken by f97cc44c20, 161247d3d Topic: AAA Change-Id: I25bdcf22f5887c9bcd19aa0bc6e3e78d391013e9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25bdcf22f5887c9bcd19aa0bc6e3e78d391013e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Add generic code to check repoclosure
by eedri＠redhat.com 25 Feb '14

25 Feb '14

Eyal Edri has submitted this change and it was merged. Change subject: Add generic code to check repoclosure ...................................................................... Add generic code to check repoclosure Change-Id: I762abf97c9020301a388f7d83c7d1e41bdf1f062 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- A jobs/packaging/repo_closure_check.sh 1 file changed, 150 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, approved Kiril Nesenko: Verified -- To view, visit http://gerrit.ovirt.org/24802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I762abf97c9020301a388f7d83c7d1e41bdf1f062 Gerrit-PatchSet: 18 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Check that the host status is 'UP' before HA reservati...
by iheim＠redhat.com 25 Feb '14

25 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Check that the host status is 'UP' before HA reservation calc. ...................................................................... core: Check that the host status is 'UP' before HA reservation calc. Making sure the only hosts in 'UP' status are in the HA reservation calculation. Change-Id: Ibfd8eb840d70bb0c2f345f04e328cccc5a92439f Bug-Url: https://bugzilla.redhat.com/1057579 Signed-off-by: Kobi Ianko <kobi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Doron Fediuck: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve Kobi Ianko: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfd8eb840d70bb0c2f345f04e328cccc5a92439f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Correct utc_diff handling
by rgolan＠redhat.com 25 Feb '14

25 Feb '14

Roy Golan has submitted this change and it was merged. Change subject: engine: Correct utc_diff handling ...................................................................... engine: Correct utc_diff handling Now the utc_diff is always updated for running VMs (Linux or Windows) and reset on VM run. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1062615 Change-Id: I907cd1ab724b6c3217cc90bd886b678d4bb9d37a Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 2 files changed, 24 insertions(+), 24 deletions(-) Approvals: Martin Betak: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I907cd1ab724b6c3217cc90bd886b678d4bb9d37a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core : No email notification sent when host recovers from pr...
by iheim＠redhat.com 25 Feb '14

25 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core : No email notification sent when host recovers from previously reported condition ...................................................................... core : No email notification sent when host recovers from previously reported condition There is no option in event manager to subscribe for 'Host is responsive' event. Users can choose to receive email notifications for several host conditions listed under "Host Event" section of event notifications. When a user has chosen a specific condition and such condition occurs the user receives an email notification. When such condition is resolved or disappears the user does not receive any email notification alerting him/her that the previously reported condition has been solved is no longer present. Fixes the case where vdsm is rebooted and host comes back to Up status. Change-Id: I2982b21f5d356847d994c6dcdf24e79e56479ecb Bug-Url: https://bugzilla.redhat.com/1013631 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0630_event_map_vds_failure.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2982b21f5d356847d994c6dcdf24e79e56479ecb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi : Handle empty int values in JAX-B parser
by iheim＠redhat.com 25 Feb '14

25 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi : Handle empty int values in JAX-B parser ...................................................................... restapi : Handle empty int values in JAX-B parser JAX-B replacement IntegerParser should handle empty values for integer fields. Set the default value to 0. Change-Id: I3823d8894f316d78f753034fdbd89a79f480516e Bug-Url: https://bugzilla.redhat.com/1064456 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 8cb5ab8ea806ade834e30bc84abd8c1c06dda14e) --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3823d8894f316d78f753034fdbd89a79f480516e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: genericSearch method which does not get filter
by ofrenkel＠redhat.com 25 Feb '14

25 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: genericSearch method which does not get filter ...................................................................... core: genericSearch method which does not get filter We used to have SearchQuery#genericSearch method that gets filter as a parameter and in case we didn't want to filter, we set the filter to null. A more standard way to do it is by adding a method that does not get filter and delegates to the method that gets a filter by passing null as the filter. Change-Id: Ib013b8eb2baa77b6adc01d70c3df0a87482dc296 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 19 insertions(+), 14 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/25021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib013b8eb2baa77b6adc01d70c3df0a87482dc296 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0