March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core : Search VMs based on MAC address
by emesika＠redhat.com 19 Mar '14

19 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: core : Search VMs based on MAC address ...................................................................... core : Search VMs based on MAC address Users should be able to search for VMs from Webadmin-Portal Search bar using a search query filtering on mac address: Vms: Vnic.mac = 00:1a:4a:b4:9b:a8 Change-Id: I42229383647c4494ffab75af1ad6e619ad02fe5f Bug-Url: https://bugzilla.redhat.com/1016916 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkInterfaceConditionFieldAutoCompleter.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42229383647c4494ffab75af1ad6e619ad02fe5f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: database: fix typo in manual instructions
by sbonazzo＠redhat.com 19 Mar '14

19 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: database: fix typo in manual instructions ...................................................................... packaging: setup: database: fix typo in manual instructions Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067548 Change-Id: I86d0fb23cfe7daccc18ef8f1cada94732e50628a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/db/connection.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86d0fb23cfe7daccc18ef8f1cada94732e50628a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Revert "core : Search VMs based on MAC address"
by emesika＠redhat.com 19 Mar '14

19 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: Revert "core : Search VMs based on MAC address" ...................................................................... Revert "core : Search VMs based on MAC address" This reverts commit 44d685653c4b5636ab8423205473181d8f917d80. Change-Id: Ic22f361e4a9eb73a798548121f222cf2a6ab6507 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java M packaging/dbscripts/create_views.sql 2 files changed, 3 insertions(+), 8 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic22f361e4a9eb73a798548121f222cf2a6ab6507 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: packaging: ovirt-host-deploy-1.2.0
by Alon Bar-Lev 18 Mar '14

18 Mar '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: ovirt-host-deploy-1.2.0 ...................................................................... packaging: ovirt-host-deploy-1.2.0 Change-Id: I6dcacc67e2bf8a80c68781fc8dfffe403abcdd11 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac M ovirt-host-deploy-offline.spec.in M ovirt-host-deploy.spec.in 4 files changed, 12 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6dcacc67e2bf8a80c68781fc8dfffe403abcdd11 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: packaging: post ovirt-host-deploy-1.2.0
by Alon Bar-Lev 18 Mar '14

18 Mar '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: post ovirt-host-deploy-1.2.0 ...................................................................... packaging: post ovirt-host-deploy-1.2.0 Change-Id: I6df5c730bedace4aa00ff580ecdd40f560b0eb8b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6df5c730bedace4aa00ff580ecdd40f560b0eb8b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packaging: post otopi-1.2.0
by Alon Bar-Lev 18 Mar '14

18 Mar '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: post otopi-1.2.0 ...................................................................... packaging: post otopi-1.2.0 Change-Id: I3a584413e053043cb812c9d5ad0e40bfd66ba2cc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a584413e053043cb812c9d5ad0e40bfd66ba2cc Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packaging: otopi-1.2.0
by Alon Bar-Lev 18 Mar '14

18 Mar '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: otopi-1.2.0 ...................................................................... packaging: otopi-1.2.0 Change-Id: Ia90326bece94653684c214948e6d5483300ca750 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac M otopi.spec.in 3 files changed, 8 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia90326bece94653684c214948e6d5483300ca750 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UpdateVmDiskCommand - compare enums with ==
by amureini＠redhat.com 18 Mar '14

18 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmDiskCommand - compare enums with == ...................................................................... core: UpdateVmDiskCommand - compare enums with == Use == to compare enums instead of equals(Object), as per the project's conventions. Change-Id: Idc5eea69db33ad4a0431f1123df2594c434d506c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified Liron Ar: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc5eea69db33ad4a0431f1123df2594c434d506c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Rename UpdateVmDiskCommand CDA methods
by amureini＠redhat.com 18 Mar '14

18 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Rename UpdateVmDiskCommand CDA methods ...................................................................... core: Rename UpdateVmDiskCommand CDA methods Renamed shouldUpdate*Properties() methods to update*RuntimeParametersRequested() which better reflects what these methods do - they check if an update to a certain parameter was requested, they do not decide if it's appropriate (as the "should" prefix would suggest). Change-Id: I91789866212b88e39b2e133c2d29c57475a7a624 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 13 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91789866212b88e39b2e133c2d29c57475a7a624 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm UpdateVmDiskCommand unused methods
by amureini＠redhat.com 18 Mar '14

18 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm UpdateVmDiskCommand unused methods ...................................................................... core: rm UpdateVmDiskCommand unused methods Removed UpdateVmDiskCommand#getVmsDiskSnapshotPluggedTo(), which is not used anywhere in the codebase. Change-Id: I7228911b3184858323bd934f1fd890ca6c9fdb21 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7228911b3184858323bd934f1fd890ca6c9fdb21 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0