March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: UpdateVmDiskCommand singletonList
by amureini＠redhat.com 18 Mar '14

18 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmDiskCommand singletonList ...................................................................... core: UpdateVmDiskCommand singletonList Use the better performing Collections.singletonList instead of Arrays.asList. Change-Id: I68f3a676fe51317499783d0f62239069574ae1f2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/25843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68f3a676fe51317499783d0f62239069574ae1f2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: UpdateVmDiskCommand diamond generics
by amureini＠redhat.com 18 Mar '14

18 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmDiskCommand diamond generics ...................................................................... core: UpdateVmDiskCommand diamond generics Use Java 7 style diamond generics for better readability. Change-Id: I0a14bbece3f0b5487e06b5946493cbc819ea5b0c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/25842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a14bbece3f0b5487e06b5946493cbc819ea5b0c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Allow updating wipeAfterDelete for an UP VM
by amureini＠redhat.com 18 Mar '14

18 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Allow updating wipeAfterDelete for an UP VM ...................................................................... core: Allow updating wipeAfterDelete for an UP VM The wipeAfterDelete property simply determines how the VM's volumes should be treated when they are deleted, and has no effect on how the VM is run. There is no reason to disallow updating them when the VM is running. Change-Id: I8fcb93ab0e45798745e2e5accc2d851b6df00d6d Bug-Url: http://bugzilla.redhat.com/1070823 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 22 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fcb93ab0e45798745e2e5accc2d851b6df00d6d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: UI: set correct SSH trust target path in tooltip.
by iheim＠redhat.com 18 Mar '14

18 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: UI: set correct SSH trust target path in tooltip. ...................................................................... UI: set correct SSH trust target path in tooltip. Fixing the path displayed in Install Host form SSH PublicKey field tooltip to the correct value (from .ssh/authorized_keys to /root/.ssh/authorized_keys) Change-Id: I835be95c56978e26a8c849fdbccbdff8a70f5c66 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1068763 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I835be95c56978e26a8c849fdbccbdff8a70f5c66 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: host stuck on Unassigned when moving from status Maint...
by iheim＠redhat.com 18 Mar '14

18 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: core: host stuck on Unassigned when moving from status Maintenance ...................................................................... core: host stuck on Unassigned when moving from status Maintenance This patch makes sure the move of the host from Up to NonOperational is logged in the Audit Log Change-Id: Ib88fcd733ec0b72fca7d8e6d40c4d28a7d926333 Bug-Url: https://bugzilla.redhat.com/962180 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/25836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib88fcd733ec0b72fca7d8e6d40c4d28a7d926333 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: core: VURTI - fix handle expection in GetVmStats
by sbonazzo＠redhat.com 18 Mar '14

18 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: VURTI - fix handle expection in GetVmStats ...................................................................... core: VURTI - fix handle expection in GetVmStats after getting all vms with List command, VURTI loops through them to update internal structure data. BUT if the call fails, VURTI removes the VM from the internal running map - this leads to a split-brains for VURTI assumes the Vm is DOWN and if it HA, its runs it. the fix is to exclude this Vm from the list of the vms that have changed this is similar to a case where Vm didn't changed its status UNIT TEST added a unit test to make sure the VM is kept in the map although the call to GetVmStats didn't made it Bug-Url: https://bugzilla.redhat.com/1072282 Change-Id: I415804d9fa1f1288423241b8547f4cab5540914a Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 3 files changed, 172 insertions(+), 40 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I415804d9fa1f1288423241b8547f4cab5540914a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: core: VURTI - use ResourceManager instead of commands
by sbonazzo＠redhat.com 18 Mar '14

18 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: VURTI - use ResourceManager instead of commands ...................................................................... core: VURTI - use ResourceManager instead of commands Use ResourceManager instead of direct command invocation Add List, GetVmStats and GetAllVmsStats to the list of Command Types Clean-up the code expressions, format, indent etc Change-Id: I16359bf4af4968c8e9d8a650fb2af541ae0cc3fb Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 50 insertions(+), 48 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16359bf4af4968c8e9d8a650fb2af541ae0cc3fb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: history: Changed mem_shared column type and name
by sbonazzo＠redhat.com 18 Mar '14

18 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: history: Changed mem_shared column type and name ...................................................................... history: Changed mem_shared column type and name Removed casting of mem_shared column, and it will now be of int type. Also, changed the ending of the column name to "mb" instead of "percent", because the data is in mb. Change-Id: Ia3a42581d00168d091659d30ebfbc086b1757695 Bug-Url: https://bugzilla.redhat.com/1076902 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/dbscripts/create_dwh_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Yaniv Dary: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3a42581d00168d091659d30ebfbc086b1757695 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: Revert "core: Prevent StopVm to interleave with other VM loc...
by sbonazzo＠redhat.com 18 Mar '14

18 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Revert "core: Prevent StopVm to interleave with other VM locked actions" ...................................................................... Revert "core: Prevent StopVm to interleave with other VM locked actions" This reverts commit 37411acc82c03ba8e3150e5d9b4aad2e6d39a414. Change-Id: I0c12f4e2855e9ddfb6d696167b20352914825a9a Signed-off-by: Roy Golan <rgolan(a)redhat.com> (cherry picked from commit 6dc94d1575513da5f5b42a6d4ed33e9fac64d532) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java 3 files changed, 1 insertion(+), 20 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c12f4e2855e9ddfb6d696167b20352914825a9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: core: Change Vm status on destroy only for SRC VMs
by sbonazzo＠redhat.com 18 Mar '14

18 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: Change Vm status on destroy only for SRC VMs ...................................................................... core: Change Vm status on destroy only for SRC VMs when stopping a migrating VMs, do the state change only if the VM is really running on SRC host. StopVm shoots 2 destroy commands incase the vm is migrating - 1 for the DST and one for the SRC. after the DST is destroy the Vm must not be DOWN, otherwise an interleaving RunVm could start it while we're about to shoot the next stop. that solution is reverting change I6109ef0ea4869b59a93be6fef4b0c3cff50da62e which implemented that with an engine lock Change-Id: I422e75fc863e3416261a4d3eaef4312dc933bdac Bug-Url: https://bugzilla.redhat.com/1064859 Signed-off-by: Roy Golan <rgolan(a)redhat.com> (cherry picked from commit cb3a3c8b68f5d65f54f065f64309444c1507e113) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I422e75fc863e3416261a4d3eaef4312dc933bdac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0