March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: show the errors from external scheduler in the event...
by gchaplik＠redhat.com 18 Mar '14

18 Mar '14

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: show the errors from external scheduler in the event log ...................................................................... engine: show the errors from external scheduler in the event log If there is a problem with the external scheduler or it's plugins, the user should be notified about that. This patch adds support for the new scheduler xmlrpc api which contains the information about, errors encountered while running the plugins. Change-Id: Idd4dbe269d2885a6be04b82a3e2320c4f96c2387 Bug-Url: https://bugzilla.redhat.com/1056540 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/BalanceResult.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerObjectBuilder.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/FilteringResult.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/SchedulerResult.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ScoringResult.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 8 files changed, 282 insertions(+), 63 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd4dbe269d2885a6be04b82a3e2320c4f96c2387 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: clear the pending memory when destroying paused VM
by gchaplik＠redhat.com 18 Mar '14

18 Mar '14

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: clear the pending memory when destroying paused VM ...................................................................... engine: clear the pending memory when destroying paused VM Change-Id: I1de34ac8b0b6e48d360161d8f0ff8d1fe4f6fd04 Bug-Url: https://bugzilla.redhat.com/1049318 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 3 files changed, 30 insertions(+), 20 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1de34ac8b0b6e48d360161d8f0ff8d1fe4f6fd04 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: Better explaining FQDN request
by sbonazzo＠redhat.com 18 Mar '14

18 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Better explaining FQDN request ...................................................................... Better explaining FQDN request Adding a more meaningful text to better explain what host it refers asking a FQDN Change-Id: I1548ad11bc4699b50747ae6978a58874287059f2 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069945 --- M src/plugins/ovirt-hosted-engine-setup/engine/fqdn.py 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1548ad11bc4699b50747ae6978a58874287059f2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.1]: build: post ovirt-hosted-engine-setup-1.1.1
by sbonazzo＠redhat.com 17 Mar '14

17 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-1.1.1 ...................................................................... build: post ovirt-hosted-engine-setup-1.1.1 Change-Id: I21ba34fedfd5127c3ac03e82a0b85f4c71685ef2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21ba34fedfd5127c3ac03e82a0b85f4c71685ef2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Findbugs fixes
by yzaslavs＠redhat.com 17 Mar '14

17 Mar '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Findbugs fixes ...................................................................... aaa: Findbugs fixes Change-Id: I34674920d96ae447e15b96ccc26009f075e85ca3 topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java A backend/manager/modules/builtin-extensions/exclude-filters.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsConfiguration.java 5 files changed, 47 insertions(+), 9 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34674920d96ae447e15b96ccc26009f075e85ca3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Fixing rpm build
by yzaslavs＠redhat.com 17 Mar '14

17 Mar '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Fixing rpm build ...................................................................... aaa: Fixing rpm build Change-Id: I71e74842e71c5adb714488d2c79a227a99e0272a Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71e74842e71c5adb714488d2c79a227a99e0272a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: Generate answer file at cleanup
by iheim＠redhat.com 17 Mar '14

17 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: Generate answer file at cleanup ...................................................................... packaging: setup: Generate answer file at cleanup Generate answer file at end of stage Cleanup instead of stage Closeup. Stage Cleanup is always executed at the end of the run, so the answer file will always be generated - even if e.g. user chooses 'Cancel' at the end of "CONFIGURATION PREVIEW", or presses ^C at any point. Change-Id: I4b6af75001eb3192e6839e57dbb7446344ff29f4 Bug-Url: https://bugzilla.redhat.com/1062717 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/25783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b6af75001eb3192e6839e57dbb7446344ff29f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: TagsDirector diamond generics
by amureini＠redhat.com 17 Mar '14

17 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: TagsDirector diamond generics ...................................................................... core: TagsDirector diamond generics Employ the new Java 7 syntax for better readability. Change-Id: I1436de74aea2a47932d246ddf95e96a0a57baf4f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1436de74aea2a47932d246ddf95e96a0a57baf4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Reduce scope of TagReturnValueIndicator
by amureini＠redhat.com 17 Mar '14

17 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Reduce scope of TagReturnValueIndicator ...................................................................... core: Reduce scope of TagReturnValueIndicator Since TagReturnValueIndicator is only ever used by TagDirector, it should be an inner enum inside it, not a top level enum defined in TagsDirector.java Change-Id: I61b4826d09a76d0b5b1ca7ea8c18683a38ead5f1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/25669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61b4826d09a76d0b5b1ca7ea8c18683a38ead5f1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm TagDirector.GetTagIdAndParentsIds(String)
by amureini＠redhat.com 17 Mar '14

17 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm TagDirector.GetTagIdAndParentsIds(String) ...................................................................... core: rm TagDirector.GetTagIdAndParentsIds(String) This method is not used anywhere in the code, and can safely be removed. Change-Id: Ia382f8ebaaa841cdd8c5bb5c52b2c2e9214df679 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia382f8ebaaa841cdd8c5bb5c52b2c2e9214df679 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0