March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: UI: set correct SSH trust target path in tooltip.
by emesika＠redhat.com 18 Mar '14

18 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: UI: set correct SSH trust target path in tooltip. ...................................................................... UI: set correct SSH trust target path in tooltip. Fixing the path displayed in Install Host form SSH PublicKey field tooltip to the correct value (from .ssh/authorized_keys to /root/.ssh/authorized_keys) Change-Id: I835be95c56978e26a8c849fdbccbdff8a70f5c66 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1068763 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I835be95c56978e26a8c849fdbccbdff8a70f5c66 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix import of cloned template
by ofrenkel＠redhat.com 18 Mar '14

18 Mar '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix import of cloned template ...................................................................... core: fix import of cloned template When importing template as clone, it set wrong template base id, as the id of the template is re-generated. cloned import is a new entity so it should always be a base template Change-Id: Ia8cdd44a1803995d28b806668dfdb6ea8e59597e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073019 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/25748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8cdd44a1803995d28b806668dfdb6ea8e59597e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor refactoring in UpdateVmCommand#canDoAction
by ahadas＠redhat.com 18 Mar '14

18 Mar '14

Arik Hadas has submitted this change and it was merged. Change subject: core: minor refactoring in UpdateVmCommand#canDoAction ...................................................................... core: minor refactoring in UpdateVmCommand#canDoAction Use CommandBase#failCanDoAction instead of CommandBase#addCanDoActionMessage. Change-Id: I5b8056dc31c3ae61dc70ff0ca6073797bcd13671 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 10 insertions(+), 20 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b8056dc31c3ae61dc70ff0ca6073797bcd13671 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing PG 8.4 compatability
by amureini＠redhat.com 18 Mar '14

18 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: fixing PG 8.4 compatability ...................................................................... core: fixing PG 8.4 compatability Since FOREACH is supported only for PG 9.x the following script uses the unnest functions instead. Change-Id: I19cabe0b559abc8e505ce8712065a147631fd75e Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Allon Mureinik: Verified; Looks good to me, approved Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19cabe0b559abc8e505ce8712065a147631fd75e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: host right click menu is missing 'reinstall' option
by emesika＠redhat.com 18 Mar '14

18 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: webadmin: host right click menu is missing 'reinstall' option ...................................................................... webadmin: host right click menu is missing 'reinstall' option Host's right click menu is missing "reinstall" option. Even when it's in maintenance, there is no such option. Instead, there's a link at the bottom left part of host's General sub tab - which is not likely the place where user will search for this option since the rest of this tab is for info about the host (read only). Removes the install link and message from the General Sub Tab. Change-Id: Ib716a984904d6b299cefa981d6d36d5e257e3f1c Bug-Url: https://bugzilla.redhat.com/1065739 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 6 files changed, 184 insertions(+), 229 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Ravi Nori: Verified Gilad Chaplik: Looks good to me, approved Yair Zaslavsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib716a984904d6b299cefa981d6d36d5e257e3f1c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: history: Changed mem_shared column type and name
by emesika＠redhat.com 18 Mar '14

18 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: history: Changed mem_shared column type and name ...................................................................... history: Changed mem_shared column type and name Removed casting of mem_shared column, and it will now be of int type. Also, changed the ending of the column name to "mb" instead of "percent", because the data is in mb. Change-Id: Ia3a42581d00168d091659d30ebfbc086b1757695 Bug-Url: https://bugzilla.redhat.com/1076902 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/dbscripts/create_dwh_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Yaniv Dary: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3a42581d00168d091659d30ebfbc086b1757695 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : Search VMs based on MAC address
by emesika＠redhat.com 18 Mar '14

18 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: core : Search VMs based on MAC address ...................................................................... core : Search VMs based on MAC address Users should be able to search for VMs from Webadmin-Portal Search bar using a search query filtering on mac address: Vms: mac = 00:1a:4a:b4:9b:a8 Change-Id: I0e013038ad19f3750341e8d4156d93de45510d69 Bug-Url: https://bugzilla.redhat.com/1016916 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java M packaging/dbscripts/create_views.sql 2 files changed, 8 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/25805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e013038ad19f3750341e8d4156d93de45510d69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Add man page for engine-backup
by emesika＠redhat.com 18 Mar '14

18 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: tools: Add man page for engine-backup ...................................................................... tools: Add man page for engine-backup Change-Id: I03dd8338a2dbd6ad8ade22db07c7118e0630c17a Bug-Url: https://bugzilla.redhat.com/1074303 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A packaging/man/man8/engine-backup.8 1 file changed, 114 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03dd8338a2dbd6ad8ade22db07c7118e0630c17a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tools: Sync engine-config man pages and help
by emesika＠redhat.com 18 Mar '14

18 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: tools: Sync engine-config man pages and help ...................................................................... tools: Sync engine-config man pages and help Synchronizes content of engine-config man page with information displayed by execution 'engine-config -h'. Change-Id: I16e16973cb24e7e6e3209d229e0cdabfd3ffbc84 Bug-Url: https://bugzilla.redhat.com/1074299 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/bin/engine-config.sh M packaging/man/man8/engine-config.8 2 files changed, 106 insertions(+), 61 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16e16973cb24e7e6e3209d229e0cdabfd3ffbc84 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: keep the HA flag when exporting/importing VM template
by gchaplik＠redhat.com 17 Mar '14

17 Mar '14

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: keep the HA flag when exporting/importing VM template ...................................................................... engine: keep the HA flag when exporting/importing VM template Change-Id: I1018ade28f442e58f96fcdcd0f819650ff5d7bd1 Bug-Url: https://bugzilla.redhat.com/1066406 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1018ade28f442e58f96fcdcd0f819650ff5d7bd1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0