April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: migration progress
by tjelinek＠redhat.com 29 Apr '14

29 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: migration progress ...................................................................... restapi: migration progress Enriches the statistics by the migration progres field. Change-Id: I4b65c756588aec9bfa1d1d36f74324d1b6d6f15a Bug-Url: https://bugzilla.redhat.com/1083049 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/VmStatisticalQuery.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java 3 files changed, 7 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b65c756588aec9bfa1d1d36f74324d1b6d6f15a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: migration progress
by tjelinek＠redhat.com 29 Apr '14

29 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: migration progress ...................................................................... webadmin: migration progress Adds a new column to the VM main tab which is named "Migration" and visualzes the progress using the ProgressBarColumn. Made a special OneColorPercentColumn which is always green (because in contrast to e.g. memory usage it is not true that the bigger the percentage is, the more red the color should be). Change-Id: I31cb4fefe897536b633cce1583881e1e3511c0e8 Bug-Url: https://bugzilla.redhat.com/1083049 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/OneColorPercentColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/ProgressBarColumn.java 4 files changed, 58 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31cb4fefe897536b633cce1583881e1e3511c0e8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: migration progress
by tjelinek＠redhat.com 29 Apr '14

29 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: migration progress ...................................................................... engine: migration progress The goal is to show in webadmin the migration progress of the VM. VDSM already returns as a statistic the migration progress. This is the engine part of the migration progress feature. Change-Id: I5e909b1577a26f83bf46ff14694f0ca66c32076a Bug-Url: https://bugzilla.redhat.com/1083049 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_0340_add_migration_progress_percent_to_vm_dynamic.sql M packaging/dbscripts/vms_sp.sql 11 files changed, 51 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e909b1577a26f83bf46ff14694f0ca66c32076a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: LiveMigrateVmDisksCommand - disk id for perm subject
by oourfali＠redhat.com 29 Apr '14

29 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: LiveMigrateVmDisksCommand - disk id for perm subject ...................................................................... core: LiveMigrateVmDisksCommand - disk id for perm subject Passing diskId instead of imageId for permission subject (as done in I87d7733174b7b5af805f53834c64e032aafbe94b). Change-Id: If10daec3924e99fb728ae65da0f5fbede07aed85 Bug-Url: https://bugzilla.redhat.com/1071687 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If10daec3924e99fb728ae65da0f5fbede07aed85 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: hosted engine maintenance operations
by oourfali＠redhat.com 29 Apr '14

29 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: hosted engine maintenance operations ...................................................................... restapi: hosted engine maintenance operations Add REST API information/commands for hosted engine maintenance. In the host XML, a <HostedEngine> tag will provide information about Hosted Engine on that host (active, configured, score, global and local maintenance status). This will be present only if the request contains the 'All-Content: true' and the HA agent is configurd on the host. Additionally, a new VM action, hosted_engine_maintenance, is provided allowing global maintenance mode to be enabled/disabled through the host the engine vm is currently running on. Change-Id: I72bb087eb6037c2c9f039e989b7261b54534adee Bug-Url: https://bugzilla.redhat.com/1073051 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/ReflectionHelper.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 12 files changed, 132 insertions(+), 5 deletions(-) Approvals: Greg Padgett: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72bb087eb6037c2c9f039e989b7261b54534adee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove update functionality from AttachNetworkToCluster
by lvernia＠redhat.com 29 Apr '14

29 Apr '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Remove update functionality from AttachNetworkToCluster ...................................................................... engine: Remove update functionality from AttachNetworkToCluster The command is no longer used to update networks that are already attached to the cluster, so the update functionality can be removed and the verification that the network didn't exist in the cluster can be put back. Change-Id: I7aae709dfa0f55ab78d9c1f3caddf75c9d27deb9 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworksToClusterCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java 4 files changed, 28 insertions(+), 20 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7aae709dfa0f55ab78d9c1f3caddf75c9d27deb9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: LiveMigrateVmDisksCommand - disk id for perm subject
by amureini＠redhat.com 29 Apr '14

29 Apr '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: LiveMigrateVmDisksCommand - disk id for perm subject ...................................................................... core: LiveMigrateVmDisksCommand - disk id for perm subject Passing diskId instead of imageId for permission subject (as done in I87d7733174b7b5af805f53834c64e032aafbe94b). Change-Id: If10daec3924e99fb728ae65da0f5fbede07aed85 Bug-Url: https://bugzilla.redhat.com/1071687 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If10daec3924e99fb728ae65da0f5fbede07aed85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: add glusterfs domain type
by oourfali＠redhat.com 29 Apr '14

29 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: add glusterfs domain type ...................................................................... packaging: setup: add glusterfs domain type Add glusterfs to the list of available default domain types when application mode is virt or both. Change-Id: I7cb2a86fb8e49109269491b5782c92d454624a44 Bug-Url: https://bugzilla.redhat.com/1046592 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Signed-off-by: Hajime Taira <htaira(a)redhat.com> (cherry picked from commit e90cb0a15b4ff3221e19aff590a2cba8e0c192e0) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cb2a86fb8e49109269491b5782c92d454624a44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools : engine-config's manual should be updated regarding n...
by oourfali＠redhat.com 29 Apr '14

29 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: tools : engine-config's manual should be updated regarding new command --merge ...................................................................... tools : engine-config's manual should be updated regarding new command --merge engine-config --help should display the newly added merge action. Change-Id: I62a510f4c3dde79630af96ffb4ca010301b3cd13 Bug-Url: https://bugzilla.redhat.com/1091942 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 776a8acf1741516e3d4b02d05ff0b2a4d75cef7c) --- M packaging/bin/engine-config.sh M packaging/man/man8/engine-config.8 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62a510f4c3dde79630af96ffb4ca010301b3cd13 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.1]: packaging: setup: query cluster on attempts loop
by sbonazzo＠redhat.com 29 Apr '14

29 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: query cluster on attempts loop ...................................................................... packaging: setup: query cluster on attempts loop _wait_cluster_cpu_ready queried 'cluster.get_cpu()' in a loop, but this did not actually query the engine. So if we did not get the cpu type on first attempt we repeatedly tried checking the same values until timeout. Bug-Url: https://bugzilla.redhat.com/1088572 Bug-Url: https://bugzilla.redhat.com/1084863 Change-Id: I334d7eafda68843827af3f5ceb5132aefaf73f4a Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I334d7eafda68843827af3f5ceb5132aefaf73f4a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.1 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0