April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: [monitoring] clean up unhelpful logs and comments
by rgolan＠redhat.com 29 Apr '14

29 Apr '14

Roy Golan has submitted this change and it was merged. Change subject: core: [monitoring] clean up unhelpful logs and comments ...................................................................... core: [monitoring] clean up unhelpful logs and comments Bug-Url: http://https://bugzilla.redhat.com/1077300 Change-Id: I95bbbe94f22c94e6de9140cf8bf19177896934a9 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 3 files changed, 6 insertions(+), 23 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95bbbe94f22c94e6de9140cf8bf19177896934a9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: history: updated etl process for scalablility
by ydary＠redhat.com 29 Apr '14

29 Apr '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: updated etl process for scalablility ...................................................................... history: updated etl process for scalablility updated the aggregation process to perform hourly and daily aggregations one at a time. Added HourlyAggFailed flag to history_configuration table when hourly aggregation failes. Change-Id: I6d7e6f8ad7238456a1e9cd05396cce217fa02a39 Bug-Url: https://bugzilla.redhat.com/1014134 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/ovirt_engine_dwh/aggregationtodaily_3_4/contexts/Default.properties M etl_export/ovirt_engine_dwh/aggregationtohourly_3_4/contexts/Default.properties M etl_export/ovirt_engine_dwh/dailytimekeepingjob_3_4/contexts/Default.properties M etl_export/ovirt_engine_dwh/hourlytimekeepingjob_3_4/contexts/Default.properties M etl_export/src/ovirt_engine_dwh/aggregationtodaily_3_4/AggregationToDaily.java M etl_export/src/ovirt_engine_dwh/aggregationtohourly_3_4/AggregationToHourly.java M etl_export/src/ovirt_engine_dwh/dailytimekeepingjob_3_4/DailyTimeKeepingJob.java M etl_export/src/ovirt_engine_dwh/hourlytimekeepingjob_3_4/HourlyTimeKeepingJob.java M packaging/dbscripts/insert_timekeeping_values.sql A packaging/dbscripts/upgrade/03_04_0090_add_HourlyAggFailed.sql M tos_project/process/AggregationToDaily_3.4.item M tos_project/process/AggregationToDaily_3.4.properties M tos_project/process/AggregationToHourly_3.4.item M tos_project/process/AggregationToHourly_3.4.properties M tos_project/process/DailyTimeKeepingJob_3.4.item M tos_project/process/DailyTimeKeepingJob_3.4.properties M tos_project/process/HourlyTimeKeepingJob_3.4.item M tos_project/process/HourlyTimeKeepingJob_3.4.properties 18 files changed, 8,678 insertions(+), 4,519 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d7e6f8ad7238456a1e9cd05396cce217fa02a39 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Fix temproaral disabling foreign keys
by oourfali＠redhat.com 29 Apr '14

29 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix temproaral disabling foreign keys ...................................................................... core: Fix temproaral disabling foreign keys The temporal disabling of foreign keys did not work causing upgrade to fail Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1091227 Change-Id: I2fafc5c18bf07c5bef9805d2bfd8c4590ba226f8 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/dbscripts/upgrade/03_04_0730_change_group_ids.sql M packaging/dbscripts/upgrade/03_04_0740_update_user_ids.sql 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fafc5c18bf07c5bef9805d2bfd8c4590ba226f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix temproaral disabling foreign keys
by emesika＠redhat.com 29 Apr '14

29 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix temproaral disabling foreign keys ...................................................................... core: Fix temproaral disabling foreign keys The temporal disabling of foreign keys did not work causing upgrade to fail Change-Id: I32867ef58f179428c69e74d61a89dc6b2b9c2e89 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1091227 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/dbscripts/upgrade/03_05_0210_change_group_ids.sql M packaging/dbscripts/upgrade/03_05_0220_update_user_ids.sql 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32867ef58f179428c69e74d61a89dc6b2b9c2e89 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: agent: setNumberOfCPUs support
by vfeenstr＠redhat.com 29 Apr '14

29 Apr '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: agent: setNumberOfCPUs support ...................................................................... agent: setNumberOfCPUs support Change-Id: I0b03bd96bd52b76e7d3bf1f8bbcdd7d8e8fbc560 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/OVirtAgentLogic.py 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b03bd96bd52b76e7d3bf1f8bbcdd7d8e8fbc560 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Static IP is set as none bootproto for cloud-init
by oourfali＠redhat.com 29 Apr '14

29 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Static IP is set as none bootproto for cloud-init ...................................................................... core: Static IP is set as none bootproto for cloud-init 1. Setting the bootproto for static if not dhcp (was set as none) 2. Adding display name for NetworkBootProtocol enum 3. Fix CloudInitHandler for sending nulls for ip and subnet on dhcp bootproto. Change-Id: I53159a6ead92d890f7abe2ec78196bb967994a5f Bug-Url: https://bugzilla.redhat.com/1036013 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkBootProtocol.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 3 files changed, 21 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53159a6ead92d890f7abe2ec78196bb967994a5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix temproaral disabling foreign keys
by emesika＠redhat.com 29 Apr '14

29 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix temproaral disabling foreign keys ...................................................................... core: Fix temproaral disabling foreign keys The temporal disabling of foreign keys did not work causing upgrade to fail Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1091227 Change-Id: I2fafc5c18bf07c5bef9805d2bfd8c4590ba226f8 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/dbscripts/upgrade/03_05_0210_change_group_ids.sql M packaging/dbscripts/upgrade/03_05_0220_update_user_ids.sql 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/27184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fafc5c18bf07c5bef9805d2bfd8c4590ba226f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: Try to load the virtio_console module before starting
by vfeenstr＠redhat.com 29 Apr '14

29 Apr '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Try to load the virtio_console module before starting ...................................................................... Try to load the virtio_console module before starting Change-Id: I124bf87f940dae09cb237439e213326a8747938a Bug-Url: https://bugzilla.redhat.com/1061139 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/ovirt-guest-agent.service 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I124bf87f940dae09cb237439e213326a8747938a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: TaskHandlerCommand inteface - taskEndSuccessfully
by derez＠redhat.com 29 Apr '14

29 Apr '14

Daniel Erez has submitted this change and it was merged. Change subject: core: TaskHandlerCommand inteface - taskEndSuccessfully ...................................................................... core: TaskHandlerCommand inteface - taskEndSuccessfully Added taskEndSuccessfully signature to TaskHandlerCommand interface (can be executed from the task handler when it's ended successfully...). Change-Id: Id7b85d05c8031174632a6aaa8c8450dd8836e274 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmHibernationVolumesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskHandlerCommand.java 9 files changed, 47 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7b85d05c8031174632a6aaa8c8450dd8836e274 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: keep proper USB support selection
by tjelinek＠redhat.com 29 Apr '14

29 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: keep proper USB support selection ...................................................................... userportal,webadmin: keep proper USB support selection There were 2 problems: 1: the UnitVmModel.initUsbPolicy() did set the USB policy always to "disabled". Fixed by making sure that if the previously selected still applys than select it 2: The UnitVmModel.updateDisplayProtocol() have delegated the selection of the old display protocol to behavior.postDisplayTypeItemChanged which is too late, because meanwhile the VNC has been selected by getDisplayProtocol().setItems() which fired an appropriate event which in turn changed the USB support to "disabled" Fixed by removing the logic from VmModelBehaviorBase and moved it into the updateDisplayProtocol() to make sure the event is fired only when needed. Change-Id: I7e1b1048784e9d0c289fab13b4d8b9b80afd6cc9 Bug-Url: https://bugzilla.redhat.com/966415 Bug-Url: https://bugzilla.redhat.com/1080144 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 22 insertions(+), 53 deletions(-) Approvals: Tomas Jelinek: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e1b1048784e9d0c289fab13b4d8b9b80afd6cc9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0