April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: prevent session fixation
by awels＠redhat.com 07 Apr '14

07 Apr '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: prevent session fixation ...................................................................... userportal, webadmin: prevent session fixation - This patch creates a new session when a user attempts to log in. This is to prevent session fixation attacks. Change-Id: I3df427683c924f10cb59f4af1dd067fcfd21a8f2 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3df427683c924f10cb59f4af1dd067fcfd21a8f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tools : engine-config is over writing the previous values
by emesika＠redhat.com 07 Apr '14

07 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: tools : engine-config is over writing the previous values ...................................................................... tools : engine-config is over writing the previous values 'engine-config -s' is over writing the existing values with the new ones from command line. A new option to merge the new values provided with the values in the database has been added. 'engine-config -m' or 'engine-config --merge' This concatenates the new value with the exisiting value in the database. Change-Id: I5c70539f47c509e3b8c23b1aa3de41bead36c1b4 Bug-Url: https://bugzilla.redhat.com/1069768 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/ConfigActionType.java M packaging/etc/engine-config/engine-config.properties 4 files changed, 83 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified Yair Zaslavsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c70539f47c509e3b8c23b1aa3de41bead36c1b4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:Failed to create data center with default version
by emesika＠redhat.com 07 Apr '14

07 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: core:Failed to create data center with default version ...................................................................... core:Failed to create data center with default version This patch fill implicitly the latest supported version as the compatibility version of the DC when creating a new DC without giving a specified version. Change-Id: I158397e214db50fbf4eb753a45fcb6533ba8b97d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1053062 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java 2 files changed, 13 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I158397e214db50fbf4eb753a45fcb6533ba8b97d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup - rename argument to adhere to convention
by rgolan＠redhat.com 07 Apr '14

07 Apr '14

Roy Golan has submitted this change and it was merged. Change subject: core: cleanup - rename argument to adhere to convention ...................................................................... core: cleanup - rename argument to adhere to convention Change-Id: I7958c26ee7d92f9e9319200bab1cc0e09a9ecf93 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Roy Golan: Verified -- To view, visit http://gerrit.ovirt.org/26494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7958c26ee7d92f9e9319200bab1cc0e09a9ecf93 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: event on interface status change
by alkaplan＠redhat.com 07 Apr '14

07 Apr '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: event on interface status change ...................................................................... engine: event on interface status change When the status of the interface/bond is changed an event should be reported in the following cases- 1. There is a network or label on the interface/bond 2. The interface is a slave of a bond and 1 is true for the parent bond. There won't be more than one event per interface each 30 minutes. Change-Id: I76953e4b52e35d2e18b6bc68051fa7dd6f3db129 Bug-Url: https://bugzilla.redhat.com/1079719 Bug-Url: https://bugzilla.redhat.com/987299 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties A packaging/dbscripts/upgrade/03_05_0230_add_host_interface_status_change_events.sql 7 files changed, 86 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76953e4b52e35d2e18b6bc68051fa7dd6f3db129 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: adding bond status to host interface subtab
by alkaplan＠redhat.com 07 Apr '14

07 Apr '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: adding bond status to host interface subtab ...................................................................... webadmin: adding bond status to host interface subtab This patch contains two changes- 1. Adding status icon next to the bond icon. 2. Changing green vlan icon to grey icon to emphasize the icon doesn't represent the vlan status. Change-Id: I32a1f30a4a0668ed38ba3987c9e5dfcfece4ca55 Bug-Url: https://bugzilla.redhat.com/1079719 Bug-Url: https://bugzilla.redhat.com/987299 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split-rotate.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_down.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_rotate.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_up.png 7 files changed, 12 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32a1f30a4a0668ed38ba3987c9e5dfcfece4ca55 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: do not override answer file when applying ...
by sbonazzo＠redhat.com 07 Apr '14

07 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: do not override answer file when applying post install removal ...................................................................... packaging: setup: do not override answer file when applying post install removal OVESETUP_SYSTEM/nfsConfigEnabled should be removed from post install file. we need to find a way to do that in generic way, but for time being we provide local solution. the last method we have done to set None at boot stage is good, however the answer file is configuration just like the post install file, we have no way to distinguish. without setting the value at boot stage, the issue would have been resolved at the 2nd setup run, but we want it to be solved at the next setup run. to mark this legacy state a new postinstall variable was added, if it is None then we know that we have legacy post-install and we do not look into the content of OVESETUP_SYSTEM/nfsConfigEnabled. Bug-Url: https://bugzilla.redhat.com/1056777 Change-Id: I907380d1d39c33ffcc43fdd49192a5096a000539 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 2 files changed, 43 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I907380d1d39c33ffcc43fdd49192a5096a000539 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: Engine: Enable Cloud-Init SSH login via public key
by oourfali＠redhat.com 07 Apr '14

07 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: Engine: Enable Cloud-Init SSH login via public key ...................................................................... Engine: Enable Cloud-Init SSH login via public key Fixes: 1. Root is able to login via public key and password 2. Root password is not expired, i.e. no need to change password first login (only if password was set) Bug-Url: https://bugzilla.redhat.com/1082636 Change-Id: Idb48fe4306f803aca801c03ddf29f010eaeb635f Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb48fe4306f803aca801c03ddf29f010eaeb635f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix listing name for Intel Haswell
by emesika＠redhat.com 07 Apr '14

07 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix listing name for Intel Haswell ...................................................................... core: Fix listing name for Intel Haswell All Intel models are listed as "Intel <Model> Family", except for Haswell, wich does no contain "Family" in its listing name. Fixing. Change-Id: I8a8fd8e270bb23200f0d25f00afa8f7108a0f0a0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1079420 Signed-off-by: Amador Pahim <apahim(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a8fd8e270bb23200f0d25f00afa8f7108a0f0a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Dual mode shouldn't be sent to vdsm on hotplug nic
by oourfali＠redhat.com 07 Apr '14

07 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Dual mode shouldn't be sent to vdsm on hotplug nic ...................................................................... engine: Dual mode shouldn't be sent to vdsm on hotplug nic Since 3.0 vdsm doesn't support Dual mode on vm interface. When running a vm, VmInfoBuilder takes care of replacing the interface type in case it is Dual mode. This patch adds the same treatment to hot plug nic. Bug-Url: https://bugzilla.redhat.com/1079992 Bug-Url: https://bugzilla.redhat.com/1083959 Change-Id: Ifdc878a5f8391659a58cf25f2f9137c944689ce4 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 15 insertions(+), 22 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdc878a5f8391659a58cf25f2f9137c944689ce4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0