April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: db: removing deprecated GLOBAL from temp table...
by emesika＠redhat.com 06 Apr '14

06 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: db: removing deprecated GLOBAL from temp table... ...................................................................... db: removing deprecated GLOBAL from temp table... removing deprecated GLOBAL from temp table creation Postgres 9.2 makes the GLOBAL keyword in temp table creation deprecated. http://www.postgresql.org/docs/9.2/static/sql-createtable.html : TEMPORARY or TEMP : Optionally, GLOBAL or LOCAL can be written before TEMPORARY or TEMP. This presently makes no difference in PostgreSQL and is deprecated; see Compatibility. This patch removes this keyword for db code. Change-Id: I72b6517c32675f36491fea2d15c6026b15dfbf6c Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/create_functions.sql M packaging/dbscripts/storages_sp.sql M packaging/dbscripts/vm_pools_sp.sql 3 files changed, 8 insertions(+), 8 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72b6517c32675f36491fea2d15c6026b15dfbf6c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: check if vds is null on setUpStatus callback.
by oourfali＠redhat.com 06 Apr '14

06 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: backend: check if vds is null on setUpStatus callback. ...................................................................... backend: check if vds is null on setUpStatus callback. In case an erroneous vds has been deleted, the callback should do nothing. Change-Id: Ibbae7d5024a9854146e3a1fbe6091baeb53f7b22 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbae7d5024a9854146e3a1fbe6091baeb53f7b22 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: logging change in VdsManager.
by oourfali＠redhat.com 06 Apr '14

06 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: backend: logging change in VdsManager. ...................................................................... backend: logging change in VdsManager. Users do not care about called method name but about what it does. Change-Id: I25dc387dfa6b9499115bcd811c9bffb45b09e996 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066693 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: mooli tayer: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25dc387dfa6b9499115bcd811c9bffb45b09e996 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: rename callback to recoverFromError
by oourfali＠redhat.com 06 Apr '14

06 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: backend: rename callback to recoverFromError ...................................................................... backend: rename callback to recoverFromError Change-Id: Id4e71de8607dab049f128ae4af253d57ffe8b115 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066693 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: mooli tayer: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4e71de8607dab049f128ae4af253d57ffe8b115 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: bugfix in VdsManager on failedToRunVm
by oourfali＠redhat.com 06 Apr '14

06 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: backend: bugfix in VdsManager on failedToRunVm ...................................................................... backend: bugfix in VdsManager on failedToRunVm Bug description: onVdsDuringFailureTimer assumes that number of attempts is always >= 0 but this assumption is not always true. The reason for this is that pausing a quartz job does not insure it will not run anymore but simply pauses the trigger, so previously scheduled jobs might still run. This is resolved by using simpler one time scheduling. This patch introduces a behavioral change: Previously onVdsDuringFailureTimer would reduce failed attempt by 1 (which is problamatic since it no longer represents failed attempts when it is decremented by 1 every x time). Previously there would be a competition between onVdsDuringFailureTimer calls to failedToRunVm calls. Now whenever attempt limit is reached number of attempts is set to 0. The effect of this is if we have a host failing to run vms and those vms were able to run on other hosts and we detect no oter problem on in (its status is up) it will keep trying to recover every 30 min (default) regardless. New behavior is consistent and easy to understand. Change-Id: Ia4dd140ceecf4954e65ea3f6174a41acea82f6a6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066693 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 15 insertions(+), 23 deletions(-) Approvals: mooli tayer: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4dd140ceecf4954e65ea3f6174a41acea82f6a6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: add documentation to vds manager
by oourfali＠redhat.com 06 Apr '14

06 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: backend: add documentation to vds manager ...................................................................... backend: add documentation to vds manager Change-Id: I35f3fbfd76f4778859c15e7a9d499a7f302eda6b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066693 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: mooli tayer: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35f3fbfd76f4778859c15e7a9d499a7f302eda6b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: frontend: Proper VM SystemTab Validation
by oourfali＠redhat.com 06 Apr '14

06 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: Proper VM SystemTab Validation ...................................................................... frontend: Proper VM SystemTab Validation UnitVmModel#validate() used async query to get max valid mem size and thus caused race with submiting the Vm dialog so the memory was not validated at all. Added missing validation for whole SystemTab. Removed unused AsyncDataProvider methods to get various memory-limit related ConfigValues and corresponding (also unused) UnitVmModel fields. Added support for TB memory size in MemorySizeParser and disabled parsing of garbled input '12a30 MB' as longest valid prefix ('12 MB'). Removed ByteSizeValidation since it didn't validate anything. It validated only String entities and the memory size is an EntityModel<Integer>. All validation is performed in validateMemorySize in conjuction with MemorySizeParser. Change-Id: I33761ac7c5491c17fff928de13fdf16065d47e1e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069628 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/parser/MemorySizeParser.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ByteSizeValidation.java 5 files changed, 48 insertions(+), 197 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/26387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33761ac7c5491c17fff928de13fdf16065d47e1e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: docs internal server error
by oourfali＠redhat.com 06 Apr '14

06 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: docs internal server error ...................................................................... engine: docs internal server error - If you try to load a manual document in a locale that doesn't exist, the server would throw a 500 due to a problem in the setup of path of the DocsServlet. This patch fixes that issue. - If you try to load a manual document in a locale that doesn't exist, you will get a 404 instead of a warning message that the language is not available. - Fixed issue in the path of the link that would forward you to the english documentation. - Fixed issue in the cookie path that would store if you had been shown the warning message yet. Change-Id: I3036d05e736a4bc2603423fb7041910a9daa1472 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1083528 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/DocsServlet.java 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Verified Kiril Nesenko: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3036d05e736a4bc2603423fb7041910a9daa1472 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: frontend: hotfix - spice activex plugin upgrade in ie11
by oourfali＠redhat.com 06 Apr '14

06 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: hotfix - spice activex plugin upgrade in ie11 ...................................................................... frontend: hotfix - spice activex plugin upgrade in ie11 This hotfix handles broken logic for retrieving spice activex version on in the engine which prevented ie11 clients to install updates. Change-Id: I86615c88545ba26282c4f891389e4b94e85de117 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1072409 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/26399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86615c88545ba26282c4f891389e4b94e85de117 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: fixing column alias in create_views.sql
by emesika＠redhat.com 05 Apr '14

05 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: db: fixing column alias in create_views.sql ...................................................................... db: fixing column alias in create_views.sql This patch fixes and issue caused by patch http://gerrit.ovirt.org/#/c/25880 in create_views.sql on line 779. Instead of vds_statistics.boot_time there should be vds_statistics.boot_time as boot_time Change-Id: Ia4e0094b1488f7fc452dc9c34bf9f6906a5a22ac Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4e0094b1488f7fc452dc9c34bf9f6906a5a22ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0