May 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fixed add/remove widget in 'add bond' dialog
by lvernia＠redhat.com 22 May '14

22 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: fixed add/remove widget in 'add bond' dialog ...................................................................... webadmin: fixed add/remove widget in 'add bond' dialog PatternFly update broke the add/remove widget in 'Hosts > Networks Interfaces > Setup Host Network > add bond' dialog. Fixed. Change-Id: I1c5b43d919b5418790fd6bf2cd3d5c4335435cb1 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml M packaging/branding/ovirt.brand/patternfly-custom-hacks.css 3 files changed, 35 insertions(+), 28 deletions(-) Approvals: Greg Sheremeta: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c5b43d919b5418790fd6bf2cd3d5c4335435cb1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: use db creds from answer file
by ydary＠redhat.com 22 May '14

22 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: use db creds from answer file ...................................................................... packaging: setup: use db creds from answer file Change-Id: Icac431a840c1207313c5a4b6e47eace93d1dd099 Bug-Url: https://bugzilla.redhat.com/1094016 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icac431a840c1207313c5a4b6e47eace93d1dd099 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: Move JASPER_HOME init to common
by ydary＠redhat.com 22 May '14

22 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Move JASPER_HOME init to common ...................................................................... packaging: setup: Move JASPER_HOME init to common Without this, engine-cleanup fails. Bug-Url: https://bugzilla.redhat.com/1098149 Change-Id: I3354802b902bb99a593a5028a5b3685787b579c8 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/config/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/config/jasper.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jasper.py 3 files changed, 78 insertions(+), 10 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3354802b902bb99a593a5028a5b3685787b579c8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: remove jobs of IVdsAsyncCommands on engine startup
by ahadas＠redhat.com 22 May '14

22 May '14

Arik Hadas has submitted this change and it was merged. Change subject: core: remove jobs of IVdsAsyncCommands on engine startup ...................................................................... core: remove jobs of IVdsAsyncCommands on engine startup Since commands that inherit from IVdsAsyncCommand are not saved to db, after engine restart we cannot continue to track them. That also means that the jobs of such commands are not cleaned after engine restarts. The solution is to remove the jobs of such commands that remained in running ('STARTED') state. It is safe to do so because the commands are not restored after the restart so no one will try to access those jobs. Change-Id: I5973c05f41b90ec48c2961c6f89f5aa110944d6d Bug-Url: https://bugzilla.redhat.com/1040952 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDaoDbFacadeImpl.java M packaging/dbscripts/job_sp.sql 4 files changed, 22 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/27372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5973c05f41b90ec48c2961c6f89f5aa110944d6d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: Fixed date range in reports queries
by ydary＠redhat.com 22 May '14

22 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: Fixed date range in reports queries ...................................................................... reports: Fixed date range in reports queries Fixed the date range so it will not include the end date (excluded). Change-Id: Ibc1a798aa9b7319d89490ca4ef859ab4dda26598 Bug-Url: https://bugzilla.redhat.com/1085820 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Executive/active_vms_by_os_br18_files/active_vms_by_os_br18_jrxml.data M packaging/ovirt-reports/resources/Reports/Executive/cluster_capacity_vs_usage_br19_files/cluster_capacity_vs_usage_br19_jrxml.data M packaging/ovirt-reports/resources/Reports/Executive/summary_of_host_usage_resources_br17_files/summary_of_host_usage_resources_br17_jrxml.data M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/br7_table.jrxml.data M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/cluster_uptime_br7_jrxml.data M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/single_host_uptime_br8_files/single_host_uptime_br8_jrxml.data M packaging/ovirt-reports/resources/Reports/Service_level/VMs/cluster_quality_of_service_vms_br13_files/cluster_quality_of_service_vms_br13_jrxml.data M packaging/ovirt-reports/resources/Reports/Service_level/VMs/single_vm_uptime_br46_files/single_vm_uptime_br46_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/multiple_vms_resource_usage_over_time_br16_files/multiple_vms_resource_usage_over_time_br16_jrxml.data 9 files changed, 17 insertions(+), 17 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc1a798aa9b7319d89490ca4ef859ab4dda26598 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add the domain detaching state
by derez＠redhat.com 22 May '14

22 May '14

Daniel Erez has submitted this change and it was merged. Change subject: core: add the domain detaching state ...................................................................... core: add the domain detaching state This patch adds an additional "Detaching" domain state used to track the ongoing operation so that we can do more informed decisions (for example building the storage pool domains map). Change-Id: I5732ef00a67ef1381ee0b6f29d08ab39cf63a1bf Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatus.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StorageDomainStatus.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainStatusColumn.java 10 files changed, 20 insertions(+), 4 deletions(-) Approvals: Federico Simoncelli: Verified Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liron Ar: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5732ef00a67ef1381ee0b6f29d08ab39cf63a1bf Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Support ; current on cdroms collection
by juan.hernandez＠redhat.com 22 May '14

22 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Support ;current on cdroms collection ...................................................................... restapi: Support ;current on cdroms collection Add support for displaying current CDs (as opposed the configured) using the ;current matrix parameter on the BackendCdRomsResource. So far it was possible to get current CD only per individual VM (using BackendCdRomResource) Change-Id: Iaa14b3ceb09ab8d824fa9fae0ef3eb7d4df7f855 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092070 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCdRomResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCdRomsResource.java 4 files changed, 29 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/27974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa14b3ceb09ab8d824fa9fae0ef3eb7d4df7f855 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin:Removed console tab from new/edit cluster popup in ...
by kmayilsa＠redhat.com 22 May '14

22 May '14

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin:Removed console tab from new/edit cluster popup in gluster only mode ...................................................................... webadmin:Removed console tab from new/edit cluster popup in gluster only mode Console side tab in new/edit cluster dialog to configure a SPICE proxy for individual clusters is removed from Gluster only mode. Change-Id: I00a7fa05b42180d3b582bd7d1374d40b3de8e72f Bug-Url: https://bugzilla.redhat.com/1096665 Signed-off-by: Karnan <kchidamb(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Karnan t c: Verified anmolbabu: Looks good to me, but someone else must approve Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00a7fa05b42180d3b582bd7d1374d40b3de8e72f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: [RFE] Restart HA VMs ASAP
by emesika＠redhat.com 22 May '14

22 May '14

Eli Mesika has submitted this change and it was merged. Change subject: core: [RFE] Restart HA VMs ASAP ...................................................................... core: [RFE] Restart HA VMs ASAP [RFE] Restart HA VMs when power management reports host is in powered off state This patch changes the following flows 1) soft-fencing : if Host has PM configured, check host status and if it is off , skip soft-fencing and put host status to DOWN 2) Restart : if Host has PM configured, check host status and if it is off , skip the stop command and put host status to DOWN The result of that is a faster HA VMs release on the fenced host and restart on another host saving us unnecessary retries and wait time. Change-Id: Iaca0111d13a625014fb424bdccd3709b8ea03382 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058737 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java 3 files changed, 79 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaca0111d13a625014fb424bdccd3709b8ea03382 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Validate action links are terminated properly
by juan.hernandez＠redhat.com 22 May '14

22 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Validate action links are terminated properly ...................................................................... restapi: Validate action links are terminated properly Due to code generator limitations, the action links are not allowed to be terminated by "/". The patch provides the validation for it. Signed-off-by: Moti Asayag <masayag(a)redhat.com> Change-Id: I22e52348e3ecc95599907fb04f6ec63fdc2b07b0 --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22e52348e3ecc95599907fb04f6ec63fdc2b07b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0