May 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: No trailing / in network labels metadata
by juan.hernandez＠redhat.com 21 May '14

21 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: No trailing / in network labels metadata ...................................................................... restapi: No trailing / in network labels metadata The RSDL metadata that describes the operations to add network labels contains an extra slash at the end of the URL. This makes the RSDL generator ignore the URL. As a result the RSDL documentation doesn't contains the headers, and the SDKs are generated incorrectly. Change-Id: I88781dad71e9dca372de6a84c5c2eb3c8d36c21f Bug-Url: https://bugzilla.redhat.com/1099415 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88781dad71e9dca372de6a84c5c2eb3c8d36c21f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: rename upgrade script
by mlipchuk＠redhat.com 21 May '14

21 May '14

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: rename upgrade script ...................................................................... engine: rename upgrade script Change-Id: Ic1ce90bebe53e4554a2c6024b56aa6ff769f58f6 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- R packaging/dbscripts/upgrade/03_05_0480_add_org_name_for_sysprep.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1ce90bebe53e4554a2c6024b56aa6ff769f58f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Repair disallow RO in UI
by oourfali＠redhat.com 21 May '14

21 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Repair disallow RO in UI ...................................................................... webadmin: Repair disallow RO in UI Qemu currently does not support direct-LUN disks connected using VirtIO-SCSI. This patch blocks this option from UI when adding/editing/attaching a direct-LUN disk with VirtIO-SCSI interface to a VM. This wasn't checked in Add/Edit Disk to Vm dialog, nor in Attach table. IDE behaviour was changed to comply with this behaviour in this patch as well. This patch also removes un-needed verfication for IDE disk. Change-Id: Ieb1923d03785be7f228076e12f4865242aed5c90 Bug-Url: https://bugzilla.redhat.com/1097754 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 21 insertions(+), 21 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/27958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb1923d03785be7f228076e12f4865242aed5c90 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix potential NPE when in CheckboxColumn
by oourfali＠redhat.com 21 May '14

21 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix potential NPE when in CheckboxColumn ...................................................................... webadmin: Fix potential NPE when in CheckboxColumn getValue(object)) in checkboxColumn.render() might return null, resulting in an NPE when used in if. Fix the if to handle null. Note: this bug could only occur if a checkboxColumn is not editable *and* it's value is null. Change-Id: I26f688984083fbd6964972e79e50960b254c547b Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1097754 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/27957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26f688984083fbd6964972e79e50960b254c547b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: resetapi: root password return via GetVmsInitQuery
by shavivi＠redhat.com 21 May '14

21 May '14

Shahar Havivi has submitted this change and it was merged. Change subject: resetapi: root password return via GetVmsInitQuery ...................................................................... resetapi: root password return via GetVmsInitQuery No need to return the password only indicate that the password is set in DataBase Change-Id: I97aa160a00d2777dfd4eafa45f21a9f5d7c4ef4b Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsInitQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 3 files changed, 17 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97aa160a00d2777dfd4eafa45f21a9f5d7c4ef4b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Engine: add Admin password and OrgName for Sysprep
by shavivi＠redhat.com 21 May '14

21 May '14

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: add Admin password and OrgName for Sysprep ...................................................................... Engine: add Admin password and OrgName for Sysprep Changes: DB: added org_name column to vm_init table restapi: added org_name field to initialization element UI: Sysprep two new fields: admin-password, organization-name engine: set Sysprep appropriate values for admin-password and organization-name Change-Id: Ie33cce7b395ba8e7e7a46bc31a7564410f808888 https://bugzilla.redhat.com/1025831 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInit.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmInitDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/MatchFieldsValidator.java A packaging/dbscripts/upgrade/03_05_0470_add_org_name_for_sysprep.sql M packaging/dbscripts/vms_sp.sql 13 files changed, 343 insertions(+), 101 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie33cce7b395ba8e7e7a46bc31a7564410f808888 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: child count is not updated for template
by shavivi＠redhat.com 21 May '14

21 May '14

Shahar Havivi has submitted this change and it was merged. Change subject: core: child count is not updated for template ...................................................................... core: child count is not updated for template Change-Id: Ia6ddedc913bb0a383f560c03282b1ab5295bd4bb Bug-Url: https://bugzilla.redhat.com/1006313 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_0470_update_vm_static_child_count.sql M packaging/dbscripts/vms_sp.sql 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6ddedc913bb0a383f560c03282b1ab5295bd4bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: handle credentials incorrect
by yzaslavs＠redhat.com 21 May '14

21 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: handle credentials incorrect ...................................................................... aaa: handle credentials incorrect CREDENTIALS_INVALID - user does not exist CREDENTIALS_INCORRECT - password incorrect engine does not have these two, so map them into the same. Topic: AAA Change-Id: I1e9c4edf6547f0483fd2484e575eeb762720eee2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e9c4edf6547f0483fd2484e575eeb762720eee2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup - Fix InActive typo
by derez＠redhat.com 20 May '14

20 May '14

Daniel Erez has submitted this change and it was merged. Change subject: core: cleanup - Fix InActive typo ...................................................................... core: cleanup - Fix InActive typo Inactive is one word. Changed InActive usages to Inactive throughout the system, mainly in StorageDomainStatus & StorageDomainSharedStatus enums. Change-Id: I3683e31ffa6965a6eef91a4eb52ae8bab4703fd2 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageConnectionValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainSharedStatus.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatus.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/VdcActionUtilsTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageDomainMapperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ManageBackupModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainSharedStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainStatusColumn.java 30 files changed, 48 insertions(+), 48 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/27655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3683e31ffa6965a6eef91a4eb52ae8bab4703fd2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed edit icons in Setup Host Network dialog pt 2
by lvernia＠redhat.com 20 May '14

20 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: fixed edit icons in Setup Host Network dialog pt 2 ...................................................................... webadmin: fixed edit icons in Setup Host Network dialog pt 2 Bond panels had a white raised button background behind the edit icons. These shouldn't be there. Removed. Change-Id: Idb45622db8cf5bed3010fe7d215c89c40fa7df01 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Greg Sheremeta: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb45622db8cf5bed3010fe7d215c89c40fa7df01 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0