May 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Change height of label widgets
by lvernia＠redhat.com 08 May '14

08 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Change height of label widgets ...................................................................... webadmin: Change height of label widgets Played around with the heights to make dialogs related to the label widgets look tighter. Change-Id: Iff2e5474b4d407380f713a9f1312e778cfb9c446 Bug-Url: https://bugzilla.redhat.com/1030955 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java 3 files changed, 5 insertions(+), 3 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff2e5474b4d407380f713a9f1312e778cfb9c446 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Refine CIDR validation message
by lvernia＠redhat.com 08 May '14

08 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Refine CIDR validation message ...................................................................... webadmin: Refine CIDR validation message Added an explanation of the valid values inside a CIDR address. Change-Id: I906eb4a2b59a02c4ca22747cb56e8dbf14165590 Bug-Url: https://bugzilla.redhat.com/1078183 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I906eb4a2b59a02c4ca22747cb56e8dbf14165590 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fixed alignment in ProviderPopupView.ui.xml
by lvernia＠redhat.com 08 May '14

08 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fixed alignment in ProviderPopupView.ui.xml ...................................................................... webadmin: Fixed alignment in ProviderPopupView.ui.xml Change-Id: I3ce9a577c9524d6790a9bdcc458b4f127d043311 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml 1 file changed, 19 insertions(+), 19 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ce9a577c9524d6790a9bdcc458b4f127d043311 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Set default DC for import by tree selection
by lvernia＠redhat.com 08 May '14

08 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Set default DC for import by tree selection ...................................................................... webadmin: Set default DC for import by tree selection Instead of always choosing the first DC in the list as the default for an import operation, consider the item selected in the system tree and see if it implies a specific context for the import operation. Change-Id: Ib0fc87737b151c6e39f2545e39516023b0851111 Bug-Url: https://bugzilla.redhat.com/1048726 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/25732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0fc87737b151c6e39f2545e39516023b0851111 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: present the guest cpu count
by oourfali＠redhat.com 08 May '14

08 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: present the guest cpu count ...................................................................... core: present the guest cpu count Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063169 Change-Id: I7aa88e18ba620980ee31a633deaa3345298300e2 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_04_0780_add_guest_cpu_count_to_vm_dynamic.sql M packaging/dbscripts/vms_sp.sql 13 files changed, 89 insertions(+), 24 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7aa88e18ba620980ee31a633deaa3345298300e2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Prefering <usages> over <display>
by oourfali＠redhat.com 08 May '14

08 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Prefering <usages> over <display> ...................................................................... restapi: Prefering <usages> over <display> There are two ways setting an network as display 1. The old (dprecated) way- <display>false</display> 2. Thr new way- <usages> <usage>display</usage> </usages> If both of them are used the display should be set according to the new way. Bug-Url: https://bugzilla.redhat.com/1081005 Change-Id: Ia9794bba6de9803b12a99f146c80d03c82dc4503 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/27511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9794bba6de9803b12a99f146c80d03c82dc4503 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Send defRoute by VDSM-reported capabilities
by oourfali＠redhat.com 08 May '14

08 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Send defRoute by VDSM-reported capabilities ...................................................................... engine: Send defRoute by VDSM-reported capabilities Previously it was sent based on the engine's cluster compatibility version, which in the case of a < 3.4 host in >= 3.4 cluster (non-operational but can still receive Setup Networks command) would cause an exception in VDSM. Change-Id: I7d8b608e9f68a874daf11e2ae73280fe9961c93d Bug-Url: https://bugzilla.redhat.com/1085838 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 2 files changed, 8 insertions(+), 3 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d8b608e9f68a874daf11e2ae73280fe9961c93d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Prefering <usages> over <display>
by alkaplan＠redhat.com 08 May '14

08 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: restapi: Prefering <usages> over <display> ...................................................................... restapi: Prefering <usages> over <display> There are two ways setting an network as display 1. The old (dprecated) way- <display>false</display> 2. Thr new way- <usages> <usage>display</usage> </usages> If both of them are used the display should be set according to the new way. Bug-Url: https://bugzilla.redhat.com/1081005 Change-Id: Ia9794bba6de9803b12a99f146c80d03c82dc4503 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/27501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9794bba6de9803b12a99f146c80d03c82dc4503 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Send defRoute by VDSM-reported capabilities
by lvernia＠redhat.com 08 May '14

08 May '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Send defRoute by VDSM-reported capabilities ...................................................................... engine: Send defRoute by VDSM-reported capabilities Previously it was sent based on the engine's cluster compatibility version, which in the case of a < 3.4 host in >= 3.4 cluster (non-operational but can still receive Setup Networks command) would cause an exception in VDSM. Change-Id: I7d8b608e9f68a874daf11e2ae73280fe9961c93d Bug-Url: https://bugzilla.redhat.com/1085838 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 2 files changed, 8 insertions(+), 3 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d8b608e9f68a874daf11e2ae73280fe9961c93d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: setup: Conditional statrup state for websocket proxy
by sbonazzo＠redhat.com 08 May '14

08 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: Conditional statrup state for websocket proxy ...................................................................... setup: Conditional statrup state for websocket proxy Modified to set the startup state during the cleanup for the service ovirt-websocket-proxy only if it exists. Unconditional code was causing an issue while cleanup as the service details were not found and cleanup was failing with error - "[ ERROR ] Failed to execute stage 'Misc configuration': Command '/sbin/chkconfig' failed to execute" Change-Id: Icbafa3ed20b9ed9ed04a16e99cae7b4ae394db1c Bug-Url: https://bugzilla.redhat.com/1095583 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/misc.py 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Shubhendu Tripathi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Sahina Bose: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbafa3ed20b9ed9ed04a16e99cae7b4ae394db1c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0