May 2014 - Engine-commits - oVirt List Archives

Change in jenkins[master]: Fixing target archs
by dcaroest＠redhat.com 08 May '14

08 May '14

David Caro has submitted this change and it was merged. Change subject: Fixing target archs ...................................................................... Fixing target archs Even if the configuration file and the repos says the arch is i386, the target arch of the packages built should be i686. Change-Id: Ic8d9cbfd104abf309438ef5fa1f7f5e070805db7 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/epel-6-i386.cfg M mock_configs/fedora-19-i386.cfg M mock_configs/fedora-20-i386.cfg 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8d9cbfd104abf309438ef5fa1f7f5e070805db7 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: present the guest cpu count
by rgolan＠redhat.com 08 May '14

08 May '14

Roy Golan has submitted this change and it was merged. Change subject: core: present the guest cpu count ...................................................................... core: present the guest cpu count Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063169 Change-Id: I7aa88e18ba620980ee31a633deaa3345298300e2 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_0390_add_guest_cpu_count_to_vm_dynamic.sql M packaging/dbscripts/vms_sp.sql 13 files changed, 88 insertions(+), 27 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7aa88e18ba620980ee31a633deaa3345298300e2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: br10b report - fixed query
by ydary＠redhat.com 08 May '14

08 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br10b report - fixed query ...................................................................... reports: br10b report - fixed query Fixed the condition on delete_date to include the vms that were deleted after the start_date. Change-Id: I5fd679b87e7376ab2b27a9a53c6ffac52d429656 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_days_week_BR10B_files/single_vm_resources_days_week_BR10B_jrxml.data 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fd679b87e7376ab2b27a9a53c6ffac52d429656 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Disallow RO LUN ISCSI disks
by oourfali＠redhat.com 08 May '14

08 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Disallow RO LUN ISCSI disks ...................................................................... core: Disallow RO LUN ISCSI disks Qemu currently does not support Direct-LUN disks connected using Virt-IO-SCSI. This patch adds a validation to block this in AddDiskCommand CDA. Also added a new VdcBllMessage for this case. Change-Id: Id84346098d42f20c593c2682dc9ff99a3e77d534 Bug-Url: https://bugzilla.redhat.com/1082673 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 46 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/27452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id84346098d42f20c593c2682dc9ff99a3e77d534 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Disallow RO disks to be attached to VM
by oourfali＠redhat.com 08 May '14

08 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Disallow RO disks to be attached to VM ...................................................................... core: Disallow RO disks to be attached to VM RO is not supported when using specific inrtefaces when attached to a VM. These case are already disallowed when creating a disk, yet are still allowed when attaching a floating disk with these interfaces, or when updating a disk. These interface are IDE and iSCSI for a LUN target. This patch adds the relevant validations to AttachDiskToVmCommand and UpdateVmDiakCommands's CDAs. Change-Id: Iac2a8e0fbece57cbb6f375a65cc37e7c2bba11cf Bug-Url: https://bugzilla.redhat.com/1082673 Bug-Url: https://bugzilla.redhat.com/1094288 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 2 files changed, 12 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/27454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac2a8e0fbece57cbb6f375a65cc37e7c2bba11cf Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: database: Reintroduce the variables used in Power Saving policy
by oourfali＠redhat.com 08 May '14

08 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: database: Reintroduce the variables used in Power Saving policy ...................................................................... database: Reintroduce the variables used in Power Saving policy One patch introduced a regression and removed HostsInReserve and EnableAutomaticPowerManagement policy variables from the db. Change-Id: I48040a9c9ec1873872c789cf07c51a5489b3e65c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092623 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0770_reintroduce_powersaving_variables.sql 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48040a9c9ec1873872c789cf07c51a5489b3e65c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Add the ability to consume Quota in internal commands
by oourfali＠redhat.com 08 May '14

08 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add the ability to consume Quota in internal commands ...................................................................... core: Add the ability to consume Quota in internal commands adding a new boolean to CommandBase to indicate whether the command will consume quota when invoked as internal. Added a c'tor to VdcActionType, to allow setting this boolean: HotSetNumberOfCpus(184, ActionGroup.EDIT_VM_PROPERTIES, false, QuotaDependency.VDS_GROUP, true) Change-Id: Id4c8074eef5607107703bcb68df441a577137b04 Bug-Url: https://bugzilla.redhat.com/1083177 Signed-off-by: Kobi Ianko <kobi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 26 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Kobi Ianko: Verified -- To view, visit http://gerrit.ovirt.org/27491 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4c8074eef5607107703bcb68df441a577137b04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Set HotSetNumberOfCpusCommand as Quota consume
by oourfali＠redhat.com 08 May '14

08 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Set HotSetNumberOfCpusCommand as Quota consume ...................................................................... core: Set HotSetNumberOfCpusCommand as Quota consume Set the command as consuming Quota as an internal command. This command is called from the update VM command, and changes the number of CPU on the VM, This changes the CPU consumption. Change-Id: I6d1db7c2f7cbc4ae94e540b26e15dbcf7246bde0 Bug-Url: https://bugzilla.redhat.com/1083177 Signed-off-by: Kobi Ianko <kobi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetNumberOfCpusCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 39 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Kobi Ianko: Verified -- To view, visit http://gerrit.ovirt.org/27492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d1db7c2f7cbc4ae94e540b26e15dbcf7246bde0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: sysprep timezone is set as system timezone
by oourfali＠redhat.com 08 May '14

08 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: sysprep timezone is set as system timezone ...................................................................... core: sysprep timezone is set as system timezone Vm.timezone needs to map for every run (i.e. system BIOS timezone - the one that we sent to qemu command line). Vm.VmInit.timezone needs to map only for Sysprep use (i.e. first run) Change-Id: If48c49b7e36d5382965a77c99fd7fa1f5d884578 Bug-Url: https://bugzilla.redhat.com/1088440 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 5 files changed, 17 insertions(+), 22 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If48c49b7e36d5382965a77c99fd7fa1f5d884578 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: database: Reintroduce the variables used in Power Saving policy
by gchaplik＠redhat.com 08 May '14

08 May '14

Gilad Chaplik has submitted this change and it was merged. Change subject: database: Reintroduce the variables used in Power Saving policy ...................................................................... database: Reintroduce the variables used in Power Saving policy One patch introduced a regression and removed HostsInReserve and EnableAutomaticPowerManagement policy variables from the db. Change-Id: I48040a9c9ec1873872c789cf07c51a5489b3e65c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092623 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_0380_reintroduce_powersaving_variables.sql 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48040a9c9ec1873872c789cf07c51a5489b3e65c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0