June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: process VMs that went down on separate thread
by oourfali＠redhat.com 17 Jun '14

17 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: process VMs that went down on separate thread ...................................................................... core: process VMs that went down on separate thread In order to prevent the processing of VMs that went down from blocking the VURTI thread, we'll do the processing in a separate thread. Change-Id: I903992087c7d5975548746f45451fccbfd38b299 Bug-Url: https://bugzilla.redhat.com/1108675 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 5 files changed, 20 insertions(+), 14 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/28816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I903992087c7d5975548746f45451fccbfd38b299 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: do not handle crashed VM twice
by oourfali＠redhat.com 17 Jun '14

17 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: do not handle crashed VM twice ...................................................................... core: do not handle crashed VM twice We used to save the VMs which moves to Down in a List which means that theoretically we can have duplicated VMs in the List. Because of bz 1099846, we might get into a situation where VM will be in the List twice. Before extracting the handling of the VMs that went down to separate thread, it is important to make sure we have each VM stored in this collection only one, so we won't invoke redundant threads. So the solution is to change the List to be Set, so it will not store duplicated values. Change-Id: I913cf18ad341090f3ed1df5acda93b372af7ab4d Bug-Url: https://bugzilla.redhat.com/1108675 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/28769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I913cf18ad341090f3ed1df5acda93b372af7ab4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: move the logic in VmPoolHandler to separate command
by oourfali＠redhat.com 17 Jun '14

17 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: move the logic in VmPoolHandler to separate command ...................................................................... core: move the logic in VmPoolHandler to separate command The logic of how to handle VM that went down is extracted to separate command, so the invocation of this logic is be in a more standard way. The DownVmsHandler remains, it will later on be used as a listener for notifications from VURTI. Change-Id: Ic8840b8cba0fcec68936f0f24abc9948568cca0d Bug-Url: https://bugzilla.redhat.com/1108675 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 7 files changed, 48 insertions(+), 22 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/28768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8840b8cba0fcec68936f0f24abc9948568cca0d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: sort items of vms and templates tabs under storage
by derez＠redhat.com 17 Jun '14

17 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: sort items of vms and templates tabs under storage ...................................................................... webadmin: sort items of vms and templates tabs under storage Storage main-tab -> VMs/Templates sub-tabs: sort items on syncSearch. Change-Id: If3c63419c3cd715ec28e0b89cfd5ccd6b3c0af67 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageVmListModel.java 2 files changed, 12 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/28849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3c63419c3cd715ec28e0b89cfd5ccd6b3c0af67 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: write answer file also on error
by sbonazzo＠redhat.com 17 Jun '14

17 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: write answer file also on error ...................................................................... packaging: setup: write answer file also on error previously answer file was not written if an error occurred at customization or if user did not accept configuration preview. Also the answer file was not updated with late values asked at closeup stage if an error occurred in that stage. Now the answer file is always written. Change-Id: Icf991ffaa44fbb16c7a97c76b9a4e17397aacaca Bug-Url: https://bugzilla.redhat.com/1107772 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/answerfile.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf991ffaa44fbb16c7a97c76b9a4e17397aacaca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: accept configuration by default
by sbonazzo＠redhat.com 17 Jun '14

17 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: accept configuration by default ...................................................................... packaging: setup: accept configuration by default Previously user was required to answer yes for approving configuration preview. Now user can just hit enter. Change-Id: I960df6c971013aa08726a64bd22425a3dc27fe65 Bug-Url: https://bugzilla.redhat.com/1107772 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/preview.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I960df6c971013aa08726a64bd22425a3dc27fe65 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Execute FenceVdsManually after host kdumping detected
by emesika＠redhat.com 17 Jun '14

17 Jun '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Execute FenceVdsManually after host kdumping detected ...................................................................... core: Execute FenceVdsManually after host kdumping detected Adds execution of FenceVdsManuallyCommand when host kdumping is detected, so selecting the new SPM host is faster then wait for host to fisnish kdumping and reboot. Change-Id: I957b7e98fb8e909a1b1747816e888f03d0d850ca Bug-Url: https://bugzilla.redhat.com/1079821 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java 1 file changed, 32 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I957b7e98fb8e909a1b1747816e888f03d0d850ca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Restart VMs running on host when kdump is detected
by emesika＠redhat.com 17 Jun '14

17 Jun '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Restart VMs running on host when kdump is detected ...................................................................... core: Restart VMs running on host when kdump is detected Restart VMs running on host when kdump is detected, because fencing is not executed for such host (and restarting VMs is a part if host fencing). Change-Id: I026267d02c4f54888a7a8e7f38256f5d587f1c8f Bug-Url: https://bugzilla.redhat.com/1079821 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I026267d02c4f54888a7a8e7f38256f5d587f1c8f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Introduce RestartVdsVmsOperation
by emesika＠redhat.com 17 Jun '14

17 Jun '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Introduce RestartVdsVmsOperation ...................................................................... core: Introduce RestartVdsVmsOperation Moves restart of VMs running in Vds that is fenced into new class RestartVdsVmsOperation. The same operation will be used when kdump is detected for host (following patch). Change-Id: I7ec38f74c1c7e99f080f2b1a4a1d72938aa4aade Bug-Url: https://bugzilla.redhat.com/1079821 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsVmsOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java 4 files changed, 143 insertions(+), 62 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ec38f74c1c7e99f080f2b1a4a1d72938aa4aade Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: update ovirt-host-deploy dependency
by sbonazzo＠redhat.com 17 Jun '14

17 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: update ovirt-host-deploy dependency ...................................................................... packaging: spec: update ovirt-host-deploy dependency Change-Id: I9e256b80ed92832ed289c7f7568627ce7519b87c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e256b80ed92832ed289c7f7568627ce7519b87c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0