June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: process VMs that went down on separate thread
by ahadas＠redhat.com 17 Jun '14

17 Jun '14

Arik Hadas has submitted this change and it was merged. Change subject: core: process VMs that went down on separate thread ...................................................................... core: process VMs that went down on separate thread In order to prevent the processing of VMs that went down from blocking the VURTI thread, we'll do the processing in a separate thread. Change-Id: I903992087c7d5975548746f45451fccbfd38b299 Bug-Url: https://bugzilla.redhat.com/1098791 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 5 files changed, 18 insertions(+), 12 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I903992087c7d5975548746f45451fccbfd38b299 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Provide informative message if cannot configure network
by masayag＠redhat.com 17 Jun '14

17 Jun '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Provide informative message if cannot configure network ...................................................................... engine: Provide informative message if cannot configure network In case the network cannot be configured on the host by host deploy, a specific message can be provided for each reason. Change-Id: Ieba631be43f5b74ac62d5ab0e5325e70d85376c6 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java 1 file changed, 15 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/28260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieba631be43f5b74ac62d5ab0e5325e70d85376c6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use VmDevice.id to identify the vm device instance
by masayag＠redhat.com 17 Jun '14

17 Jun '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use VmDevice.id to identify the vm device instance ...................................................................... engine: Use VmDevice.id to identify the vm device instance The VmDevice.Id is sufficient to identify the existence of the device within a map, rather using the entire device which could be modified by other flows in the system (i.e. update boot sequence). Change-Id: Id0a976e31e97c1f250e29db9166e60ccba4b4a94 Bug-Url: https://bugzilla.redhat.com/1105842 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVmMixIn.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 5 files changed, 9 insertions(+), 8 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0a976e31e97c1f250e29db9166e60ccba4b4a94 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use updated qpid rpc_backend implementation
by masayag＠redhat.com 17 Jun '14

17 Jun '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use updated qpid rpc_backend implementation ...................................................................... engine: Use updated qpid rpc_backend implementation The patch fixes the deprecated rpc_backend fqdn for qpid. Change-Id: Ibb62c2a83a2b47e97153e754376657b3021010b6 Bug-Url: https://bugzilla.redhat.com/1101206 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/28110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb62c2a83a2b47e97153e754376657b3021010b6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: First yaml job, the one checking the yamls
by dcaroest＠redhat.com 17 Jun '14

17 Jun '14

David Caro has submitted this change and it was merged. Change subject: First yaml job, the one checking the yamls ...................................................................... First yaml job, the one checking the yamls This job checks if the new patch compiles and shows the differences (if any) with the yamls before the patch Change-Id: I0a48a2757bc241e2b8155c74de54bcc6335ee159 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M .gitignore A jobs/confs/shell-scripts/check_yaml.sh A jobs/confs/shell-scripts/htmldiff.sh A jobs/confs/yaml/defaults/defaults.yaml A jobs/confs/yaml/jobs/jenkins.yaml A jobs/confs/yaml/parmeters/gerrit.yaml A jobs/confs/yaml/scms/jenkins.yaml 7 files changed, 228 insertions(+), 0 deletions(-) Approvals: Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a48a2757bc241e2b8155c74de54bcc6335ee159 Gerrit-PatchSet: 8 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: fix bug in br44- redundant bracket
by ydary＠redhat.com 16 Jun '14

16 Jun '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fix bug in br44- redundant bracket ...................................................................... reports: fix bug in br44- redundant bracket Change-Id: I92d599741db60964116e478766080184ac7e0a67 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Inventory/ccp_vm_inventory_br44_files/ccp_vm_inventory_br44_jrxml.data 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92d599741db60964116e478766080184ac7e0a67 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: ui: EntityModelTextAreaEditor - fix selection-text with Enter
by shavivi＠redhat.com 16 Jun '14

16 Jun '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: EntityModelTextAreaEditor - fix selection-text with Enter ...................................................................... ui: EntityModelTextAreaEditor - fix selection-text with Enter Wrong behaviour for the control if user will select text and will press enter. This issue is cause because the dialog is capturing the enter key to submit the dialog selection. https://bugzilla.redhat.com/1109330 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> Change-Id: If7647e1e52f29be7f0632a330013da61cc1f503d --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelTextAreaEditor.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/28814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7647e1e52f29be7f0632a330013da61cc1f503d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change the value of ProcessDownVmCommand
by ahadas＠redhat.com 16 Jun '14

16 Jun '14

Arik Hadas has submitted this change and it was merged. Change subject: core: change the value of ProcessDownVmCommand ...................................................................... core: change the value of ProcessDownVmCommand The value of ProcessDownVmCommand collided with the value of ImportVmTemplateFromConfiguration, thus it is changed. Change-Id: Ic2a1f3842becb1711987b964c8da0fac73ce2e26 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2a1f3842becb1711987b964c8da0fac73ce2e26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Fix broken test
by juan.hernandez＠redhat.com 16 Jun '14

16 Jun '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix broken test ...................................................................... restapi: Fix broken test The patch avoids NPE when trying to access the OsRepository. Change-Id: Ifd084c11ac6d1947e94490125431460916d5a294 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResourceTest.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/28811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd084c11ac6d1947e94490125431460916d5a294 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: capitalize email title
by oourfali＠redhat.com 16 Jun '14

16 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: capitalize email title ...................................................................... webadmin: capitalize email title Change-Id: If0768805870f44bc73674b8867b84f49c05ebb7c Bug-Url: https://bugzilla.redhat.com/1106966 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0768805870f44bc73674b8867b84f49c05ebb7c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0