July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VmLogonCommand - missing constructor
by derez＠redhat.com 07 Jul '14

07 Jul '14

Daniel Erez has submitted this change and it was merged. Change subject: core: VmLogonCommand - missing constructor ...................................................................... core: VmLogonCommand - missing constructor VmLogonCommand is invoked only from client (UserPortal/REST), hence, a missing constructor causes a RuntimeException [1] when connecting to console. Added a new ctr without the CommandContext parameter. Note: InternalCommandAttribute annotation should probably be removed as the action is performed merely from the client. [1] "could not find matching constructor for Command class class org.ovirt.engine.core.bll.VmLogonCommand" Change-Id: If0c750656a01e51614553427551896cfd6b54dd5 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Omer Frenkel: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0c750656a01e51614553427551896cfd6b54dd5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Modify constructor to be compatible with caller method
by yzaslavs＠redhat.com 07 Jul '14

07 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Modify constructor to be compatible with caller method ...................................................................... core: Modify constructor to be compatible with caller method ConnectDomainToStorageCommand is being called without context although its constructor is only supported with context parameter, so we will always get runtime exception when the command is being called. The proposed fix is to add a constructor which also supports to get only paramteres Change-Id: Ic120c4b33b40a122895c2088b8365f26c05eb517 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectDomainToStorageCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic120c4b33b40a122895c2088b8365f26c05eb517 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: filter engine db password
by oschreib＠redhat.com 06 Jul '14

06 Jul '14

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: filter engine db password ...................................................................... packaging: setup: filter engine db password filtering was dropped at 06af45a4338990a3b496ffbcc7ee10be4ffbfffa . Change-Id: Ie354ac811882b32ccd4b38851a43b0daae21a122 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/connection.py 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: oVirt Jenkins CI Server: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/29610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie354ac811882b32ccd4b38851a43b0daae21a122 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: filter engine db password
by ydary＠redhat.com 06 Jul '14

06 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: filter engine db password ...................................................................... packaging: setup: filter engine db password Change-Id: I318f27dc02b4bf6d239dbabefc55c982a1208dcb Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I318f27dc02b4bf6d239dbabefc55c982a1208dcb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: filter engine db password
by ydary＠redhat.com 06 Jul '14

06 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: filter engine db password ...................................................................... packaging: setup: filter engine db password Change-Id: I83dccecf7ec482e0977accf1ac69af88c7e44192 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83dccecf7ec482e0977accf1ac69af88c7e44192 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Setup networks- limiting 'network label' text width
by alkaplan＠redhat.com 06 Jul '14

06 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Setup networks- limiting 'network label' text width ...................................................................... webadmin: Setup networks- limiting 'network label' text width LabelWithTooltip is used to limit the width of the label name. In case the name width is bigger than the limited width (in pixels), the name is trimmed and '...' are add to it. The tooltip displays the whole name. Change-Id: I7315c42d39969de8eaa0c922b1f25050195ec352 Bug-Url: https://bugzilla.redhat.com/1084748 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkLabelPanel.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7315c42d39969de8eaa0c922b1f25050195ec352 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Limiting vnic name label width on vm dialog
by alkaplan＠redhat.com 06 Jul '14

06 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Limiting vnic name label width on vm dialog ...................................................................... webadmin: Limiting vnic name label width on vm dialog LabelWithTooltip is used to limit the width of the vnic name label. In case the name width is bigger than the limited width (in pixels), the name is trimmed and '...' are add to it. The tooltip displays the whole name. Change-Id: I32d30aa8d1824b127030a533fcde57aaa75983b3 Bug-Url: https://bugzilla.redhat.com/1029973 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml 2 files changed, 16 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32d30aa8d1824b127030a533fcde57aaa75983b3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: LabelWithTextOverflow trims long text and add "..."
by alkaplan＠redhat.com 06 Jul '14

06 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: LabelWithTextOverflow trims long text and add "..." ...................................................................... webadmin: LabelWithTextOverflow trims long text and add "..." In case the lable's text is cropped, the text is visually trimmed. To let the user know that the text was trimmed '...' are appended to the string. The tooltip contains the full text string. Bug-Url: https://bugzilla.redhat.com/1096662 Change-Id: I3a0c6292b874d0994042366940123b42b38b7a8d Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementUtils.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithCustomToolTip.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextOverflow.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCellWithTooltip.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfaceLabelWithToolTip.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/LabelWithToolTip.java 9 files changed, 202 insertions(+), 119 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a0c6292b874d0994042366940123b42b38b7a8d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: integrate make into maven
by rgolan＠redhat.com 06 Jul '14

06 Jul '14

Roy Golan has submitted this change and it was merged. Change subject: core: integrate make into maven ...................................................................... core: integrate make into maven Use maven to deploy the artifact to prefix using make: #exclusivly deploy from ovirt-engine root mvn install -pl org.ovirt.engine:make -Pmake #build the project and deploy to $OVIRT_ENGINE_PREFIX mvn clean install -Pmake #For explicit prefix use: mvn install -Pmake -Dprefix=/path/to/prefix The prefix defaults to env variable OVIRT_ENGINE_PREFIX Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- A mavenmake/pom.xml M pom.xml 2 files changed, 54 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Roy Golan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use ValidationResult enhancements in ProviderValidator
by masayag＠redhat.com 06 Jul '14

06 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use ValidationResult enhancements in ProviderValidator ...................................................................... engine: Use ValidationResult enhancements in ProviderValidator The ValidationResult.failWith().when() provides a nice api for validation. The patch uses it in ProviderValidator. Change-Id: Ibcff64a7f77a95a6ae788c8871c7d673829a0223 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/29608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcff64a7f77a95a6ae788c8871c7d673829a0223 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0