August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: attach disk - allow read-only for DirectLUN
by tnisan＠redhat.com 11 Aug '14

11 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: attach disk - allow read-only for DirectLUN ...................................................................... webadmin: attach disk - allow read-only for DirectLUN Attach disk dialog: allow read-only selection for DirecLUN disks not using SCSI pass-through. Change-Id: Id2ff8730b7da1d20e71339871ee462c23d263c5b Bug-Url: https://bugzilla.redhat.com/1118847 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2ff8730b7da1d20e71339871ee462c23d263c5b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Fix NPE when live migrating a disk
by tnisan＠redhat.com 11 Aug '14

11 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix NPE when live migrating a disk ...................................................................... restapi: Fix NPE when live migrating a disk Empty Guid was passed as source domain id to the MoveDisksCommand and onward. This is fixed and the actual source domain is extracted from the disk entity when moving/migrating/copying a disk. The source domain id is then used in the parameters classes. This was mocked out in the relevant tests. Change-Id: I570a4c81605b63a860c012e9071e46c34c793635 Bug-Url: https://bugzilla.redhat.com/1124321 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskResourceTest.java 4 files changed, 31 insertions(+), 6 deletions(-) Approvals: Ori Liel: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/31339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I570a4c81605b63a860c012e9071e46c34c793635 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: attach disk - allow read-only for passthrough
by derez＠redhat.com 11 Aug '14

11 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: attach disk - allow read-only for passthrough ...................................................................... webadmin: attach disk - allow read-only for passthrough Attach disk dialog: allow read-only selection for DirecLUN disks using SCSI pass-through. Change-Id: Id2ff8730b7da1d20e71339871ee462c23d263c5b Bug-Url: https://bugzilla.redhat.com/1118847 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/31333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2ff8730b7da1d20e71339871ee462c23d263c5b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Calculate storage format when adding an SD
by amureini＠redhat.com 11 Aug '14

11 Aug '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Calculate storage format when adding an SD ...................................................................... core: Calculate storage format when adding an SD Removed the default V1 format from StorageDomainStatic's constructor so it can be calculated when adding a domain without specifying the format via REST. The logic goes as follows: - If the format is specified (as is the case in all the edit scenarios as well as when adding a new domain via the GUI), leave it alone - If it's a data domain, set the format to the format required by the pool's version. Note: Creating a domain by a host not attached to a pool is currently NOT supported. This patch does not change that behavior, nor does it handle this situation. - If it's not a data domain, use V1 (i.e., preserve the old behavior). Change-Id: If469bb655e9a65e2d0afcee164655fa0bdfa5d99 Bug-Url: https://bugzilla.redhat.com/1120712 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainStaticDAOTest.java 5 files changed, 66 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If469bb655e9a65e2d0afcee164655fa0bdfa5d99 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: In Add Users and Groups dialog the namespace drop...
by oourfali＠redhat.com 11 Aug '14

11 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: In Add Users and Groups dialog the namespace drop down is not aligned ...................................................................... webadmin: In Add Users and Groups dialog the namespace drop down is not aligned The namespace selection drop down in add users and groups dialog is not aligned Change-Id: I9bd2f5465a047dc4616e4fa0e7f9dea2f64f9bcc Bug-Url: https://bugzilla.redhat.com/1128234 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 27bc7af603b0a010dbe5816dd36db0e60d2cb050) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bd2f5465a047dc4616e4fa0e7f9dea2f64f9bcc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: In Add Users and Groups dialog the namespace drop...
by oourfali＠redhat.com 11 Aug '14

11 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: In Add Users and Groups dialog the namespace drop down is not aligned ...................................................................... webadmin: In Add Users and Groups dialog the namespace drop down is not aligned The namespace selection drop down in add users and groups dialog is not aligned Change-Id: I9bd2f5465a047dc4616e4fa0e7f9dea2f64f9bcc Bug-Url: https://bugzilla.redhat.com/1128234 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bd2f5465a047dc4616e4fa0e7f9dea2f64f9bcc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Rename TaskManagerUtil to CommandCoordinatorUtil
by oourfali＠redhat.com 11 Aug '14

11 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Rename TaskManagerUtil to CommandCoordinatorUtil ...................................................................... engine : Rename TaskManagerUtil to CommandCoordinatorUtil Rename TaskManagerUtil to CommandCoordinatorUtil Change-Id: Idf796edd6c0812dac03bbf1e71b637e9d2b452e5 Bug-Url: https://bugzilla.redhat.com/1127774 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandEntityCleanupManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTasksStatusesByTasksIDsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java 20 files changed, 68 insertions(+), 68 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf796edd6c0812dac03bbf1e71b637e9d2b452e5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Fix NPE when live migrating a disk
by tnisan＠redhat.com 11 Aug '14

11 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix NPE when live migrating a disk ...................................................................... restapi: Fix NPE when live migrating a disk Empty Guid was passed as source domain id to the MoveDisksCommand and onward. This is fixed and the actual source domain is extracted from the disk entity when moving/migrating/copying a disk. The source domain id is then used in the parameters classes. This was mocked out in the relevant tests. Change-Id: I570a4c81605b63a860c012e9071e46c34c793635 Bug-Url: https://bugzilla.redhat.com/1103499 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskResourceTest.java 4 files changed, 31 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/30975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I570a4c81605b63a860c012e9071e46c34c793635 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: Add HostTime.py in Makefile
by alitke＠redhat.com 11 Aug '14

11 Aug '14

Adam Litke has submitted this change and it was merged. Change subject: Add HostTime.py in Makefile ...................................................................... Add HostTime.py in Makefile Change-Id: Ia4a3acc382969f619ac94fc36a0f84d5ba2fcd8e Signed-off-by: Meghal Gosalia <meghal(a)yahoo-inc.com> Reviewed-on: http://gerrit.ovirt.org/31110 Reviewed-by: Adam Litke <alitke(a)redhat.com> Tested-by: Meghal .B. Gosalia <meghalgosalia(a)gmail.com> --- M mom/Collectors/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Adam Litke: Looks good to me, approved Meghal .B. Gosalia: Verified -- To view, visit http://gerrit.ovirt.org/31110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4a3acc382969f619ac94fc36a0f84d5ba2fcd8e Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Meghal .B. Gosalia <meghalgosalia(a)gmail.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Meghal .B. Gosalia <meghalgosalia(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: fixed the collect method signature
by alitke＠redhat.com 11 Aug '14

11 Aug '14

Adam Litke has submitted this change and it was merged. Change subject: fixed the collect method signature ...................................................................... fixed the collect method signature Change-Id: I03d592bffe282350fede03132bebb83ff03665aa Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/31223 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Collectors/Collector.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adam Litke: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/31223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03d592bffe282350fede03132bebb83ff03665aa Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0