August 2014 - Engine-commits - oVirt List Archives

Change in jenkins[master]: Added ioprocess jobs
by eedri＠redhat.com 11 Aug '14

11 Aug '14

Eyal Edri has submitted this change and it was merged. Change subject: Added ioprocess jobs ...................................................................... Added ioprocess jobs Added some extra verbose to the scripts to know to which one belongs what is being executed from the jenkins log Change-Id: I3e31f08290eede245220ebb52c06a85b0b84e51c Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/build_local_srcrpm.sh M jobs/confs/shell-scripts/build_local_srcrpm_releng.sh M jobs/confs/shell-scripts/build_mock_srcrpm.sh M jobs/confs/shell-scripts/build_mock_srcrpm_releng.sh M jobs/confs/shell-scripts/global_setup.sh M jobs/confs/shell-scripts/jenkins_check_yaml.sh M jobs/confs/shell-scripts/jenkins_deploy_yamls.sh M jobs/confs/shell-scripts/mock_build_onlyrpm.sh M jobs/confs/shell-scripts/mock_cleanup.sh M jobs/confs/shell-scripts/mock_install.sh M jobs/confs/shell-scripts/mock_setup.sh M jobs/confs/yaml/builders/rpm_mock.yaml A jobs/confs/yaml/jobs/ioprocess/ioprocess_create-rpms.yaml A jobs/confs/yaml/scms/ioprocess.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml 15 files changed, 81 insertions(+), 16 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, approved David Caro: Verified -- To view, visit http://gerrit.ovirt.org/29531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e31f08290eede245220ebb52c06a85b0b84e51c Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : placeholders of child commands aren't cleared on ex...
by oourfali＠redhat.com 11 Aug '14

11 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : placeholders of child commands aren't cleared on exception ...................................................................... engine : placeholders of child commands aren't cleared on exception When one of the child commands fails or throws a VdcBllException if not all child commands are executed clearAsyncTasksWithOutVdsmId is not being invoked. On VdcBllException we need to invoke method clearAsyncTasksWithOutVdsmId on all child commands to clear the place holder of commands that have not been executed. Change-Id: I457a1f9357fda9232a8757984d6936d9c977aa62 Bug-Url: https://bugzilla.redhat.com/1126204 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I457a1f9357fda9232a8757984d6936d9c977aa62 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: clear disk device address when it's being unplugged fr...
by oourfali＠redhat.com 11 Aug '14

11 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: clear disk device address when it's being unplugged from a vm ...................................................................... core: clear disk device address when it's being unplugged from a vm Change-Id: If82c8983089916ab1c58dd0330442c3aff8d6d02 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1079697 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java A packaging/dbscripts/upgrade/03_05_0860_clear_address_for_unplugged_disks.sql M packaging/dbscripts/vm_device_sp.sql 7 files changed, 14 insertions(+), 54 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/31280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If82c8983089916ab1c58dd0330442c3aff8d6d02 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: task monitoring for import glance image
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: task monitoring for import glance image ...................................................................... core: task monitoring for import glance image In order for import glance image task to be monitored correctly, internal action invocation should get enclosingCommand's original context (see tasks tab screenshot [1]). [1] http://i.imgur.com/aFIA1p0.jpg Change-Id: I6780e8a18934bcd22e099dd5ea9d7e726ed60193 Bug-Url: https://bugzilla.redhat.com/1119325 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6780e8a18934bcd22e099dd5ea9d7e726ed60193 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: sync LUNs on SD status changes to active
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: sync LUNs on SD status changes to active ...................................................................... core: sync LUNs on SD status changes to active Ensure invocation of SyncLunsInfoForBlockStorageDomain command when a storage domain status changes to Active. * VdsEventListener: added syncLunsInfoForBlockStorageDomain method * IrsProxyData: perform synchronization when SD status is active: - Upon getStoragePoolInfo callback and status change detection. - Upon getVdsStats callback and active domain detection. Change-Id: I31ccdaaa8f7f982cb38dd8f1c4488d76cba21463 Bug-Url: https://bugzilla.redhat.com/1115845 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 5 files changed, 49 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31ccdaaa8f7f982cb38dd8f1c4488d76cba21463 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: SyncLunsInfo - avoidable executions/db deadlock
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: SyncLunsInfo - avoidable executions/db deadlock ...................................................................... core: SyncLunsInfo - avoidable executions/db deadlock Currently SyncLunsInfoForBlockStorageDomainCommand is being executed when connecting to a domain storage server. This command is resposible to check if any of the luns of the domain were changed and in case it did, update the DB accordingly. When a storage domain is being activated all of it's hosts are being connected simoltenously to the domain, which leads that SyncLunsInfoForBlockStorageDomainCommand is executed multiple times (once for each host) which is unneeded as it's exactly the same as having response from one host (even if the responses of the hosts are different, we can't decide which response is correct). When being executed simoltenously, possibly concurrent updates from the different threads can be made - as the order of the updates isn't garuanteed, there's a chance for a deadlock. This patch solves it by executes the operation for only one hosts at a time, only in case of failure (which should be rare) the engine will attempt to sync the luns through a different host. Change-Id: I725964aa51ac38bf16d83cc498c5298720031632 Bug-Url: https://bugzilla.redhat.com/1115845 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java 5 files changed, 40 insertions(+), 15 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I725964aa51ac38bf16d83cc498c5298720031632 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: drop ConnectSingleAsyncOperation
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: drop ConnectSingleAsyncOperation ...................................................................... core: drop ConnectSingleAsyncOperation This patch drops the ConnectSingleAsyncOperation and it's factory with the simple use of callables. The ConnectSingleAsyncOperation is more complicated, harder to maintain and limited than the simple use of callables (for example, results can't be returned from it at the moment). There's currently no need for that infrastructure, we can execute the needed operations from a helper or a helper method. Change-Id: I825d80da10ef3d22de7cd68a68d854374e6c136c Bug-Url: https://bugzilla.redhat.com/1115845 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperation.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 4 files changed, 28 insertions(+), 45 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I825d80da10ef3d22de7cd68a68d854374e6c136c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: renaming connectAllHostsToPool
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: renaming connectAllHostsToPool ...................................................................... core: renaming connectAllHostsToPool connectAllHostsToPool actually connects the hosts to the related domain storage server, therefore in this patch its name was changed to connectHostsInUpToDomainStorageServer. Change-Id: I15b3cfc6f4a08350b16f252df2587bd2c7737ebe Bug-Url: https://bugzilla.redhat.com/1115845 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectDomainToStorageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 6 files changed, 6 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15b3cfc6f4a08350b16f252df2587bd2c7737ebe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: increment the vm generation when disk is being unplugged
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: increment the vm generation when disk is being unplugged ...................................................................... core: increment the vm generation when disk is being unplugged When a disk is being detached from a vm the vm generation should be incremented otherwise the vm's ovf won't be updated. Change-Id: I91bb0b562907e8d5be4daa8bed97acbf148fae34 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057108 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/31279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91bb0b562907e8d5be4daa8bed97acbf148fae34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Set read only in the CDA instead the constructor
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Set read only in the CDA instead the constructor ...................................................................... core: Set read only in the CDA instead the constructor Setting read only property in the disk at the CDA phase in the constructor to avoid NPE when there is no disk in the DB. Change-Id: Ib70637b4fc29a95bb73aa57a6f3f0c74d4d16ca1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128430 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified Vered Volansky: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib70637b4fc29a95bb73aa57a6f3f0c74d4d16ca1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0