August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Coverity defect CID 1230097 (FB.BC_UNCONFIRMED_CAST)
by lvernia＠redhat.com 10 Aug '14

10 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Coverity defect CID 1230097 (FB.BC_UNCONFIRMED_CAST) ...................................................................... webadmin: Coverity defect CID 1230097 (FB.BC_UNCONFIRMED_CAST) Swapped unsafe cast for properly-parameterized event. Change-Id: I2b42060e7b906b1172d1f823d63c6fbcf1703fdd Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b42060e7b906b1172d1f823d63c6fbcf1703fdd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Coverity defect CID 1230278 (FB.BC_UNCONFIRMED_CAST)
by lvernia＠redhat.com 10 Aug '14

10 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Coverity defect CID 1230278 (FB.BC_UNCONFIRMED_CAST) ...................................................................... webadmin: Coverity defect CID 1230278 (FB.BC_UNCONFIRMED_CAST) Swapped unsafe cast for a properly-parameterized event listener. Change-Id: Ied30d82a0ae72acecf504d3307ae1a9f7f35c220 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/MacPoolModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied30d82a0ae72acecf504d3307ae1a9f7f35c220 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: jsonrpc: Protocol decision based on cluser compatibility ver...
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc: Protocol decision based on cluser compatibility version ...................................................................... jsonrpc: Protocol decision based on cluser compatibility version Engine decides which protocol to use depending on cluster compatibility version when there was no manual protocol override (UI or REST). When cluser compatibility verions is set to 3.5 or higher jsonrpc over stomp is used and for older versions xmlrpc is used. Next step is to disable user override option when we confirm that jsonrpc is stable enough. Bug-Url: https://bugzilla.redhat.com/1081049 Change-Id: I63e857be667095f62de7ed5e6a81b25a41e917f4 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStatisticsDAOTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 10 files changed, 63 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63e857be667095f62de7ed5e6a81b25a41e917f4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Parameterize PropertyChangedEvent
by lvernia＠redhat.com 10 Aug '14

10 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Parameterize PropertyChangedEvent ...................................................................... webadmin: Parameterize PropertyChangedEvent Rendered the PropertyChangedEvent of Model generic, and parameterized it with PropertyChangedEventArgs. Change-Id: I6d5e2363ad44c9432f49dc50f5715a836c327189 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d5e2363ad44c9432f49dc50f5715a836c327189 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Parameterize Event and IEventListener
by lvernia＠redhat.com 10 Aug '14

10 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Parameterize Event and IEventListener ...................................................................... webadmin: Parameterize Event and IEventListener This to further promote type-safety and not have to unsafely-cast specific event arguments. Also took the chance to parameterize an event in ReportsListModel (it wouldn't compile off the bat, and I preferred to parameterize properly than add a cast). Change-Id: I1ad96ebbc2a4d2baff514d53dba8a222a08d1306 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Event.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IEventListener.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java 4 files changed, 24 insertions(+), 23 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ad96ebbc2a4d2baff514d53dba8a222a08d1306 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Removed PropertyChangeNotifier class
by lvernia＠redhat.com 10 Aug '14

10 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Removed PropertyChangeNotifier class ...................................................................... webadmin: Removed PropertyChangeNotifier class Looked like a remnant from the C# days, an empty class that did nothing. Change-Id: I88fdef303c3fcea7b22c68df0f623d56a3186774 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/PropertyChangeNotifier.java 2 files changed, 1 insertion(+), 14 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88fdef303c3fcea7b22c68df0f623d56a3186774 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Cleanup in Event class
by lvernia＠redhat.com 10 Aug '14

10 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Cleanup in Event class ...................................................................... webadmin: Cleanup in Event class Removed fully-qualified Java class names and parameterized generic Class references. Change-Id: I5195ccea738889e09447d28e408f58df6ae04d4a Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Event.java 1 file changed, 16 insertions(+), 11 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5195ccea738889e09447d28e408f58df6ae04d4a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix feedback link popup scrollbars
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: fix feedback link popup scrollbars ...................................................................... webadmin: fix feedback link popup scrollbars - Add scrollbars to feedback link popup call, so it doesn't open in window that cannot be manipulated. Change-Id: Ib7d6166298409485e1c7eb3bc12ecf79397b5e69 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1107799 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractHeaderPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/WebUtils.java 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7d6166298409485e1c7eb3bc12ecf79397b5e69 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: increase branding interface number
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: userportal,webadmin: increase branding interface number ...................................................................... userportal,webadmin: increase branding interface number - Incremented the branding interface version due to new use of patternfly being incompatible with old version. Change-Id: Ic951d79db8dfcf24a5e3af6ebf11056b87c436da Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126556 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingManager.java M backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingThemeTest.java M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/01-test.brand/branding.properties M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/02-test2.brand/branding.properties M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/03-test3.brand/branding.properties M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/04-test4.brand/branding.properties M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/05-test5.brand/branding.properties M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/06-test6.brand/branding.properties M packaging/branding/ovirt.brand/branding.properties 9 files changed, 12 insertions(+), 12 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic951d79db8dfcf24a5e3af6ebf11056b87c436da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: IE9 header value
by awels＠redhat.com 08 Aug '14

08 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: IE9 header value ...................................................................... userportal,webadmin: IE9 header value - Fixed issue where IE9 was reporting missing headers as blank instead of null. This would cause initialization routined to be executed, and that would cause another request which would cause the header to be missing again and one would end up in an endless loop of requests. The patch checks for both null and blank so the loop never happens. Change-Id: I4144a585a1dec1e736d30f7b7b698687543f7936 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114863 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/HttpUtils.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java 3 files changed, 25 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4144a585a1dec1e736d30f7b7b698687543f7936 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0