August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Live Merge command hangs
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Live Merge command hangs ...................................................................... core: Live Merge command hangs Commit b7c8e1852180a75ef3a007bfe83527030cddcfc1, a backport to 3.5 from master, is missing some code that allows the live merge command to converge. Change-Id: I1bacb567500c941cb5c8c983b166e2be837e74ac Bug-Url: https://bugzilla.redhat.com/1127464 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Greg Padgett: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bacb567500c941cb5c8c983b166e2be837e74ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: db, core, webadmin: Add is_live_merge_supported flag
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: db, core, webadmin: Add is_live_merge_supported flag ...................................................................... db, core, webadmin: Add is_live_merge_supported flag Some hosts may not have updated software capable of live merging snapshots, which vdsm will report in its capabilities using the 'liveMerge' flag. Capture this flag, and use it to limit live merge operations on hosts not supporting the feature. Change-Id: I932a74f4010b8b256f8c0cd27a2279b9d83efbb9 Bug-Url: https://bugzilla.redhat.com/1124099 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_0840_add_live_merge_supported.sql M packaging/dbscripts/vds_sp.sql 23 files changed, 124 insertions(+), 22 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I932a74f4010b8b256f8c0cd27a2279b9d83efbb9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix edit of sound card for running vm
by ofrenkel＠redhat.com 07 Aug '14

07 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix edit of sound card for running vm ...................................................................... core: fix edit of sound card for running vm Currently, when updating the sound card setting for running vm, the query that checks if sound card exists is wrong, because sound card can have multiple types of devices (ac97,ich6) Added a code that use the "UNKNOWN" device type, to mark the mechanism to use only the general device type (sound) without the specific type. Change-Id: If2ff54c3d0929ddf04f39bb42e61e185005d9655 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java 3 files changed, 16 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/31035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2ff54c3d0929ddf04f39bb42e61e185005d9655 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: add 30 px the the height of event notifier dialog.
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: add 30 px the the height of event notifier dialog. ...................................................................... webadmin: add 30 px the the height of event notifier dialog. Added height is needed so that the dialog warning will not overflow. ("Note: To receive email notifications, ensure that the mail server is configured and the ovirt-event-notifier service is running.") Change-Id: Ie249bc96f467ee765e579a134763d61e1aa4b29a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122017 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> (cherry picked from commit 46c45b82f0ec963858f9936bfa334a2ed2530114) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie249bc96f467ee765e579a134763d61e1aa4b29a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: css: widen contentWidget class.
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: css: widen contentWidget class. ...................................................................... webadmin: css: widen contentWidget class. Prevent overflows in widgets with longer text. e.g FR in addHost-> PowerManagement dialog. Change-Id: Ie39b55bcdbf110113d9b8e607afafef96bb0783e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1123324 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> (cherry picked from commit e69034f8117aca6066fb5ec061bb94ea3761b3b8) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie39b55bcdbf110113d9b8e607afafef96bb0783e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Host life cycle broken for jsonrpc
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Host life cycle broken for jsonrpc ...................................................................... core: Host life cycle broken for jsonrpc Networking issue was translated to VDSErrorException whereas it should be translated to VDSNetworkException Bug-Url: https://bugzilla.redhat.com/1127685 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Change-Id: I9f6921510c9f42f55c5cc9ec8d8a6daff215c52d (cherry picked from commit 6c261dc6188f8d345567393c8d475488abf78e3f) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f6921510c9f42f55c5cc9ec8d8a6daff215c52d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: css: make profile selection in "add users and grou...
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: css: make profile selection in "add users and groups" dialog wider. ...................................................................... webadmin: css: make profile selection in "add users and groups" dialog wider. Widening the parent div prevents misalignment in locals where The 'Search:' label is longer than english (e.g fr). Change-Id: Id4b46a36bd676605067706b718ad8893f470ffab Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1123780 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> (cherry picked from commit 8adf3b42ff70d3b1a162bf6fd1dd5559467a2b45) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4b46a36bd676605067706b718ad8893f470ffab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Host life cycle broken for jsonrpc
by oourfali＠redhat.com 07 Aug '14

07 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Host life cycle broken for jsonrpc ...................................................................... core: Host life cycle broken for jsonrpc Networking issue was translated to VDSErrorException whereas it should be translated to VDSNetworkException Bug-Url: https://bugzilla.redhat.com/1127685 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Change-Id: I9f6921510c9f42f55c5cc9ec8d8a6daff215c52d --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f6921510c9f42f55c5cc9ec8d8a6daff215c52d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Enhanced permissions logging
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Enhanced permissions logging ...................................................................... core: Enhanced permissions logging During permission check when logging level is set to DEBUG there is more information about which user is being checked and on which objects. When permission is not found it is logged to INFO level. Bug-Url: https://bugzilla.redhat.com/1121617 Change-Id: I4ba8fa00b8d28679b9896fe707623af89ac3c01f Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java 2 files changed, 53 insertions(+), 14 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ba8fa00b8d28679b9896fe707623af89ac3c01f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: making sure not throw NPE when opening SPICE console
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: making sure not throw NPE when opening SPICE console ...................................................................... core: making sure not throw NPE when opening SPICE console When processing console request we get username from db and perform contains and substring on it. We did not check whether the name is null. This patch introduces this check. Bug-Url: https://bugzilla.redhat.com/1120692 Change-Id: Idd5f4a33f8fc5c41faead26afd7ce91c2412ac16 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd5f4a33f8fc5c41faead26afd7ce91c2412ac16 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0