August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-live[master]: build: fixed ovirt master snapshot url
by sbonazzo＠redhat.com 07 Aug '14

07 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: fixed ovirt master snapshot url ...................................................................... build: fixed ovirt master snapshot url Change-Id: I60a977f15370efb928657e5135424a976cc1c7eb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/kickstart/ovirt-live-base.ks.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60a977f15370efb928657e5135424a976cc1c7eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Removal of labelled network from DC inconsistent with ...
by lvernia＠redhat.com 07 Aug '14

07 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Removal of labelled network from DC inconsistent with removal from cluster ...................................................................... core: Removal of labelled network from DC inconsistent with removal from cluster - when removing labeled network from dc, "remove [that] network from host". I.e. call PersistentSetupNetworks so that given network is removed from host. Change-Id: I9ebc162324ff2ed98374d6a9a3bd9d87bb69db3f Bug-Url: https://bugzilla.redhat.com/1091692 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java 5 files changed, 78 insertions(+), 25 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ebc162324ff2ed98374d6a9a3bd9d87bb69db3f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: Changing foreman provider data loading
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: ui: Changing foreman provider data loading ...................................................................... ui: Changing foreman provider data loading When selected new provider the addHost external provider form fields will be cleaned and blocked till all provider's info will be loaded. In this patch we also change the update method which now retrieves all provider's info in each call, instead of loading only part of the information. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124842 Change-Id: Ie01a6c8b6d6f7e58a6057fc211ab5e4605bbe310 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 2 files changed, 63 insertions(+), 63 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie01a6c8b6d6f7e58a6057fc211ab5e4605bbe310 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: add host_provider_id to vdsStatic
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: add host_provider_id to vdsStatic ...................................................................... core: add host_provider_id to vdsStatic This allows to sign the provider id, which in hosts mostly foreman server id that added as external provider. With saving the ID we'll be able to gather more info about the host later on. Change-Id: Icced7dda43fee83aa904a068cff48b1fd3da4b76 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1113003 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_0830_add_provider_host_id_vdsstatic.sql M packaging/dbscripts/vds_sp.sql 12 files changed, 56 insertions(+), 22 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icced7dda43fee83aa904a068cff48b1fd3da4b76 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Enhanced permissions logging
by oourfali＠redhat.com 07 Aug '14

07 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Enhanced permissions logging ...................................................................... core: Enhanced permissions logging During permission check when logging level is set to DEBUG there is more information about which user is being checked and on which objects. When permission is not found it is logged to INFO level. Bug-Url: https://bugzilla.redhat.com/1121617 Change-Id: I4ba8fa00b8d28679b9896fe707623af89ac3c01f Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java 2 files changed, 53 insertions(+), 14 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ba8fa00b8d28679b9896fe707623af89ac3c01f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Change text of "Enable optional reason" selection box
by awels＠redhat.com 07 Aug '14

07 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Change text of "Enable optional reason" selection box ...................................................................... webadmin: Change text of "Enable optional reason" selection box Change the text of the checkbox to enable optional reason Change-Id: I76d514cc795271a50f91185a9be3805768876b84 Bug-Url: https://bugzilla.redhat.com/1126432 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76d514cc795271a50f91185a9be3805768876b84 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: converted some tabs to spaces
by awels＠redhat.com 07 Aug '14

07 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: converted some tabs to spaces ...................................................................... userportal, webadmin: converted some tabs to spaces Change-Id: I40178f984902e54bcda002381a0a17523f23b76b Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/DefaultConfirmationPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ForceRemoveConfirmationPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.ui.xml 3 files changed, 66 insertions(+), 66 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/31160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40178f984902e54bcda002381a0a17523f23b76b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: making sure not throw NPE when opening SPICE console
by oourfali＠redhat.com 07 Aug '14

07 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: making sure not throw NPE when opening SPICE console ...................................................................... core: making sure not throw NPE when opening SPICE console When processing console request we get username from db and perform contains and substring on it. We did not check whether the name is null. This patch introduces this check. Bug-Url: https://bugzilla.redhat.com/1120692 Change-Id: Idd5f4a33f8fc5c41faead26afd7ce91c2412ac16 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd5f4a33f8fc5c41faead26afd7ce91c2412ac16 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: sync LUNs on SD status changes to active
by derez＠redhat.com 07 Aug '14

07 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: core: sync LUNs on SD status changes to active ...................................................................... core: sync LUNs on SD status changes to active Ensure invocation of SyncLunsInfoForBlockStorageDomain command when a storage domain status changes to Active. * VdsEventListener: added syncLunsInfoForBlockStorageDomain method * IrsProxyData: perform synchronization when SD status is active: - Upon getStoragePoolInfo callback and status change detection. - Upon getVdsStats callback and active domain detection. Change-Id: I31ccdaaa8f7f982cb38dd8f1c4488d76cba21463 Bug-Url: https://bugzilla.redhat.com/1115845 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 5 files changed, 49 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31ccdaaa8f7f982cb38dd8f1c4488d76cba21463 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db, core, webadmin: Add is_live_merge_supported flag
by derez＠redhat.com 07 Aug '14

07 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: db, core, webadmin: Add is_live_merge_supported flag ...................................................................... db, core, webadmin: Add is_live_merge_supported flag Some hosts may not have updated software capable of live merging snapshots, which vdsm will report in its capabilities using the 'liveMerge' flag. Capture this flag, and use it to limit live merge operations on hosts not supporting the feature. Change-Id: I932a74f4010b8b256f8c0cd27a2279b9d83efbb9 Bug-Url: https://bugzilla.redhat.com/1124099 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_0130_add_live_merge_supported.sql M packaging/dbscripts/vds_sp.sql 23 files changed, 124 insertions(+), 22 deletions(-) Approvals: Greg Padgett: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I932a74f4010b8b256f8c0cd27a2279b9d83efbb9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0