September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Live Merge recovery flow
by tnisan＠redhat.com 18 Sep '14

18 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Live Merge recovery flow ...................................................................... core: Live Merge recovery flow When a VM stops running during a live merge, check the status using a new reconcileVolumeChain vdsm verb. This verb will ensure the volume chain is correct and return the comprising images, which we can then use to converge the Live Merge flow while the VM is still down. Change-Id: Ie858c69412698e9a11a7f52ee88c3c078b3f2303 Bug-Url: https://bugzilla.redhat.com/1129898 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommandCallback.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReconcileVolumeChainVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ReconcileVolumeChainVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/VolumeListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 11 files changed, 192 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Greg Padgett: Verified -- To view, visit http://gerrit.ovirt.org/33018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie858c69412698e9a11a7f52ee88c3c078b3f2303 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fix Live Merge regression
by tnisan＠redhat.com 18 Sep '14

18 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix Live Merge regression ...................................................................... core: Fix Live Merge regression A change in CoCo exposed some bad code in DestroyImageCommand; fix the async task creation to not reference the wrong command type. Change-Id: I90e4b96cb673975c964fcb37146ad6baa510c8eb Bug-Url: https://bugzilla.redhat.com/1141985 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Greg Padgett: Verified -- To view, visit http://gerrit.ovirt.org/33017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90e4b96cb673975c964fcb37146ad6baa510c8eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix NPE in Configure Local Storage for host
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix NPE in Configure Local Storage for host ...................................................................... webadmin: Fix NPE in Configure Local Storage for host Change-Id: I76bc89af6a22c269b3ce2034466d652f6e0e6db2 Bug-Url: https://bugzilla.redhat.com/1139675 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76bc89af6a22c269b3ce2034466d652f6e0e6db2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Live Merge recovery flow
by derez＠redhat.com 17 Sep '14

17 Sep '14

Daniel Erez has submitted this change and it was merged. Change subject: core: Live Merge recovery flow ...................................................................... core: Live Merge recovery flow When a VM stops running during a live merge, check the status using a new reconcileVolumeChain vdsm verb. This verb will ensure the volume chain is correct and return the comprising images, which we can then use to converge the Live Merge flow while the VM is still down. Change-Id: Ie858c69412698e9a11a7f52ee88c3c078b3f2303 Bug-Url: https://bugzilla.redhat.com/1129898 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommandCallback.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReconcileVolumeChainVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ReconcileVolumeChainVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/VolumeListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 11 files changed, 192 insertions(+), 14 deletions(-) Approvals: Greg Padgett: Verified Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie858c69412698e9a11a7f52ee88c3c078b3f2303 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix Live Merge regression
by derez＠redhat.com 17 Sep '14

17 Sep '14

Daniel Erez has submitted this change and it was merged. Change subject: core: Fix Live Merge regression ...................................................................... core: Fix Live Merge regression A change in CoCo exposed some bad code in DestroyImageCommand; fix the async task creation to not reference the wrong command type. Change-Id: I90e4b96cb673975c964fcb37146ad6baa510c8eb Bug-Url: https://bugzilla.redhat.com/1141985 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90e4b96cb673975c964fcb37146ad6baa510c8eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove redundant JOIN statement in a storage procedure
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundant JOIN statement in a storage procedure ...................................................................... core: Remove redundant JOIN statement in a storage procedure Removed JOIN in fn_get_actual_images_size_by_storage, the join with between images_storage_domain_view and disk_image_dynamic since the field actual_size used in the statement already exists in images_storage_domain_view Change-Id: I4f7096ef43876f3b2b96f61a60620e0e33a4e6db Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M packaging/dbscripts/create_functions.sql 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f7096ef43876f3b2b96f61a60620e0e33a4e6db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Add an AuditLog message when VM cannot be prestarted
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Add an AuditLog message when VM cannot be prestarted ...................................................................... engine: Add an AuditLog message when VM cannot be prestarted When a VM pool prestart is requested, but there are not enough resources to start some VMs - inform the administrator using Audit Log. Change-Id: Iab04acb1746a22627b584d70c806469a818a6c8c Bug-Url: https://bugzilla.redhat.com/1073551 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 13 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab04acb1746a22627b584d70c806469a818a6c8c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use proper message when scheduling fails with not enou...
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use proper message when scheduling fails with not enough cores ...................................................................... core: Use proper message when scheduling fails with not enough cores Leftover from scheduling reporting refactoring, the CPUPolicyUnit still used the old error message style. This updates it to the new mechanism. Change-Id: Ibf9247ecded75bb4c4a3bd8e8a7bd23e11ac670b Bug-Url: https://bugzilla.redhat.com/1129542 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CPUPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 8 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf9247ecded75bb4c4a3bd8e8a7bd23e11ac670b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: add distinct keyword to search
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: add distinct keyword to search ...................................................................... core: add distinct keyword to search currently, the search can return duplicate results, for example when template has more than one disk, or disks are on different storage domains. this patch adds a 'distinct' to the sql the search mechanism creates, in order to remove any duplicates that return from the query. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130915 Change-Id: I070900dc9e1064c98f8b342f26dbc3c23ba8c4a4 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 2 files changed, 67 insertions(+), 65 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/32676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I070900dc9e1064c98f8b342f26dbc3c23ba8c4a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Dont set flowid in UI code
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine : Dont set flowid in UI code ...................................................................... engine : Dont set flowid in UI code The frontend code should not set flowid for reports webapp Change-Id: I83fccc71cfac53b30a117628bb84e76947fef67b Bug-Url: https://bugzilla.redhat.com/1116851 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 2f5e6daf1174070d0677c9adb565bd7f90441a75) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java 2 files changed, 0 insertions(+), 11 deletions(-) Approvals: Ravi Nori: Verified; Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83fccc71cfac53b30a117628bb84e76947fef67b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0