September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: refresh wraps.
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal,webadmin: refresh wraps. ...................................................................... userportal,webadmin: refresh wraps. - GWT can't determine the width of margins, and thus the calculations will be wrong when you use them in an action panel. Switched margins to padding which GWT does detect properly. Change-Id: I9f641172099df224f7a4fda322449d02e842068c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1123277 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Alexander Wels: Verified -- To view, visit http://gerrit.ovirt.org/33551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f641172099df224f7a4fda322449d02e842068c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: fix import flow for cpu profile
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: fix import flow for cpu profile ...................................................................... engine: fix import flow for cpu profile Handles import more than once as well. Change-Id: Ice68c57b56208413df6a021650e3b996de14cef5 Bug-Url: https://bugzilla.redhat.com/1145935 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 5 files changed, 23 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/33547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice68c57b56208413df6a021650e3b996de14cef5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: refactor—overgrown constructor
by lvernia＠redhat.com 30 Sep '14

30 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: refactor—overgrown constructor ...................................................................... webadmin: refactor—overgrown constructor - overgrown constructor split to smaller, single purpose methods (I need to add next gui code there, and it's too long already) - make all parameters final, if they can be final, not just some. Change-Id: I05d1ec1064eb3ec4ce17f88a2d532cb76aa4f39d Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/SharedMacPoolView.java 1 file changed, 37 insertions(+), 10 deletions(-) Approvals: Martin Mucha: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05d1ec1064eb3ec4ce17f88a2d532cb76aa4f39d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: fix import flow for cpu profile
by gchaplik＠redhat.com 30 Sep '14

30 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: fix import flow for cpu profile ...................................................................... engine: fix import flow for cpu profile Handles import more than once as well. Change-Id: Ice68c57b56208413df6a021650e3b996de14cef5 Bug-Url: https://bugzilla.redhat.com/1145935 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 5 files changed, 23 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice68c57b56208413df6a021650e3b996de14cef5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: Do not emit email events when the state was not changed
by msivak＠redhat.com 30 Sep '14

30 Sep '14

Martin Sivák has submitted this change and it was merged. Change subject: Do not emit email events when the state was not changed ...................................................................... Do not emit email events when the state was not changed This also fixes the trigger regexp to be more in alignment with the current state machine. Change-Id: I2da55f4497fd139a0a1ba4f3079a4e97972adb08 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1146433 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit da8f16f844ec527f85f04a0f2a460b79e1c7d9ab) --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/broker/broker.conf 2 files changed, 6 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2da55f4497fd139a0a1ba4f3079a4e97972adb08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: build: post ovirt-hosted-engine-ha-1.2.1
by msivak＠redhat.com 30 Sep '14

30 Sep '14

Martin Sivák has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.2.1 ...................................................................... build: post ovirt-hosted-engine-ha-1.2.1 Change-Id: Ibca7ca95d84c122995ea1cbbcb5212434c644172 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibca7ca95d84c122995ea1cbbcb5212434c644172 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core : JBoss Servlet Exception at Page Loads :: no protocol:...
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core : JBoss Servlet Exception at Page Loads :: no protocol: /ovirt/reports-interface ...................................................................... core : JBoss Servlet Exception at Page Loads :: no protocol: /ovirt/reports-interface When reports server is not installed and the reports base url is empty the redirect url does not have a protocal associated with it. So the url "/ovirt/reports-interface" throws an exception in server logs Change-Id: I485dff572fe8ce1ffb61d77b5032b540735f93f2 Bug-Url: https://bugzilla.redhat.com/1142748 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/ProxyServlet.java 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I485dff572fe8ce1ffb61d77b5032b540735f93f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: fixing iptables review dialog
by sbonazzo＠redhat.com 30 Sep '14

30 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: fixing iptables review dialog ...................................................................... packaging: setup: fixing iptables review dialog Writing the will to review iptables changes into answer file, fixing a bug Change-Id: I8f16a90a074052226882d76fc80918ed276d379c Bug-url: https://bugzilla.redhat.com/1109326 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_iptables.py M packaging/setup/plugins/ovirt-engine-setup/base/network/firewall_manager.py 3 files changed, 104 insertions(+), 47 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f16a90a074052226882d76fc80918ed276d379c Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core : Welcome page should use base reports URL
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core : Welcome page should use base reports URL ...................................................................... core : Welcome page should use base reports URL Welcome page should redirect user to base reports url from reports portal link Change-Id: I732df3a7d6ebec5915be21bb945889d8660c615c Bug-Url: https://bugzilla.redhat.com/1116851 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java 2 files changed, 15 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I732df3a7d6ebec5915be21bb945889d8660c615c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core, webadmin : Fix issues with reports integration
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core, webadmin : Fix issues with reports integration ...................................................................... core, webadmin : Fix issues with reports integration Reports tab and right click reports generation need to use different url to access reports. Reports tab is not updated when clicking on system tree. Sometimes null uri is sent to reports. Change-Id: Id5e91aa80dcd4e4d4f175d0193e92d19e65281e6 Bug-Url: https://bugzilla.redhat.com/1116851 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java M packaging/services/ovirt-engine/ovirt-engine.conf.in 7 files changed, 59 insertions(+), 44 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5e91aa80dcd4e4d4f175d0193e92d19e65281e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0