September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Implement toString() in StorageDomain, StorageDomainSta...
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Implement toString() in StorageDomain,StorageDomainStatic,StoragePool ...................................................................... core: Implement toString() in StorageDomain,StorageDomainStatic,StoragePool Change-Id: I34a70ea21e6c5996d430eef013c5d93360aa04e4 Bug-Url: https://bugzilla.redhat.com/1142198 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java 3 files changed, 18 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34a70ea21e6c5996d430eef013c5d93360aa04e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: add more logs to commands factory
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: add more logs to commands factory ...................................................................... core: add more logs to commands factory Bug-Url: https://bugzilla.redhat.com/1141531 Change-Id: I05d09d13fdc1bb40c35254d6d44e28f8005a6ec7 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/33008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05d09d13fdc1bb40c35254d6d44e28f8005a6ec7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: clear subtab item
by awels＠redhat.com 17 Sep '14

17 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: clear subtab item ...................................................................... userportal,webadmin: clear subtab item - When unselecting a main tab grid item, the active detail model was not cleared. This caused the detail model to not be refreshed when re-selecting the item in the main grid. This patch clears the active detail model when unselecting the item in the main tab grid. Change-Id: I5309207cb8153f7b1d5c8e53a117dd8440a98698 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131147 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DetailModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DetailTabModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/SearchableDetailTabModelProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/UserPortalDetailModelProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/UserPortalSearchableDetailModelProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterTemplateInfoPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 10 files changed, 51 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5309207cb8153f7b1d5c8e53a117dd8440a98698 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Implement toString() in StorageDomain, StorageDomainSta...
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Implement toString() in StorageDomain,StorageDomainStatic,StoragePool ...................................................................... core: Implement toString() in StorageDomain,StorageDomainStatic,StoragePool Change-Id: I34a70ea21e6c5996d430eef013c5d93360aa04e4 Bug-Url: https://bugzilla.redhat.com/1142198 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java 3 files changed, 19 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34a70ea21e6c5996d430eef013c5d93360aa04e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: drag windows
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal,webadmin: drag windows ...................................................................... userportal,webadmin: drag windows - Due to some layout changes the 'Caption' of the windows was now below some transparent layer and was not receiving events anymore. I move the 'Caption' layer to the top and everything is working again. Change-Id: Iee527761196d9a43a3eef003f60e2063e04d9d9c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139634 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M packaging/branding/ovirt.brand/gwt_common.css 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee527761196d9a43a3eef003f60e2063e04d9d9c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Fix NPE in os info
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Fix NPE in os info ...................................................................... frontend: Fix NPE in os info This patch takes care of console-related methods in AsyncDataProvider. NPE can occur when existing vm is edited, but its OS was removed from os info file. Fixed by handling nulls in AsyncDataProvider and handling non-existent OS case in client code (UnitVmModel). Change-Id: I2aef27aee8e079497c9eaa22dfaa6cb9b5502aae Bug-Url: https://bugzilla.redhat.com/1046809 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/32981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2aef27aee8e079497c9eaa22dfaa6cb9b5502aae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add more logs to commands factory
by yzaslavs＠redhat.com 17 Sep '14

17 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: add more logs to commands factory ...................................................................... core: add more logs to commands factory Bug-Url: https://bugzilla.redhat.com/1141531 Change-Id: I05d09d13fdc1bb40c35254d6d44e28f8005a6ec7 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05d09d13fdc1bb40c35254d6d44e28f8005a6ec7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Replace "storage_manager" with "spm"
by juan.hernandez＠redhat.com 17 Sep '14

17 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Replace "storage_manager" with "spm" ...................................................................... restapi: Replace "storage_manager" with "spm" Currently the SPM priority of a host is modeled in the RESTAPI as an attribute of an element that also has text content: <host> <storage_manager priority="5">true</storage_manager> </host> This means that it is impossible to send an udpate containing only the priority and not the text content. For example, a document like the following: <host> <storage_manager priority="5"/> </host> Is not valid because the text is declared as xs:boolean, and an empty text isn't a valid value. To avoid this issue this patch removes the "storage_manager" element from the RSDL metadata and introduces a new "spm" element that contains inner elements for the priority and the SPM status. For example: <host> <spm> <priority>5</priority> <status> <state>spm</state> </status> </spm> </host> This way clients can send updates for only the priority: <host> <spm> <priority>6</priority> </spm> </host> The previous "storage_manager" element and its behaviour are preserved for backwards compatibility, but removed from the RSDL metadata. Change-Id: I9bb8dba2385b1219f6d90fa99692a79fc7cb36b7 Bug-Url: https://bugzilla.redhat.com/1136061 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SpmState.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 6 files changed, 120 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bb8dba2385b1219f6d90fa99692a79fc7cb36b7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: VM helper as static method
by juan.hernandez＠redhat.com 17 Sep '14

17 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: VM helper as static method ...................................................................... restapi: VM helper as static method This class simulates a resource using internal Resteasy injection implementation. This doesn't work in newer versions of Resteasy. To avoid that this patch converts it into static methods. Not very nice, will be reworked in the future. Change-Id: I6710f8acd2da463303218f596b57747b0622a475 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ResourceHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateBasedResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesBasedResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java 15 files changed, 22 insertions(+), 83 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Daniel Erez: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6710f8acd2da463303218f596b57747b0622a475 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: sdk: Don't use _(...)
by juan.hernandez＠redhat.com 17 Sep '14

17 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Don't use _(...) ...................................................................... sdk: Don't use _(...) The CLI doesn't setup the _ function for i18n anywhere, so using it causes exceptions. Change-Id: I4309167af5a6ed4ffca67ede9f233ddd19166f78 Bug-Url: https://bugzilla.redhat.com/1135544 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/infrastructure/options.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4309167af5a6ed4ffca67ede9f233ddd19166f78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0