September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: ui: Adding fields validation in addHost form
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: ui: Adding fields validation in addHost form ...................................................................... ui: Adding fields validation in addHost form 1. For root password during provisioning host 2. For empty compute resources and host group lists, when discovered host is added. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127606 Change-Id: Icfc3e500ad06728fc8c410baa13405633fc90da2 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfc3e500ad06728fc8c410baa13405633fc90da2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add validation for empty compute resource or host group
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add validation for empty compute resource or host group ...................................................................... core: Add validation for empty compute resource or host group Change-Id: Id26697e3e7a1b98c7e5e557cff3fd7078aecb67a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127606 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 4 files changed, 17 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id26697e3e7a1b98c7e5e557cff3fd7078aecb67a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add validation for empty compute resource or host group
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add validation for empty compute resource or host group ...................................................................... core: Add validation for empty compute resource or host group Change-Id: Id26697e3e7a1b98c7e5e557cff3fd7078aecb67a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127606 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 4 files changed, 17 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id26697e3e7a1b98c7e5e557cff3fd7078aecb67a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: setup: Make pki interaction easier
by ydary＠redhat.com 21 Sep '14

21 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Make pki interaction easier ...................................................................... packaging: setup: Make pki interaction easier Make pki interaction use files and ask again if needed. Requires: http://gerrit.ovirt.org/32742 Bug-Url: https://bugzilla.redhat.com/1118328 Bug-Url: https://bugzilla.redhat.com/1118330 Change-Id: Ia5b3713330d6e11bd7c374e04f17660be79f2251 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit c390da6ed5a42c1c49eadc2c039c8f8aa316ff9e) --- M packaging/setup/ovirt_engine_setup/reports/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/sso.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py 4 files changed, 297 insertions(+), 145 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b3713330d6e11bd7c374e04f17660be79f2251 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: NPE in Picking first provider
by oourfali＠redhat.com 21 Sep '14

21 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: NPE in Picking first provider ...................................................................... webadmin: NPE in Picking first provider Fix assumption that first provider exists Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1144807 Change-Id: I71d1249d86a6b700708391eb19ba98302dd0be4a Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71d1249d86a6b700708391eb19ba98302dd0be4a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: wrong param name for fencing policy
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: wrong param name for fencing policy ...................................................................... core: wrong param name for fencing policy In the api schema and API.py the fencing policy param is named policy whereas engine passes fencingPolicy so value is not properly mapped. This patch fixes the naming. Change-Id: I291eb7973afa023e2f3d49bd09b966ce6ae9e333 Bug-Url: https://bugzilla.redhat.com/1143860 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I291eb7973afa023e2f3d49bd09b966ce6ae9e333 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use error for audit log on import template from config...
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use error for audit log on import template from configuration. ...................................................................... core: Use error for audit log on import template from configuration. Use error audit log instead of refular audit log when the import VM from configuration fails Change-Id: I134f3a2015b7f249a361bd237b824709f7210f40 Bug-Url: https://bugzilla.redhat.com/1140584 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I134f3a2015b7f249a361bd237b824709f7210f40 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Validate Storage Domain for Importing Template from co...
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Validate Storage Domain for Importing Template from configuration ...................................................................... core: Validate Storage Domain for Importing Template from configuration For each disk in the template, we should fetch the Storage Domain and validate that it exists and active. Today, we set the storage id for each image and then use getStorageDomain method to fetch the Storage Domain with that id, but when the Storage Domain being initialized, it will always check the first Storage Domain every time. Change-Id: I2bfe3ba9b48747650291a887255e85358ed0799a Bug-Url: https://bugzilla.redhat.com/1138200 Bug-Url: https://bugzilla.redhat.com/1140560 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bfe3ba9b48747650291a887255e85358ed0799a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use the latest OVF_STORE files
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use the latest OVF_STORE files ...................................................................... core: Use the latest OVF_STORE files Rotate over the OVF_STORE disks and retrieve the entities from the best match of the OVF_STORE disk until succeeded. Also register those disks as OVF_STORE disks, so it will be updated every time there will be any change in the entities' OVF. Change-Id: I8252281f295df49a28c3c131d9a98fef9af8f35e Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 47 insertions(+), 32 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8252281f295df49a28c3c131d9a98fef9af8f35e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Validate disk registration only if a domain exists.
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Validate disk registration only if a domain exists. ...................................................................... core: Validate disk registration only if a domain exists. Registeration of a disk is only a DB operation and does not encounter any VDS commands, therefore, there should not be any validation for Storage Domain activation. Change-Id: I71c138ede22808b5a887e9b9982c154e5591d5c9 Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71c138ede22808b5a887e9b9982c154e5591d5c9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0