January 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Comment fix.
by juan.hernandez＠redhat.com 06 Jan '15

06 Jan '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Comment fix. ...................................................................... restapi: Comment fix. A javadoc comment fix regarding getting a storage domain resource. Change-Id: I011459d8c5674c90302ee661cc2385ffdfeb4b21 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainsResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Amit Aviram: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I011459d8c5674c90302ee661cc2385ffdfeb4b21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Make ConfigValuesTest more informative
by tnisan＠redhat.com 06 Jan '15

06 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Make ConfigValuesTest more informative ...................................................................... core: Make ConfigValuesTest more informative Currently the test stops after finding one missing values, it makes no sense to keep runing the test over and over until you fix all missing values issues so the missing values will be aggregated in a list. Aside for that, the logging of the missing value is swallowed between all the other tests and the test summary does not show which key was missing so the missing values are also added to the test result now Change-Id: Icb921f082350d19006c7b977c2697009bbc2a10d Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/ConfigValuesTest.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb921f082350d19006c7b977c2697009bbc2a10d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Bll command to refresh geo-rep data
by kmayilsa＠redhat.com 06 Jan '15

06 Jan '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Bll command to refresh geo-rep data ...................................................................... engine: Bll command to refresh geo-rep data BLL command to execute sync of geo-rep data from Gluster CLI. Change-Id: I416663044217891820d0540e3e63e7aa12330f45 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGeoRepSessionsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 73 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/34630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I416663044217891820d0540e3e63e7aa12330f45 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Monitoring of geo-rep status and statistics
by kmayilsa＠redhat.com 06 Jan '15

06 Jan '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Monitoring of geo-rep status and statistics ...................................................................... engine: Monitoring of geo-rep status and statistics Created a scheduler job to poll for status and statistics of each session. Exposed the methods of GlusterGeoRepSyncJob to refresh status and discover geo-rep sessions for a volume, so that these can be triggered via UI and API Change-Id: I67e857ab2ce993cded966fb60b361f6962b9a665 Bug-Url: https://bugzilla.redhat.com/1138116 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJobsManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepStatusDetailVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/gluster_georep_sp.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 14 files changed, 307 insertions(+), 66 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/34552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67e857ab2ce993cded966fb60b361f6962b9a665 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use HostValidator in AddVdsCommand
by masayag＠redhat.com 06 Jan '15

06 Jan '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use HostValidator in AddVdsCommand ...................................................................... engine: Use HostValidator in AddVdsCommand For the sake of DRY, AddVdsCommand will use the HostValidator for covering its basic validations. Change-Id: Iad171cbeca252d72417e59be01e1cd6955a07933 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsCommandTest.java 2 files changed, 63 insertions(+), 78 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad171cbeca252d72417e59be01e1cd6955a07933 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Introduce HostValidator
by masayag＠redhat.com 06 Jan '15

06 Jan '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Introduce HostValidator ...................................................................... engine: Introduce HostValidator The HostValidator is intended to verify the host parameters when the host is being added or being updated in the system. Change-Id: I2256daf1de6a510c5b6ccb18846dd36bdc107f7d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java 2 files changed, 332 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2256daf1de6a510c5b6ccb18846dd36bdc107f7d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Query to fetch list of volumes eligible for geo rep...
by kmayilsa＠redhat.com 06 Jan '15

06 Jan '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine : Query to fetch list of volumes eligible for geo replication ...................................................................... engine : Query to fetch list of volumes eligible for geo replication Query to fetch list of volumes eligible for geo replication session. This query fetches a list of volumes satisfying the required conditions for geo replication session establishment. Change-Id: I0fc3ecb15535181f1ca2a8780461cb89788a3f41 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterGeoRepUtil.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GeoRepCreateEligibilityBaseTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQueryTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepNonEligibilityReason.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeGeoRepEligibilityParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M packaging/dbscripts/gluster_georep_sp.sql M packaging/dbscripts/vds_groups_sp.sql 19 files changed, 631 insertions(+), 2 deletions(-) Approvals: anmolbabu: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fc3ecb15535181f1ca2a8780461cb89788a3f41 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Refactor AddVdsGroupCommand to use ClusterValidator
by masayag＠redhat.com 06 Jan '15

06 Jan '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Refactor AddVdsGroupCommand to use ClusterValidator ...................................................................... engine: Refactor AddVdsGroupCommand to use ClusterValidator Change-Id: I88935a776009c8a67ab58865b7fc52bb8f8bbcf6 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java 1 file changed, 16 insertions(+), 100 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88935a776009c8a67ab58865b7fc52bb8f8bbcf6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Introduce ClusterValidator
by masayag＠redhat.com 06 Jan '15

06 Jan '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Introduce ClusterValidator ...................................................................... engine: Introduce ClusterValidator The ClusterValidator will be used to validate the input for the Cluster related commands. Change-Id: I005cca2295a215d1a694d3d7604dabc59a77595c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ClusterValidatorTest.java 2 files changed, 521 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I005cca2295a215d1a694d3d7604dabc59a77595c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove code duplication in VdsNetworkInterface.toString()
by lvernia＠redhat.com 06 Jan '15

06 Jan '15

Lior Vernia has submitted this change and it was merged. Change subject: core: Remove code duplication in VdsNetworkInterface.toString() ...................................................................... core: Remove code duplication in VdsNetworkInterface.toString() Changed the serialization of VdsNetworkInterface to re-use code instead of duplicate it. New serialized attributes were being added only to VdsNetworkInterface by unsuspecting developers, yet these would not show in the engine log, for example on Setup Networks commands, as the base class method was being overridden by subclasses (where the new attributes weren't being added). Change-Id: I94bbf7113e848f6ca8ae4a38e46303050d653135 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Bond.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Nic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Vlan.java 4 files changed, 63 insertions(+), 145 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/36215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94bbf7113e848f6ca8ae4a38e46303050d653135 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0