January 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Remove compatibility check when updating reported QoS
by lvernia＠redhat.com 04 Jan '15

04 Jan '15

Lior Vernia has submitted this change and it was merged. Change subject: engine: Remove compatibility check when updating reported QoS ...................................................................... engine: Remove compatibility check when updating reported QoS This should be okay without the check even when the host is too old - the entry should just not exist, and then be deserialized to null (which is exactly as avoiding it altogether). The check had only been put there because of a backwards compatibility problem with reported QoS between 3.3 and 3.4, but towards 3.6 the entry name was completely changed, so it can't be reported in a non-compatible manner anymore. Change-Id: I4bcb42b9e1a0f5c978c90d02b635ae30570a48aa Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bcb42b9e1a0f5c978c90d02b635ae30570a48aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove validations when running suspended VM
by shavivi＠redhat.com 04 Jan '15

04 Jan '15

Shahar Havivi has submitted this change and it was merged. Change subject: core: Remove validations when running suspended VM ...................................................................... core: Remove validations when running suspended VM Remove unneeded parts from RunVmValidator for suspended VMs, most checks are irrelevant for this use-case. These checks prevented from resuming VMs which passed the original run validations using run-once options. Change-Id: Ib86e5764187a6ba12b13111392e7f992644368c5 Bug-Url: https://bugzilla.redhat.com/1167374 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Eldan Shachar: Verified Shahar Havivi: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib86e5764187a6ba12b13111392e7f992644368c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fix migrate dialog
by ahadas＠redhat.com 04 Jan '15

04 Jan '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: fix migrate dialog ...................................................................... webadmin: fix migrate dialog The migrate dialog did not work because the returned value of the query for all hosts in cluster changed from ArrayList to LinkedList. The solution is to handle the returned value as List. Change-Id: I5e004186025a63703e9a02a193c4d72791a9c303 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MigrateModel.java 2 files changed, 5 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/36547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e004186025a63703e9a02a193c4d72791a9c303 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove unused stored procedure
by ahadas＠redhat.com 04 Jan '15

04 Jan '15

Arik Hadas has submitted this change and it was merged. Change subject: core: remove unused stored procedure ...................................................................... core: remove unused stored procedure Remove the stored procedure GetVmByHibernationImageId and the method VmDAO#getForHibernationImage that called it. Change-Id: I0211fcba5bfb417a8173b1e4465e4a3a50866fd7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M packaging/dbscripts/vms_sp.sql 4 files changed, 0 insertions(+), 38 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/36520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0211fcba5bfb417a8173b1e4465e4a3a50866fd7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix a lost context in VmManagementCommandBase
by ahadas＠redhat.com 04 Jan '15

04 Jan '15

Arik Hadas has submitted this change and it was merged. Change subject: core: fix a lost context in VmManagementCommandBase ...................................................................... core: fix a lost context in VmManagementCommandBase The command didn't transfer the context to the parent command for initialization, this caused errors on AddVmCommand which tried using this context information. Change-Id: I10e8b2845125fb640661b6624d4b673e7724fe4d Bug-Url: https://bugzilla.redhat.com/1140569 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eldan Shachar: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10e8b2845125fb640661b6624d4b673e7724fe4d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: move getActiveSnapshot to VmCommand
by ahadas＠redhat.com 02 Jan '15

02 Jan '15

Arik Hadas has submitted this change and it was merged. Change subject: core: move getActiveSnapshot to VmCommand ...................................................................... core: move getActiveSnapshot to VmCommand Since we are going to use this method in other VM commands, it is moved from RunVmCommand to VmCommand. RunVmCommand#getSnapshotDao is also removed, and AuditLogableBase#getSnapshotDAO is used instead. Change-Id: I11213c49c3bbb7b733722bb9501d2616c09ae2e0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 3 files changed, 11 insertions(+), 14 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/36521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11213c49c3bbb7b733722bb9501d2616c09ae2e0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup in hibernate command
by ahadas＠redhat.com 02 Jan '15

02 Jan '15

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in hibernate command ...................................................................... core: cleanup in hibernate command - remove outdated comment - cleanup the call to the vds command Change-Id: I0bba89c108e44819af812928f71a7fac6a184d59 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java 1 file changed, 2 insertions(+), 9 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/36519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bba89c108e44819af812928f71a7fac6a184d59 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ActivateDeactivateSingleAsyncOperationFactory- wrong type
by laravot＠redhat.com 01 Jan '15

01 Jan '15

Liron Aravot has submitted this change and it was merged. Change subject: core: ActivateDeactivateSingleAsyncOperationFactory- wrong type ...................................................................... core: ActivateDeactivateSingleAsyncOperationFactory- wrong type ActivateDeactivateSingleAsyncOperationFactory expects the recieved VDS list to be an ArrayList. That list is usually passed as returned by the DAO, which means that the concrete type depends on the spring jdbc internal implementation. In this patch I create an ArrayList out of the passed List, I didn't change the type as the entire "Operation" infrastracture use that list for different operation by issuing get() (I assume that this is the reason ArrayList was used in the first place). We need to make further changes here, but this is a quick fixup. As that infrastracture isn't used so commonly, this solution seems good enough in the meanwhile. Change-Id: If0de8b0f5838e7a464cf093b2deeeda67b32a560 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1177595 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0de8b0f5838e7a464cf093b2deeeda67b32a560 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Support warnning for import/attach operation
by mlipchuk＠redhat.com 01 Jan '15

01 Jan '15

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Support warnning for import/attach operation ...................................................................... webadmin: Support warnning for import/attach operation 1. Adding properties for the attach/import confirmation module. 2. Add attach warnning in Data center module 3. Adding GUI support in the Storage module to support the confirmation warnning on attach and import Storage Domain command Change-Id: I22f7149e298ab38f816e49184f5d02b4e01e3db6 Bug-Url: https://bugzilla.redhat.com/1138115 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DataCenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/StorageModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StorageForceCreatePopupView.ui.xml 8 files changed, 338 insertions(+), 102 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22f7149e298ab38f816e49184f5d02b4e01e3db6 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add query calls to AsyncDataProvider
by mlipchuk＠redhat.com 01 Jan '15

01 Jan '15

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Add query calls to AsyncDataProvider ...................................................................... webadmin: Add query calls to AsyncDataProvider Adding calls to the attached Storage Domains' queries Change-Id: Ie1cac201f0688f81ac84a4ae1aee3bf483504c0f Bug-Url: https://bugzilla.redhat.com/1138115 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 43 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/36450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1cac201f0688f81ac84a4ae1aee3bf483504c0f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0