November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Test AddVdsSpmIdCommand#insertSpmIdToDb
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Test AddVdsSpmIdCommand#insertSpmIdToDb ...................................................................... core: Test AddVdsSpmIdCommand#insertSpmIdToDb Introduced a simple test case for the insertSpmIdToDb method. It receives a list of existing vds_spm_ids and verifies that the correct new one is inserted into the mocked database. Change-Id: I1c77c1a0d732d0c7351449bddf5bde1e85aba70a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommandTest.java 2 files changed, 73 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c77c1a0d732d0c7351449bddf5bde1e85aba70a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveVmTemplateFromImportExportCommand streaming API
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveVmTemplateFromImportExportCommand streaming API ...................................................................... core: RemoveVmTemplateFromImportExportCommand streaming API Replaced the cumbersome LinqUtils call with a more modern and elegant usage of Java 8's streaming API. Change-Id: Iedd479d3714963228224c7d2278814f726af06f5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java 1 file changed, 4 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedd479d3714963228224c7d2278814f726af06f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: OvfUpdateProcessHelper streaming API
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfUpdateProcessHelper streaming API ...................................................................... core: OvfUpdateProcessHelper streaming API Replaced the cumbersome LinqUtils call with a more modern and elegant usage of Java 8's streaming API. Change-Id: Ice3ad857c2a158cf4de27826301ea347fb8c7f97 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfUpdateProcessHelper.java 1 file changed, 5 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49048 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice3ad857c2a158cf4de27826301ea347fb8c7f97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageServerConnectionLunMapDaoTest members
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageServerConnectionLunMapDaoTest members ...................................................................... core: StorageServerConnectionLunMapDaoTest members Reduce members' scope and convert them to local variables, or better yet, remove them completely where possible. This change makes the class easier to read and understand by removing what is essentially transient data from the test's state so these members don't steal the reader's focus. Change-Id: I01a6a96c6b09cec87447086af908820e3363e41f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoTest.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01a6a96c6b09cec87447086af908820e3363e41f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ImportVmFromConfigurationCommand streaming API
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVmFromConfigurationCommand streaming API ...................................................................... core: ImportVmFromConfigurationCommand streaming API Replaced the outdated LinqUtils call with a more modern use of Java 8's stream APIs. Besides cleaning up the code, it offers a slight performance improvement by iterating the list only once instead of twice - one for the casting and another one to construct an ArrayList. Change-Id: I969bb726efb84898e22a6ede219a31aabce44308 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49047 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I969bb726efb84898e22a6ede219a31aabce44308 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: checkTemplateInStorageDomain perfomance
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: checkTemplateInStorageDomain perfomance ...................................................................... core: checkTemplateInStorageDomain perfomance domainsId is a local variable only used for checking Collections.disjoint. This patch changes it from being a List (generating a potential O(m*n) disjoint call) with a Set (an O(n), n <= m disjoint call) in order to improve performance. Change-Id: Ib73929b1ffed74c51340190863d890a2e6b1bfa6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib73929b1ffed74c51340190863d890a2e6b1bfa6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ISCSIStorageHelper streaming APIs
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: ISCSIStorageHelper streaming APIs ...................................................................... core: ISCSIStorageHelper streaming APIs Replaced old fashioned LinqUtils calls with modern Java 8 streaming API to make the code easier to understand and maintain. Change-Id: Ie4f01138b97c35d169b43a746cd2522907afa776 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 20 insertions(+), 35 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4f01138b97c35d169b43a746cd2522907afa776 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ISCSIStorageHelper TODO
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: ISCSIStorageHelper TODO ...................................................................... core: ISCSIStorageHelper TODO Replace the TODO's javadoc comment style (/** */) with a regular line comment (//), as having javadoc headers inside a method's body may break some javadoc doclets. Change-Id: I53521971ed3b66282c34cd2776c4cc2378ff0835 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53521971ed3b66282c34cd2776c4cc2378ff0835 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveDiskSnapshotsCommand streaming API
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveDiskSnapshotsCommand streaming API ...................................................................... core: RemoveDiskSnapshotsCommand streaming API Replaced the cumbersome LinqUtils call with a more modern and elegant usage of Java 8's streaming API. Change-Id: I91d59653592cc7a7e718126506fca454b7fd51ef Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java 1 file changed, 3 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91d59653592cc7a7e718126506fca454b7fd51ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ISCSIStorageHelper condition
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: ISCSIStorageHelper condition ...................................................................... core: ISCSIStorageHelper condition Removed a redundant null check that just adds unneeded complexity to the code. Change-Id: If2236575188cf7ea82332d56b002ca8428d4be73 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2236575188cf7ea82332d56b002ca8428d4be73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0