November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: Fix escaped HTML in table headers
by vszocs＠redhat.com 25 Nov '15

25 Nov '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Fix escaped HTML in table headers ...................................................................... webadmin,userportal: Fix escaped HTML in table headers Table headers with HTML content no longer have their content escaped, e.g. Network / Hosts sub tab no longer has columns like "Speed <sub>(Mbps)</sub>", but just "Speed (Mbps)". Change-Id: I6b636084ed04af1295084579fd1ab4102445fc79 Bug-Url: https://bugzilla.redhat.com/1259826 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48438 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b636084ed04af1295084579fd1ab4102445fc79 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: lowering priority of thaw and freeze failure events
by tnisan＠redhat.com 25 Nov '15

25 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: lowering priority of thaw and freeze failure events ...................................................................... core: lowering priority of thaw and freeze failure events Lowering the priority to Warning of thaw/freeze audit log. Change-Id: If07b64d2f35c2d4800ba69d07fa5cb1eb1e06efb Bug-Url: https://bugzilla.redhat.com/1282796 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/49165 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If07b64d2f35c2d4800ba69d07fa5cb1eb1e06efb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: correct AuditLogType on ThawVmCommand
by tnisan＠redhat.com 25 Nov '15

25 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: correct AuditLogType on ThawVmCommand ...................................................................... core: correct AuditLogType on ThawVmCommand Corrected the AuditLogType on ThawVm failure (the command could be invoked only form rest-api). Related to BZ#1282796. Change-Id: I590279c4ce13372efbd0fc89b61b30176b8d6fbf Bug-Url: https://bugzilla.redhat.com/1282796 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ThawVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/49164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I590279c4ce13372efbd0fc89b61b30176b8d6fbf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: upgrade: avoid upgrading if not in maintenance from the engine
by sbonazzo＠redhat.com 25 Nov '15

25 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: upgrade: avoid upgrading if not in maintenance from the engine ...................................................................... upgrade: avoid upgrading if not in maintenance from the engine Avoid upgrading if not in maintenance from the engine perspective, since we cannot directly query the engine we can infer it checking for other VMs and for other SPs. Change-Id: I3a9ad13815f71793e88ef2ece676b2e871dd30dd Bug-Url: https://bugzilla.redhat.com/1277646 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 45 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a9ad13815f71793e88ef2ece676b2e871dd30dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Optimize equals/hashCode in gluster classes
by mperina＠redhat.com 25 Nov '15

25 Nov '15

Martin Peřina has submitted this change and it was merged. Change subject: core: Optimize equals/hashCode in gluster classes ...................................................................... core: Optimize equals/hashCode in gluster classes 1. Optimizes equals method to contain recommended functionality as described in Effective Java 2nd edition 2. Optimizes objects comparison in equals method to use Objects.equals() 3. Optimizes hashCode method to use Objects.hash()/hashCode() methods Change-Id: Ic5f7909fde498969d2c5b96d5ceb058253fa28f1 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTask.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickProfileDetails.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionConfiguration.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServer.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerHook.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerService.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterService.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterSnapshotConfigInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeOptionEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeOptionInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeProfileInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeProfileStats.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSizeInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotConfig.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotSchedule.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StorageDevice.java 24 files changed, 442 insertions(+), 584 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48838 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5f7909fde498969d2c5b96d5ceb058253fa28f1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove redundant init method from IsoDomainListSyncron...
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: remove redundant init method from IsoDomainListSyncronizer ...................................................................... core: remove redundant init method from IsoDomainListSyncronizer Change-Id: I88a39239a2105480633f86730aaf1b715a1be180 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved; Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/49157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88a39239a2105480633f86730aaf1b715a1be180 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: correct AuditLogType on ThawVmCommand
by derez＠redhat.com 25 Nov '15

25 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: core: correct AuditLogType on ThawVmCommand ...................................................................... core: correct AuditLogType on ThawVmCommand Corrected the AuditLogType on ThawVm failure (the command could be invoked only form rest-api). Related to BZ#1282796. Change-Id: I590279c4ce13372efbd0fc89b61b30176b8d6fbf Bug-Url: https://bugzilla.redhat.com/1282796 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ThawVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49116 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I590279c4ce13372efbd0fc89b61b30176b8d6fbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: lowering priority of thaw and freeze failure events
by derez＠redhat.com 25 Nov '15

25 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: core: lowering priority of thaw and freeze failure events ...................................................................... core: lowering priority of thaw and freeze failure events Lowering the priority to Warning of thaw/freeze audit log. Change-Id: If07b64d2f35c2d4800ba69d07fa5cb1eb1e06efb Bug-Url: https://bugzilla.redhat.com/1282796 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If07b64d2f35c2d4800ba69d07fa5cb1eb1e06efb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Rename cpu-type IBM POWER 8
by tnisan＠redhat.com 25 Nov '15

25 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Rename cpu-type IBM POWER 8 ...................................................................... engine: Rename cpu-type IBM POWER 8 Cpu name IBM POWER 8 is changed to IBM POWER8. To maintain backwards compatibility, the API will accept both. Change-Id: Ib82590d829b577fc6612b73b1de279109edaf9c1 Bug-Url: https://bugzilla.redhat.com/1248867 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java A packaging/dbscripts/upgrade/03_06_1930_change_cpu_name_ibm_power_8.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 25 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Ori Liel: Verified -- To view, visit https://gerrit.ovirt.org/48255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib82590d829b577fc6612b73b1de279109edaf9c1 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: upgrade: avoid upgrading if not in maintenance from the engine
by msivak＠redhat.com 25 Nov '15

25 Nov '15

Martin Sivák has submitted this change and it was merged. Change subject: upgrade: avoid upgrading if not in maintenance from the engine ...................................................................... upgrade: avoid upgrading if not in maintenance from the engine Avoid upgrading if not in maintenance from the engine perspective, since we cannot directly query the engine we can infer it checking for other VMs and for other SPs. Change-Id: I3a9ad13815f71793e88ef2ece676b2e871dd30dd Bug-Url: https://bugzilla.redhat.com/1277646 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 45 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a9ad13815f71793e88ef2ece676b2e871dd30dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0