November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: add integer to IPv4 format converter
by alkaplan＠redhat.com 25 Nov '15

25 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: add integer to IPv4 format converter ...................................................................... engine: add integer to IPv4 format converter The functionality needed to be implemented as GWT doesn't support INetAddress Change-Id: I57fb8105cbc5208ecac0652f0c2f7e678fe01ffa Bug-Url: https://bugzilla.redhat.com/1269481 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IPAddressConverter.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IPv4AddressConverter.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IpAddressConverter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/CidrValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/MaskValidator.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IPv4AddressConverterTest.java D backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IpAddressConverterTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 8 files changed, 139 insertions(+), 82 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57fb8105cbc5208ecac0652f0c2f7e678fe01ffa Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Inroduce DetachNetworkUsedByVmValidator
by alkaplan＠redhat.com 25 Nov '15

25 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Inroduce DetachNetworkUsedByVmValidator ...................................................................... engine: Inroduce DetachNetworkUsedByVmValidator The Validator is creating a validation result according to the given numbers of vms and networks. Change-Id: I90fab7507525cba000f7e2af4d82c45845ebbaa7 Bug-Url: https://bugzilla.redhat.com/1216896 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/DetachNetworkUsedByVmValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/DetachNetworkUsedByVmValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 141 insertions(+), 4 deletions(-) Approvals: Eliraz Levi: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90fab7507525cba000f7e2af4d82c45845ebbaa7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Frontend: ConsoleUserName & ClientIP update regression fix
by tjelinek＠redhat.com 25 Nov '15

25 Nov '15

Tomas Jelinek has submitted this change and it was merged. Change subject: Frontend: ConsoleUserName & ClientIP update regression fix ...................................................................... Frontend: ConsoleUserName & ClientIP update regression fix Due to comparison of the same variable which never can be false, the values for the ConsoleUserName and ClientIP fields for console users was not updated. This patch fixes this regression which was introduced in the refactoring of the sessions tab into the guest info tab. Change-Id: Ibb13bd4e9e8a77ee606520133c681464ac119ba5 Bug-Url: https://bugzilla.redhat.com/1272978 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified -- To view, visit https://gerrit.ovirt.org/49103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb13bd4e9e8a77ee606520133c681464ac119ba5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Optimize equals/hashCode in network classes
by mperina＠redhat.com 25 Nov '15

25 Nov '15

Martin Peřina has submitted this change and it was merged. Change subject: core: Optimize equals/hashCode in network classes ...................................................................... core: Optimize equals/hashCode in network classes 1. Optimizes equals method to contain recommended functionality as described in Effective Java 2nd edition 2. Optimizes objects comparison in equals method to use Objects.equals() 3. Optimizes hashCode method to use Objects.hash()/hashCode() methods Change-Id: I9a29cdfa7984c681effa480156a8f75f3228675b Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacPool.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacRange.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Provider.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TenantProviderProperties.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmGuestAgentInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Bond.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ExternalSubnet.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNetworkQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNicVfsConfig.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/IPv4Address.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/IpConfiguration.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkCluster.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkClusterId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkQoS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkView.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NicLabel.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ProviderNetwork.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ReportedConfiguration.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfile.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfileView.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/pseudo/NetworkLabel.java 30 files changed, 463 insertions(+), 1,018 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a29cdfa7984c681effa480156a8f75f3228675b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Foreman integration: Remove 'nested' attribute from paramete...
by oourfali＠redhat.com 25 Nov '15

25 Nov '15

Oved Ourfali has submitted this change and it was merged. Change subject: Foreman integration: Remove 'nested' attribute from parameters dict ...................................................................... Foreman integration: Remove 'nested' attribute from parameters dict Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1283215 Issue-Url: http://projects.theforeman.org/issues/12516 Change-Id: I7257eeff9c887d33a9fe8cbab1a4aef6e970218d Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7257eeff9c887d33a9fe8cbab1a4aef6e970218d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use pagination when querying errata
by oourfali＠redhat.com 25 Nov '15

25 Nov '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Use pagination when querying errata ...................................................................... engine: Use pagination when querying errata Satellite 6.1 limits page size for 20 errata per page. This limit is too small to retrieve therefore specifying a larger amount of errata to get. Katello 2.1 doesn't support pagination, therefore using pagination in request is ignored. Change-Id: Icde94303cb7177ce2f09a784a5f8c105e1bd0885 Bug-Url: https://bugzilla.redhat.com/1284060 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49018 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icde94303cb7177ce2f09a784a5f8c105e1bd0885 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Optimize equals/hashCode in storage classes
by mperina＠redhat.com 25 Nov '15

25 Nov '15

Martin Peřina has submitted this change and it was merged. Change subject: core: Optimize equals/hashCode in storage classes ...................................................................... core: Optimize equals/hashCode in storage classes 1. Optimizes equals method to contain recommended functionality as described in Effective Java 2nd edition 2. Optimizes objects comparison in equals method to use Objects.equals() 3. Optimizes hashCode method to use Objects.hash()/hashCode() methods Change-Id: I267f21b60cc99089b3cdfc9c1e27b061d11339bf Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainOvfInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePoolIsoMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePoolIsoMapId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderConnectionInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskImage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskImageDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskLunMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskLunMapId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Image.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/ImageStorageDomainMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/ImageStorageDomainMapId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LUNStorageServerConnectionMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LUNs.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LibvirtSecret.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LunDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/OpenStackVolumeProviderProperties.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/StorageServerConnectionExtension.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vds_spm_id_map.java 27 files changed, 350 insertions(+), 415 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I267f21b60cc99089b3cdfc9c1e27b061d11339bf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Updated junit to fix race condition
by sabose＠redhat.com 25 Nov '15

25 Nov '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Updated junit to fix race condition ...................................................................... engine: Updated junit to fix race condition The assertion of previous fire time fails occasionally due to the timing of threads Changed the assertion to a predictable one. Change-Id: I07f7573b4eff025339972d579a1d5399bb06f04a Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImplTest.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07f7573b4eff025339972d579a1d5399bb06f04a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused VdsCommandsHelper
by masayag＠redhat.com 24 Nov '15

24 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove unused VdsCommandsHelper ...................................................................... core: Remove unused VdsCommandsHelper Change-Id: I75df23ed0bd83a4b7bc65d990b3b5c9e6c8337cb Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VdsCommandsHelper.java 1 file changed, 0 insertions(+), 111 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Martin Betak: Verified Moti Asayag: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75df23ed0bd83a4b7bc65d990b3b5c9e6c8337cb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine, webadmin: Add source_ip to the sessions table
by masayag＠redhat.com 24 Nov '15

24 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: engine, webadmin: Add source_ip to the sessions table ...................................................................... engine, webadmin: Add source_ip to the sessions table Add source ip to session table and show the information in active sessions tab Change-Id: I878d56daa55bcdeaa78de2457fb182b7c2a6ca73 Bug-Url: https://bugzilla.redhat.com/1197449 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SSOUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateUserSessionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineSession.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UserSession.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineSessionDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabSessionView.java M packaging/dbscripts/engine_sessions_sp.sql A packaging/dbscripts/upgrade/04_00_0030_add_source_ip_column_to_engine_sessions.sql 13 files changed, 63 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Moti Asayag: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I878d56daa55bcdeaa78de2457fb182b7c2a6ca73 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0