November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: backend: Reduce number of calls to ResourceManager#getInstan...
by mperina＠redhat.com 13 Nov '15

13 Nov '15

Martin Peřina has submitted this change and it was merged. Change subject: backend: Reduce number of calls to ResourceManager#getInstance() ...................................................................... backend: Reduce number of calls to ResourceManager#getInstance() Used injection wherever possible without big architectural changes. Change-Id: I01480c12c8d44a600aecd85e3b59ab5a4a0a5b97 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshHostCapabilitiesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/AddVdsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/IsVmDuringInitiatingVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RemoveVdsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetIsoListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/HttpImageTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ResetIrsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMClearTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetAllTasksInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetAllTasksStatusesVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMRevertTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMStopTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SpmStopOnIrsVDSCommand.java 22 files changed, 68 insertions(+), 56 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Roy Golan: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01480c12c8d44a600aecd85e3b59ab5a4a0a5b97 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: use java 8 Stream in AddDiskCommand.getLunDisk
by amureini＠redhat.com 12 Nov '15

12 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: backend: use java 8 Stream in AddDiskCommand.getLunDisk ...................................................................... backend: use java 8 Stream in AddDiskCommand.getLunDisk Change-Id: I1accf2228c5bcbb45a5542ed6041cd066008d5ed Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 2 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1accf2228c5bcbb45a5542ed6041cd066008d5ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CalculateStorageUsage psql function refactoring.
by amureini＠redhat.com 12 Nov '15

12 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: CalculateStorageUsage psql function refactoring. ...................................................................... core: CalculateStorageUsage psql function refactoring. CalculateStorageUsage psql function was joining tables that were already joined by images_storage_domain_view, also- executed almost the same query twice- while it could be consolidated into one query by adding a simple condition. This patch changes the query to select only from images_storage_domain_view, and consolidating the two queries. Change-Id: I3997cb4f310ca8ebaf8d36f9ffae1d126fa7de00 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M packaging/dbscripts/create_functions.sql 1 file changed, 9 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Passed CI tests Amit Aviram: Verified Allon Mureinik: Looks good to me, approved Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3997cb4f310ca8ebaf8d36f9ffae1d126fa7de00 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: backend: call GetDeviceList when specifying host in AddDiskC...
by tnisan＠redhat.com 12 Nov '15

12 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: backend: call GetDeviceList when specifying host in AddDiskCommand ...................................................................... backend: call GetDeviceList when specifying host in AddDiskCommand When creating a direct lun, if the host id is passed through the parameters to AddDiskCommand, GetDeviceList will be called to get the lun from vdsm. This way, passing the host id will cause AddDiskCommand to store the up to date details of the lun in the db. Change-Id: I27c3b6ba5699e259ede693bf48717687cff3eecb Bug-Url: https://bugzilla.redhat.com/1275649 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java 4 files changed, 75 insertions(+), 74 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27c3b6ba5699e259ede693bf48717687cff3eecb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: improve hibernation volumes to disks
by ahadas＠redhat.com 12 Nov '15

12 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: core: improve hibernation volumes to disks ...................................................................... core: improve hibernation volumes to disks Previously when restoring hibernated VM the memory_volume field in the snapshots table was cleared, leaving memory_dump_disk_id and memory_metadata_disk_id were cleared when the disks were removed. However, we should clear them as well since the remove disk might fail and we don't want the active snapshot to keep pointing at them in this case. Change-Id: I2018cc295a3aec3a8b9e9fe60a3b85e6bc862cf0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/snapshots_sp.sql 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2018cc295a3aec3a8b9e9fe60a3b85e6bc862cf0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Fixed type with the cleanup
by dcaro＠redhat.com 12 Nov '15

12 Nov '15

David Caro has submitted this change and it was merged. Change subject: Fixed type with the cleanup ...................................................................... Fixed type with the cleanup It was using a different var name and trying to umount all the mounted dirs Change-Id: I8d2ec096f3ac0ee458e5731aa1b019d5d878267e Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/mock_cleanup.sh 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Sagi Shnaidman: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/48487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d2ec096f3ac0ee458e5731aa1b019d5d878267e Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: Use Java 8 Lambdas in GetClusterEditWarningsQuery
by shavivi＠redhat.com 12 Nov '15

12 Nov '15

Shahar Havivi has submitted this change and it was merged. Change subject: backend: Use Java 8 Lambdas in GetClusterEditWarningsQuery ...................................................................... backend: Use Java 8 Lambdas in GetClusterEditWarningsQuery Small cleanup using new language features. Change-Id: I9ce0ebb536239a94c76ca89e812fa53bfea8717b Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterEditWarningsQuery.java 1 file changed, 16 insertions(+), 35 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ce0ebb536239a94c76ca89e812fa53bfea8717b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add stream methods to the model
by juan.hernandez＠redhat.com 12 Nov '15

12 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add stream methods to the model ...................................................................... restapi: Add stream methods to the model The model classes have methods that return lists. For example, the "StructType" class has a "getAttributes" method that returns its list of attributes. To avoid issues these lists are copies of the ones used internally. This patch changes the model classes so that they also have methods that returns streams, as those are nicer in Java 8 and no copy of the elements of the lists is required. Change-Id: I975cd02b9771665fb07c8c161bf814ea2dbe9258 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/metamodel/analyzer/src/main/java/org/ovirt/api/metamodel/analyzer/ModelAnalyzer.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Attribute.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Concept.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/EnumType.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/EnumValue.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Link.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Locator.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Method.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Model.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Service.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/StructType.java 11 files changed, 424 insertions(+), 87 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I975cd02b9771665fb07c8c161bf814ea2dbe9258 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in gerrit-admin[master]: Fixed set_MODIFIED hook
by dcaro＠redhat.com 12 Nov '15

12 Nov '15

David Caro has submitted this change and it was merged. Change subject: Fixed set_MODIFIED hook ...................................................................... Fixed set_MODIFIED hook Now it uses the classification field instead of the product Change-Id: Ie0fb9f8103fb95aa76aa7ded78719d3d6df2d61c Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/custom_hooks/change-merged.set_MODIFIED 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0fb9f8103fb95aa76aa7ded78719d3d6df2d61c Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: unregister libvirt secrets on host disconnect
by tnisan＠redhat.com 12 Nov '15

12 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: unregister libvirt secrets on host disconnect ...................................................................... core: unregister libvirt secrets on host disconnect On 36324ffa6576c3641358f5ef52015fb1bc532cb2, secrets unregistration logic was removed from DisconnectHostFromStoragePoolServersCommand based on the assumption that a storage_server_connection should exist for all storage domains. However, no connection is created for Cinder domains, hence, unregistration should be invoked directly. [similar to https://gerrit.ovirt.org/#/c/47924/] Change-Id: Ibfecbc326c6787ecdf8f72abf4997c1821ad62bf Bug-Url: https://bugzilla.redhat.com/1279499 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RegisterLibvirtSecretsVDSParameters.java 3 files changed, 15 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfecbc326c6787ecdf8f72abf4997c1821ad62bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0