November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: OvfParser member modifiers
by amureini＠redhat.com 12 Nov '15

12 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfParser member modifiers ...................................................................... core: OvfParser member modifiers Stop needlessly exposing internal members as protected. Change-Id: I883f4e216f117a1f38860016f509e1d69bd408d7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfParser.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47280 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I883f4e216f117a1f38860016f509e1d69bd408d7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: OvfParser method naming conventions
by amureini＠redhat.com 12 Nov '15

12 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfParser method naming conventions ...................................................................... core: OvfParser method naming conventions Change-Id: Iee3ee1b48f90b9443416649a40a933e70647b194 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfParser.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfParserTest.java 9 files changed, 30 insertions(+), 30 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47279 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee3ee1b48f90b9443416649a40a933e70647b194 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: OvfParserTest formatting
by amureini＠redhat.com 12 Nov '15

12 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfParserTest formatting ...................................................................... core: OvfParserTest formatting Removed useless line break in the test. Change-Id: I69dfe2a4fbe659db2d4343fec2de8568fb377e58 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfParserTest.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69dfe2a4fbe659db2d4343fec2de8568fb377e58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: remove UtcDateStringToLocaDateMultiThread
by amureini＠redhat.com 12 Nov '15

12 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: remove UtcDateStringToLocaDateMultiThread ...................................................................... core: remove UtcDateStringToLocaDateMultiThread Removed the useless OvfParserTest#UtcDateStringToLocaDateMultiThread method. This method tests OvfParser#UtcDateStringToLocaDate, which is a static, stateless method. Hence, it's deterministic, and there's no added value to send the same arguments multiple times, be it concurrently or serially. Change-Id: I185c442af9e0eb5499f18786697f3f45e123cbc8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfParserTest.java 1 file changed, 0 insertions(+), 47 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I185c442af9e0eb5499f18786697f3f45e123cbc8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: AddVmCommandTest modifiers
by amureini＠redhat.com 12 Nov '15

12 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommandTest modifiers ...................................................................... core: AddVmCommandTest modifiers Fixed member modifiers as per Java best practices. Change-Id: Ia970f21d3881146e2cdf78e9a39ae09c873a50b8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia970f21d3881146e2cdf78e9a39ae09c873a50b8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: XmlTextWriter methods' naming conventions
by amureini＠redhat.com 12 Nov '15

12 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: XmlTextWriter methods' naming conventions ...................................................................... core: XmlTextWriter methods' naming conventions Change-Id: I46df2380b560f2e9e2269b5e75c7177654821212 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlTextWriter.java 4 files changed, 669 insertions(+), 669 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46df2380b560f2e9e2269b5e75c7177654821212 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: XmlNode methods' naming convention
by amureini＠redhat.com 12 Nov '15

12 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: XmlNode methods' naming convention ...................................................................... core: XmlNode methods' naming convention Change-Id: I41c3e51cda21da562b97f720e93b459a8975c905 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlNode.java 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41c3e51cda21da562b97f720e93b459a8975c905 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: XmlDocument methods' naming convention
by amureini＠redhat.com 12 Nov '15

12 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: XmlDocument methods' naming convention ...................................................................... core: XmlDocument methods' naming convention Change-Id: I17e28c15f695cb03a8603804ed7d11922b093f57 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfParser.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlDocument.java 4 files changed, 13 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17e28c15f695cb03a8603804ed7d11922b093f57 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: OvfVmReader methods' naming conventions
by amureini＠redhat.com 12 Nov '15

12 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfVmReader methods' naming conventions ...................................................................... core: OvfVmReader methods' naming conventions Change-Id: Id0cb4b3b3d7047029f64c90515bf4e1d41d8b0b7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0cb4b3b3d7047029f64c90515bf4e1d41d8b0b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Sort OvfProperties' modifiers
by amureini＠redhat.com 12 Nov '15

12 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Sort OvfProperties' modifiers ...................................................................... core: Sort OvfProperties' modifiers Change-Id: Ie8f7329b21eef3141babfc42416e36759278f1c1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java 1 file changed, 76 insertions(+), 76 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8f7329b21eef3141babfc42416e36759278f1c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0