November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: bll: AddUserProfileCommand fix NPE when empty sshkey
by ahadas＠redhat.com 11 Nov '15

11 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: bll: AddUserProfileCommand fix NPE when empty sshkey ...................................................................... bll: AddUserProfileCommand fix NPE when empty sshkey When user insert empty public key and hit OK, engine fail on NPE Change-Id: Ia19140f2ddbbf31d5c6770f8f4b1fe9dd8b66463 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserProfileCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia19140f2ddbbf31d5c6770f8f4b1fe9dd8b66463 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-host-deploy[master]: vmconsole: automatic start of ovirt-vmconsole-host-sshd
by Alon Bar-Lev 11 Nov '15

11 Nov '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: vmconsole: automatic start of ovirt-vmconsole-host-sshd ...................................................................... vmconsole: automatic start of ovirt-vmconsole-host-sshd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1279434 Change-Id: I7536380f063cb8e3ab6d0a204f6515aa96a66b96 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vmconsole/packages.py 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48436 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7536380f063cb8e3ab6d0a204f6515aa96a66b96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: send custom properties for VFs
by alkaplan＠redhat.com 11 Nov '15

11 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: send custom properties for VFs ...................................................................... engine: send custom properties for VFs Change-Id: I886b8beea6437ed09dc5a8e6c76be63c3eb83fcb Bug-Url: https://bugzilla.redhat.com/1279775 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I886b8beea6437ed09dc5a8e6c76be63c3eb83fcb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-release[master]: epel7: allow ovirt-guest-agent sub packages
by sbonazzo＠redhat.com 11 Nov '15

11 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: epel7: allow ovirt-guest-agent sub packages ...................................................................... epel7: allow ovirt-guest-agent sub packages Change-Id: Ibe0151542dc494874449e6ec4322efd86b77099b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-3.6/configure.ac M ovirt-release-3.6/ovirt-el7-deps.repo.in M ovirt-release-3.6/ovirt-release36.spec.in M ovirt-release-master/configure.ac M ovirt-release-master/ovirt-el7-deps.repo.in M ovirt-release-master/ovirt-release-master.spec.in 6 files changed, 12 insertions(+), 6 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe0151542dc494874449e6ec4322efd86b77099b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: null checks when calling DiskImageDaoImpl.getAncest...
by tnisan＠redhat.com 11 Nov '15

11 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: backend: null checks when calling DiskImageDaoImpl.getAncestor(id) ...................................................................... backend: null checks when calling DiskImageDaoImpl.getAncestor(id) Calling to DiskImageDaoImpl.getAncestor(Guid id) never returns null (see DiskImageDaoTest.testGetAncestorForFather). Thus, it's useless to check whether its return value is null each time we call it. Change-Id: I7f2acc136330c504c20034d9fdc24854546e3801 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 2 files changed, 1 insertion(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/47992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f2acc136330c504c20034d9fdc24854546e3801 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Removing also the /var/lib/mock on cleanup
by dcaro＠redhat.com 11 Nov '15

11 Nov '15

David Caro has submitted this change and it was merged. Change subject: Removing also the /var/lib/mock on cleanup ...................................................................... Removing also the /var/lib/mock on cleanup We were removing the /var/cache/mock one, but missed the one in $subject. Also it has to be handled carefully, as mounts might still exist inside the chroots, so try umounting first Change-Id: I8193778d544af7dbeaf90cc28a7763ef9c0ad0e5 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/mock_cleanup.sh 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Sagi Shnaidman: Looks good to me Sandro Bonazzola: Looks good to me; Ready for merge Jenkins CI: Passed CI tests David Caro: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/48377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8193778d544af7dbeaf90cc28a7763ef9c0ad0e5 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: v2v is not handling 32bit vms
by tnisan＠redhat.com 11 Nov '15

11 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: v2v is not handling 32bit vms ...................................................................... engine: v2v is not handling 32bit vms Change-Id: I3cae7a8c1b7178c2094a7451d1cd1320c1c9f368 Bug-Url: https://bugzilla.redhat.com/1277452 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Shahar Havivi: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cae7a8c1b7178c2094a7451d1cd1320c1c9f368 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: NPE in GLUSTERFSStorageHelper
by tnisan＠redhat.com 11 Nov '15

11 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: NPE in GLUSTERFSStorageHelper ...................................................................... engine: NPE in GLUSTERFSStorageHelper Fixing the ConnectHostToStoragePoolServersParameters constructor, to include 'StoragePool'. In the flow of refreshing storage connections and pool metada due to Vdsm reports, the ConnectHostToStoragePoolServersParameters constructor was used without 'StoragePool'. Several classes like CINDERStorageHelper and GLUSTERFSStorageHelper are expecting the parameter to have a StoragePool populated. Change-Id: I3b80bcc9606677912e88dc265d36c8c9f8ba8138 Bug-Url: https://bugzilla.redhat.com/1277570 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ConnectHostToStoragePoolServersParameters.java 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/48378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b80bcc9606677912e88dc265d36c8c9f8ba8138 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: vdsbroker: Remove workaround for JBoss 7 bug in ResourceManager
by mperina＠redhat.com 11 Nov '15

11 Nov '15

Martin Peřina has submitted this change and it was merged. Change subject: vdsbroker: Remove workaround for JBoss 7 bug in ResourceManager ...................................................................... vdsbroker: Remove workaround for JBoss 7 bug in ResourceManager Change-Id: I5c9b3e3d305eb28ecb12756a47c1827043ed174c Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 1 file changed, 5 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c9b3e3d305eb28ecb12756a47c1827043ed174c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Added sleep after postgresql service start in engine upgrade...
by eedri＠redhat.com 11 Nov '15

11 Nov '15

Eyal Edri has submitted this change and it was merged. Change subject: Added sleep after postgresql service start in engine upgrade jobs ...................................................................... Added sleep after postgresql service start in engine upgrade jobs Change-Id: Ib259b59db478fb49d0fea77309149108b724d22b Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/ovirt-engine_upgrade_to_3.5/upgrade.sh M jobs/ovirt-engine_upgrade_to_3.6/upgrade.sh M jobs/ovirt-engine_upgrade_to_master/upgrade.sh 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Sharon Naftaly: Verified; Ready for review Eyal Edri: Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/48355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib259b59db478fb49d0fea77309149108b724d22b Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0