November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: extapi: extmap: do not cast to default type class
by tnisan＠redhat.com 11 Nov '15

11 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: extapi: extmap: do not cast to default type class ...................................................................... extapi: extmap: do not cast to default type class default type can be different subclass of the spec type and may cause casting exception. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1279589 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1280246 Change-Id: Id6a07149189a9316acc1985b2cc496a439efccfe Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuthzGroupsByUserIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableNamespacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java 5 files changed, 13 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified Ondra Machacek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48422 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6a07149189a9316acc1985b2cc496a439efccfe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: pki: acquiring certs from pki-resource servlet
by sbonazzo＠redhat.com 11 Nov '15

11 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: pki: acquiring certs from pki-resource servlet ...................................................................... pki: acquiring certs from pki-resource servlet In the past CA cert was available at http://{fqdn}/ca.crt but now the engine responds 404. - Moving to pki-resource servlet. - Showing CA info to the user - Downloading engine SSH pubkey via trusted https - Better check of SSH pubkey duplicates Change-Id: Ia4b5e8ffdc598afaacadd5c4ba8952659efdaa98 Bug-Url: https://bugzilla.redhat.com/1256467 Bug-Url: https://bugzilla.redhat.com/1059952 Bug-Url: https://bugzilla.redhat.com/1254838 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/Makefile.am M src/ovirt_hosted_engine_setup/constants.py A src/ovirt_hosted_engine_setup/ohttpshandler.py A src/ovirt_hosted_engine_setup/pkissh.py M src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 6 files changed, 524 insertions(+), 85 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4b5e8ffdc598afaacadd5c4ba8952659efdaa98 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Refactoring numa node dao classes
by rgolan＠redhat.com 11 Nov '15

11 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: engine: Refactoring numa node dao classes ...................................................................... engine: Refactoring numa node dao classes Created interafce NumaNodeDao and abstract class NumaNodeDaoImpl, so VmNumaNodeDaoImpl does not extend VdsNumaNodeDaoImpl. It is now possible to inject them using type resolution only. Change-Id: I614ea5757080cdbbd02b8923cbcdd327dd0c54a6 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NumaNodeDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NumaNodeDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDaoTest.java 10 files changed, 212 insertions(+), 190 deletions(-) Approvals: Roy Golan: Looks good to me, approved; Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/47989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I614ea5757080cdbbd02b8923cbcdd327dd0c54a6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: unregister libvirt secrets on host disconnect
by derez＠redhat.com 11 Nov '15

11 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: core: unregister libvirt secrets on host disconnect ...................................................................... core: unregister libvirt secrets on host disconnect On 36324ffa6576c3641358f5ef52015fb1bc532cb2, secrets unregistration logic was removed from DisconnectHostFromStoragePoolServersCommand based on the assumption that a storage_server_connection should exist for all storage domains. However, no connection is created for Cinder domains, hence, unregistration should be invoked directly. [similar to https://gerrit.ovirt.org/#/c/47924/] Change-Id: Ibfecbc326c6787ecdf8f72abf4997c1821ad62bf Bug-Url: https://bugzilla.redhat.com/1279499 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RegisterLibvirtSecretsVDSParameters.java 3 files changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfecbc326c6787ecdf8f72abf4997c1821ad62bf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: new host-> Use Foreman/Satellite
by awels＠redhat.com 11 Nov '15

11 Nov '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: new host-> Use Foreman/Satellite ...................................................................... webadmin: new host-> Use Foreman/Satellite - Fixed clearing only name/address when unselecting Use Foreman/Satellite - Fixed alignment on Provisioned Hosts label - Fixed exception when switching between Discovered/Provisioned hosts. - When checking Use Foreman/Satellite select Discovered Hosts by default. Change-Id: I2d41680ccc7d360ee3567bfe82cb78313cfc6979 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1229743 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 3 files changed, 11 insertions(+), 11 deletions(-) Approvals: Alexander Wels: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d41680ccc7d360ee3567bfe82cb78313cfc6979 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix parameter type in ThreadUtils.sleep()
by masayag＠redhat.com 11 Nov '15

11 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix parameter type in ThreadUtils.sleep() ...................................................................... core: Fix parameter type in ThreadUtils.sleep() Changes parameter type from int to long to avoid unnecessary typecasts. Change-Id: I870c2b37ba7c818fca113dfafdf12bd5083db92b Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceProxyLocator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsKdumpDetectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ThreadUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStartVDSCommand.java 7 files changed, 8 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I870c2b37ba7c818fca113dfafdf12bd5083db92b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Restart hosted engine services after crash
by msivak＠redhat.com 11 Nov '15

11 Nov '15

Martin Sivák has submitted this change and it was merged. Change subject: Restart hosted engine services after crash ...................................................................... Restart hosted engine services after crash Change-Id: I174bd1ab900095185694bdd280991ff30354baca Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1030441 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit e9886e87f3506316107965abcb561797106c34ae) --- M initscripts/ovirt-ha-agent.service M initscripts/ovirt-ha-broker.service 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I174bd1ab900095185694bdd280991ff30354baca Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: when starting Live Merge, check for NOT_STARTED child ...
by tnisan＠redhat.com 11 Nov '15

11 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: when starting Live Merge, check for NOT_STARTED child commands ...................................................................... core: when starting Live Merge, check for NOT_STARTED child commands When a Live Merge is started, the RemoveSnapshotCommandCallback does not look for child commands with the NOT_STARTED command status. This causes a race where the child commands may not be detected properly by the parent, causing the actual merge process to be skipped. This adds the needed check to the command callback, eliminating the race condition and ensuring the merge will occur. Change-Id: If47d26d8bedaf0bb4a39cae472533399178b4fdd Bug-Url: https://bugzilla.redhat.com/1280160 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48427 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If47d26d8bedaf0bb4a39cae472533399178b4fdd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: Inject dependencies of AutoStartVmsRunner
by ahadas＠redhat.com 11 Nov '15

11 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: backend: Inject dependencies of AutoStartVmsRunner ...................................................................... backend: Inject dependencies of AutoStartVmsRunner Replaced static factories/lookups with injection. Change-Id: I4b9fa3620b57d86e8d91b1dd8c8417d6ed7262b7 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java 1 file changed, 35 insertions(+), 22 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48349 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b9fa3620b57d86e8d91b1dd8c8417d6ed7262b7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.4]: vmconsole: automatic start of ovirt-vmconsole-host-sshd
by Alon Bar-Lev 11 Nov '15

11 Nov '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: vmconsole: automatic start of ovirt-vmconsole-host-sshd ...................................................................... vmconsole: automatic start of ovirt-vmconsole-host-sshd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1279434 Change-Id: I7536380f063cb8e3ab6d0a204f6515aa96a66b96 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vmconsole/packages.py 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7536380f063cb8e3ab6d0a204f6515aa96a66b96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0