February 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: use failCanDoAction instead return false
by mlipchuk＠redhat.com 22 Feb '15

22 Feb '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: use failCanDoAction instead return false ...................................................................... core: use failCanDoAction instead return false Use the existing failCanDoAction on RemoveStorageDomain instead the existing return false Change-Id: Ief84a89341c6cda7bdea858849b40529d1adfb4f Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/37986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief84a89341c6cda7bdea858849b40529d1adfb4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Validate if Storage is attached before format.
by mlipchuk＠redhat.com 22 Feb '15

22 Feb '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate if Storage is attached before format. ...................................................................... core: Validate if Storage is attached before format. Add validation to check if the Storage Domain is attached to a Data Center before formatting it. Also adding a new CDA which indicates how the user should work around it. Change-Id: I327705b1bb333e9b27ea8e67057966a7b62d8efc Bug-Url: https://bugzilla.redhat.com/1179899 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 42 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I327705b1bb333e9b27ea8e67057966a7b62d8efc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: reformat views code using pgformatter
by oourfali＠redhat.com 22 Feb '15

22 Feb '15

Oved Ourfali has submitted this change and it was merged. Change subject: db: reformat views code using pgformatter ...................................................................... db: reformat views code using pgformatter Currently it is hard to review changes made in DB scripts The reason is lack of general formatting. For example, in views, there are many columns in the same row and when a column is added it is hard to track the change. That may lead to some problems and regressions after the changed code is merged. The following uses a opensource tool named pgFormatter http://sourceforge.net/projects/pgformatter/ to make our code more readable and friendly for reviews. Currently only engine and dwh views were changed Change-Id: I8c127f152c73f08ac8d7d6f9448d010235e9d3d2 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/create_dwh_views.sql M packaging/dbscripts/create_views.sql 2 files changed, 3,687 insertions(+), 2,273 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c127f152c73f08ac8d7d6f9448d010235e9d3d2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Upgrade message in general tab is missing
by oourfali＠redhat.com 22 Feb '15

22 Feb '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Upgrade message in general tab is missing ...................................................................... core: Upgrade message in general tab is missing lert should distinguish if the host is already in maintenance or not. If the host is not in maintenance it should display : "A new version is available; an upgrade option will appear once the Host is moved to maintenance mode." If the host is in maintenance it should display : "If you wish to upgrade or reinstall it click here." Change-Id: I5af3adca237609dfa696828caa39919c7e4da82b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1186196 Signed-off-by: emesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java 2 files changed, 10 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5af3adca237609dfa696828caa39919c7e4da82b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fixed coverity defects
by oourfali＠redhat.com 22 Feb '15

22 Feb '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fixed coverity defects ...................................................................... core: Fixed coverity defects Fixed several coverity defects including Null value deferencing and resource closing Change-Id: Ifc167e677ba5e365f55bce92c0012caf216972c2 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/kerberos/KrbConfCreator.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/FileUtilTest.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/db/ConfigDaoImpl.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java 6 files changed, 46 insertions(+), 77 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc167e677ba5e365f55bce92c0012caf216972c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: spec: increase release
by dougsland＠redhat.com 21 Feb '15

21 Feb '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: increase release ...................................................................... spec: increase release Change-Id: I687b2c572d76171fcb225bc39e502e653015c279 added: engine_page: Replace deployUtil._logExec (BZ#1192160) Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M configure.ac M ovirt-node-plugin-vdsm.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/38016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I687b2c572d76171fcb225bc39e502e653015c279 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: engine_page: Replace deployUtil._logExec
by dougsland＠redhat.com 21 Feb '15

21 Feb '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: Replace deployUtil._logExec ...................................................................... engine_page: Replace deployUtil._logExec Replacing deployUtil calls for stop and start vdsm-reg-setup daemon Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1192160 Change-Id: I269d2da9a52ef2ad493c152a50edd86a9e3c99b5 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 20 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/38014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I269d2da9a52ef2ad493c152a50edd86a9e3c99b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: Replace deployUtil._logExec
by dougsland＠redhat.com 20 Feb '15

20 Feb '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: Replace deployUtil._logExec ...................................................................... engine_page: Replace deployUtil._logExec Replacing deployUtil calls for stop and start vdsm-reg-setup daemon Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1192160 Change-Id: I269d2da9a52ef2ad493c152a50edd86a9e3c99b5 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 20 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/38013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I269d2da9a52ef2ad493c152a50edd86a9e3c99b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Document All-Content header for hosts
by piotr.kliczewski＠gmail.com 20 Feb '15

20 Feb '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Document All-Content header for hosts ...................................................................... restapi: Document All-Content header for hosts The "All-Content" header is used by the hosts collection and by the host resource, but it isn't documented in the RSDL metadata. As a result it isn't described in the RSDL and it isn't available in the SDKs or the CLI. This patch fixes the RSDL metadata. Change-Id: I880cd2f00a74813defd8366285fefc9c6c1bacf6 Bug-Url: https://bugzilla.redhat.com/1194185 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit afae793f20adb5cbaf9da8df302251723091ea49) --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I880cd2f00a74813defd8366285fefc9c6c1bacf6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Adding a helper function to check if table exists
by piotr.kliczewski＠gmail.com 20 Feb '15

20 Feb '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Adding a helper function to check if table exists ...................................................................... engine: Adding a helper function to check if table exists Bug-Url: https://bugzilla.redhat.com/1161012 Change-Id: I9421526de442640cf985cb0302f7fa3d6daa909a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/dbscripts/common_sp.sql 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/37846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9421526de442640cf985cb0302f7fa3d6daa909a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0