February 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: gluster: Entities for volume snapshot scheduling
by emesika＠redhat.com 18 Feb '15

18 Feb '15

Eli Mesika has submitted this change and it was merged. Change subject: gluster: Entities for volume snapshot scheduling ...................................................................... gluster: Entities for volume snapshot scheduling Introduced entities for gluster volume snapshot scheduling. Change-Id: I010e5c3977af7adeac2e6865bb1a99280a40ea70 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotSchedule.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotScheduleRecurrence.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_0870_add_gluster_volume_snapshot_schedule_tables.sql 4 files changed, 248 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Shubhendu Tripathi: Verified Sahina Bose: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I010e5c3977af7adeac2e6865bb1a99280a40ea70 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: UICommand as a 'builder'.
by tjelinek＠redhat.com 18 Feb '15

18 Feb '15

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: UICommand as a 'builder'. ...................................................................... userportal,webadmin: UICommand as a 'builder'. there was some setters missing 'return this' syntaxt corrupting 'builder' style of this class. Change-Id: I9ebc84df454f7204d098c78b7226deb2c511c387 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified -- To view, visit http://gerrit.ovirt.org/34275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ebc84df454f7204d098c78b7226deb2c511c387 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove usage of default db user engine
by emesika＠redhat.com 18 Feb '15

18 Feb '15

Eli Mesika has submitted this change and it was merged. Change subject: core: Remove usage of default db user engine ...................................................................... core: Remove usage of default db user engine Removes default ownership of db tables and types for user "engine", because we can specify custom db user during engine-setup. This default ownership for user "engine" was introduced in I33132cb95c991a3e6aae6b4859466a367139eea5. Change-Id: I107f6634186214157d3041e85474f9c04016a770 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/dbscripts/create_tables.sql 1 file changed, 0 insertions(+), 198 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I107f6634186214157d3041e85474f9c04016a770 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: update external provider resource fix
by derez＠redhat.com 18 Feb '15

18 Feb '15

Daniel Erez has submitted this change and it was merged. Change subject: restapi: update external provider resource fix ...................................................................... restapi: update external provider resource fix Updating an external provider currently returns the following error: "The specified HTTP method is not allowed for the requested resource ()." Adding a '@PUT -> update' signature to ExternalProviderResource interface seems to solve the issue. Change-Id: I0e266ee9f027eecb760d3dc965bb91e2c600262f Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ExternalProviderResource.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Ori Liel: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/37838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e266ee9f027eecb760d3dc965bb91e2c600262f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: codegen: Update to Java 8
by juan.hernandez＠redhat.com 18 Feb '15

18 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Update to Java 8 ...................................................................... codegen: Update to Java 8 This patch changes the POM of the code generator so that it requires Java 8 for compiling and running, as later changes will introduce code that will only work with Java 8. This doesn't affect the generated code which still requires Java 7. Change-Id: If56e9cb4d78817ed4b3ebc55520dd750e0f4aca3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If56e9cb4d78817ed4b3ebc55520dd750e0f4aca3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: StorageListModel cleanup.
by derez＠redhat.com 18 Feb '15

18 Feb '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: StorageListModel cleanup. ...................................................................... webadmin: StorageListModel cleanup. usedLunsMessages member with its setter & getter which is unused in the model is removed. Adjacent comments which has no meaning was removed as well. Change-Id: Ibc25f1109d6ad6777d076b83ab78128df903f283 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Amit Aviram: Verified -- To view, visit http://gerrit.ovirt.org/37843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc25f1109d6ad6777d076b83ab78128df903f283 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: codegen: Use commons-io instead of custom code
by juan.hernandez＠redhat.com 18 Feb '15

18 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Use commons-io instead of custom code ...................................................................... codegen: Use commons-io instead of custom code This patch replaces the custom FileUtils class with commons-io, which provides many functionalities that will be used by future patches. Change-Id: Ifbfd45e9207137bd9148ddf69763dec6c675dc92 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/pom.xml M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/RsdlCodegen.java D generator/src/main/java/org/ovirt/engine/sdk/generator/utils/FileUtils.java 3 files changed, 16 insertions(+), 76 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbfd45e9207137bd9148ddf69763dec6c675dc92 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Update to Java 8
by juan.hernandez＠redhat.com 18 Feb '15

18 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Update to Java 8 ...................................................................... codegen: Update to Java 8 This patch changes the POM of the code generator so that it requires Java 8 for compiling and running, as later changes will introduce code that will only work with Java 8. Change-Id: I4a9491b2a858a7a224d35301ec8cf07896dad312 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a9491b2a858a7a224d35301ec8cf07896dad312 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin:change Translator to interface
by tjelinek＠redhat.com 18 Feb '15

18 Feb '15

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin:change Translator to interface ...................................................................... userportal,webadmin:change Translator to interface * transform class Translator into an interface * push 'contains' implementation to descendants and correct it so it does not return (almost) always true. * fix it's direct descendant, so it logs attempts to localize 'null' value, which is probable bug. Change-Id: Ib018c1faf0c2e1ebaa81217d5e3696d9c8de20cf Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/EnumRenderer.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/VolumeTransportTypeRenderer.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractImageResourceColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractImageWithDecoratorColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskContainersColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleNode.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronPluginTranslator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Translator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ManagePolicyUnitPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VmStatusCell.java 24 files changed, 80 insertions(+), 66 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified -- To view, visit http://gerrit.ovirt.org/26596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib018c1faf0c2e1ebaa81217d5e3696d9c8de20cf Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix CDI API dependency
by rgolan＠redhat.com 18 Feb '15

18 Feb '15

Roy Golan has submitted this change and it was merged. Change subject: core: Fix CDI API dependency ...................................................................... core: Fix CDI API dependency Fixes CDI API dependency in module bll, where duplicate dependency was added in patch I3b3c2c57178b5df4f98b4191ac9a06f9129414d0. Change-Id: I028ebec75854162ef33bea16cea3dec93f8b121a Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/pom.xml 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I028ebec75854162ef33bea16cea3dec93f8b121a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0