March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: StorageListModel: refactoring storage prepare for ...
by derez＠redhat.com 08 Mar '15

08 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: StorageListModel: refactoring storage prepare for edit. ...................................................................... webadmin: StorageListModel: refactoring storage prepare for edit. As preparing storage for editing in StorageListModel has similiar logic through File and Block storage and all of their types, and currently there is a "prepare" method for each of those types- it is now consolidated into each model, with the proper differences divided between the models. prepareStorageForEdit will replace all of these "prepareXstorageForEdit" and let the proper model to do the rest of the work, divided through SAN and FILE storage types. Change-Id: I2bb2a4c142eb1fe2870dc00d0d8764a6c866f8a2 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/FileStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/IStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/LocalStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 7 files changed, 177 insertions(+), 224 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Fred Rolland: Looks good to me, but someone else must approve Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/38128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bb2a4c142eb1fe2870dc00d0d8764a6c866f8a2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: pass masterPropsSource
by sradco＠redhat.com 08 Mar '15

08 Mar '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: pass masterPropsSource ...................................................................... packaging: setup: pass masterPropsSource Pass -DmasterPropsSource to js-export and js-import. Change-Id: I77b35006c95f4d14fc30a83f03f6b46e9a29a914 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/reports/reportsutil.py 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77b35006c95f4d14fc30a83f03f6b46e9a29a914 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: Fail if a jasper import failed
by sradco＠redhat.com 08 Mar '15

08 Mar '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Fail if a jasper import failed ...................................................................... packaging: setup: Fail if a jasper import failed Change-Id: Ib56f521da16a69546d9c591ae693044f82fec745 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/reports/reportsutil.py 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/38262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib56f521da16a69546d9c591ae693044f82fec745 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup in can-do-action of addVmFromTemplate
by ofrenkel＠redhat.com 08 Mar '15

08 Mar '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup in can-do-action of addVmFromTemplate ...................................................................... core: cleanup in can-do-action of addVmFromTemplate Change-Id: I97adba801d1d6c8949c1560e0c2921d7b7dce1fa Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 1 file changed, 14 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/38457 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97adba801d1d6c8949c1560e0c2921d7b7dce1fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: adding missing action group
by mlipchuk＠redhat.com 08 Mar '15

08 Mar '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: adding missing action group ...................................................................... core: adding missing action group Adding missing DISK_LIVE_STORAGE_MIGRATION key to LocalizedEnums Change-Id: I4be8a3e779bab3da00d9954488c0fedb48c8a50e Bug-Url: https://bugzilla.redhat.com/1198609 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4be8a3e779bab3da00d9954488c0fedb48c8a50e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Extending disk editing when adding a new template.
by laravot＠redhat.com 08 Mar '15

08 Mar '15

Liron Aravot has submitted this change and it was merged. Change subject: restapi: Extending disk editing when adding a new template. ...................................................................... restapi: Extending disk editing when adding a new template. Currently when adding a new template, its disks edit is enabled only when the disk's storage domain is specified- In this case, editing any other field is ignored by the REST, and the request which is sent to the backend does not contain all the values the user posted. This patch makes the REST request for a new template to consider every given value related to the new template's disks whether the storage domain is specified and whether it is not, so the disk values that are provided will always be sent to backend. The specified attributes given in the REST request will be patched on the original disk using a mapper so that a sent disk will contain a default value in case some of its fields will not be provided by the user. Change-Id: Ib0baf4e5bd7233fbc4eab2f1f671b8b15e08ba03 Bug-Url: https://bugzilla.redhat.com/1110798 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java 2 files changed, 44 insertions(+), 15 deletions(-) Approvals: Ori Liel: Looks good to me, approved Amit Aviram: Verified Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/37808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0baf4e5bd7233fbc4eab2f1f671b8b15e08ba03 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: notifier: filter messages based on severity
by oourfali＠redhat.com 08 Mar '15

08 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: tools: notifier: filter messages based on severity ...................................................................... tools: notifier: filter messages based on severity Extend the existing notifier filter mechanism to accept severities in an extra, optional field: PATTERN=include|exclude:event[:severity][(subscriber)] The parser accepts the prior format for backwards compatibility. An inclusion filter will match an event with greater-or-equal severity. Conversely, an exclusion filter will match an event with lesser-or-equal severity. Change-Id: Ia8abc34d56f1ede2fb51daf71dee293d08f198a3 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/dao/EventsManager.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilterTest.java M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 5 files changed, 99 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Greg Padgett: Verified Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8abc34d56f1ede2fb51daf71dee293d08f198a3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: notifier: remove duplicate unit test
by oourfali＠redhat.com 08 Mar '15

08 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: tools: notifier: remove duplicate unit test ...................................................................... tools: notifier: remove duplicate unit test Change-Id: Iff540777e91cac3fa82a167bb92dc1505795a6eb Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilterTest.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Greg Padgett: Verified Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff540777e91cac3fa82a167bb92dc1505795a6eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: improved error message for duplicate NFS parameters
by ecohen＠redhat.com 06 Mar '15

06 Mar '15

Einav Cohen has submitted this change and it was merged. Change subject: core: improved error message for duplicate NFS parameters ...................................................................... core: improved error message for duplicate NFS parameters added "duplicate" to the error message that is generated when user tries to create an NFS storage domain with duplicate custom mount options (e.g. specifying timeout in field and also in freeform options) Change-Id: Ida31e57e48c83dac66454c4f029acde1ca45d359 Bug-Url: https://bugzilla.redhat.com/1152419 Signed-off-by: Candace Sheremeta <cshereme(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Candace Sheremeta: Verified Einav Cohen: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida31e57e48c83dac66454c4f029acde1ca45d359 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: engine_page: Catch exception KeyError
by dougsland＠redhat.com 06 Mar '15

06 Mar '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: Catch exception KeyError ...................................................................... engine_page: Catch exception KeyError If VDSM is not ready to provide network data via vdscli.getVdsCaps()['info']['networks'] and fail with KeyError we should throw an error message and not stuck in the login. Additionally, for unexpected exceptions in vdscli we should log as error and not use raise to avoid users getting blocked into the login page. Change-Id: I4b7666c2020307c6119f96a2935684bc268e459b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1198029 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b7666c2020307c6119f96a2935684bc268e459b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0