June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: refactor; encapsulation
by alkaplan＠redhat.com 30 Jun '15

30 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: refactor; encapsulation ...................................................................... core: refactor; encapsulation • Map<Guid, Whatever> is only mapping Guid to Whatever. It does not guarantee, that Guid is ID of Whatever. This should be somehow strongly enforced; it's not safe passing mappings around forcing callee to trust caller, that he did mapping right. Touched files was not interrested in created Maps itself ~ true usecase was: get network for iface and get network for attachment. Change-Id: Ic42fb58302a66995f366227e43950d2722c77b33 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java 3 files changed, 31 insertions(+), 30 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/36143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic42fb58302a66995f366227e43950d2722c77b33 Gerrit-PatchSet: 58 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: cleanup - redundancy in FileStorageModel.isEditable()
by amureini＠redhat.com 30 Jun '15

30 Jun '15

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: cleanup - redundancy in FileStorageModel.isEditable() ...................................................................... webadmin: cleanup - redundancy in FileStorageModel.isEditable() There are no file domains other than Iso, ImportExport and Data. Change-Id: Icaef5008d0981d1a84eeec3cfe91fe14af854acd Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/FileStorageModel.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Amit Aviram: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/42731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaef5008d0981d1a84eeec3cfe91fe14af854acd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Explicitly use Xalan as transformer
by juan.hernandez＠redhat.com 30 Jun '15

30 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Explicitly use Xalan as transformer ...................................................................... restapi: Explicitly use Xalan as transformer Currently the FOP message body writer used to generate PDF document doesn't explicitly request a particular implementation of the XSLT processor. When running in the WildFly application server this results in an exception because an unresolved issue: Xalan Linkage error : TransformerConfigurationException https://issues.jboss.org/browse/WFCORE-519 To avoid that issue this patch changes the FOP message body writer so that it explicitly requests the Xalan processor included in the "org.apache.xalan" module. Change-Id: I1c8cca9cc83e29a98d026c3226ab0f11c40660d3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/pdf/FOPMessageBodyWriter.java M backend/manager/modules/restapi/jaxrs/src/main/modules/org/ovirt/engine/api/restapi-jaxrs/main/module.xml 2 files changed, 22 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c8cca9cc83e29a98d026c3226ab0f11c40660d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Source VM is deleted after failed cloning attempt
by tnisan＠redhat.com 30 Jun '15

30 Jun '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Source VM is deleted after failed cloning attempt ...................................................................... core: Source VM is deleted after failed cloning attempt The root cause was that in the rollback flow the VM id has been inited from the getParameters().getVmId() which points to the old VM. Than, in AddVmCommand.removeVmRelatedEntitiesFromDb() the removeVmStatic() used it to delete the VM - but since it pointed to the old VM it has been deleted. Fixed by making sure that the VM ID always points to the new VM. Change-Id: Ia44f6394914f956013c81ffef2dbcbfb120ec301 Bug-Url: https://bugzilla.redhat.com/1236608 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia44f6394914f956013c81ffef2dbcbfb120ec301 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fix fence agent issues.
by oourfali＠redhat.com 30 Jun '15

30 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: fix fence agent issues. ...................................................................... webadmin: fix fence agent issues. - Fixed fence agent test button not working (npe). - Fixed second fence agent in a concurrent group not opening popup. - Fixed edit button in concurrent group not working. Change-Id: Iea3461ac61fff38eab72c625f4b5c16f19366690 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1236382 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/FenceAgentConcurrentWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/FenceAgentsEditor.java 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Alexander Wels: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43017 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea3461ac61fff38eab72c625f4b5c16f19366690 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: refactored NetworkAttachmentCompleter + tests.
by alkaplan＠redhat.com 30 Jun '15

30 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: refactored NetworkAttachmentCompleter + tests. ...................................................................... core: refactored NetworkAttachmentCompleter + tests. • added unit tests • unified implementation so both methods uses BusinessEntityMap • added tests for id<-->name coherence in case that user sets both. • added completation of id in case that user specifies name of existing bond/nic but does not specify id. Change-Id: I933333afdcb11bfcf9f761572229f7a7a7814381 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddNetworkAttachmentCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkAttachmentCompleter.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NicNameNicIdCompleter.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NicNameNicIdCompleterTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 394 insertions(+), 56 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/36142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I933333afdcb11bfcf9f761572229f7a7a7814381 Gerrit-PatchSet: 56 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: refactor&test for HostNetworkAttachmentsPersister
by alkaplan＠redhat.com 30 Jun '15

30 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: refactor&test for HostNetworkAttachmentsPersister ...................................................................... core: refactor&test for HostNetworkAttachmentsPersister • added few javadoc • typo • extracted some conditions to give them name • extracted part of constructor code out to method to make constructor shorter/simpler. • renamed method 'removeNetworkAttachments' to make it clearer why are they removed. • minor refactoring so that there's neither 'global' collection for representing 'valid attachments' nor 'cached' db content, which is rendered out-of-date after first method call (removeInvalidNetworkAttachmentsFromDb). It creates a little bit procedural design, but I think it's less error prone this way, without out-of-date gotchas. • added tests for this class Change-Id: Ib39c3678a29a7bd8728d32b55490f8500a77d9d6 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersisterTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 434 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/36067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib39c3678a29a7bd8728d32b55490f8500a77d9d6 Gerrit-PatchSet: 55 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fixed update script
by alkaplan＠redhat.com 30 Jun '15

30 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: fixed update script ...................................................................... core: fixed update script fixed update script to do translation of enum value 'intValue' representation to enum value name. I did not find any db representation of this enum value, so I had to list the mapping manually. Which should be sufficient — there shouldn't be more values in DB than: 0,1,2. Change-Id: I10045d57b645f01f73868a39b3322ce61ac0b32e Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1680_do_not_reference_network_boot_protocol_enum_with_numbers.sql 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10045d57b645f01f73868a39b3322ce61ac0b32e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: add validations for import from vmware
by ahadas＠redhat.com 30 Jun '15

30 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: add validations for import from vmware ...................................................................... webadmin: add validations for import from vmware Validate the input before trying to query VMs from VMware. Change-Id: Ie74266816c1633521e719f9f5f545883ef56bf89 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java 1 file changed, 42 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/42950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie74266816c1633521e719f9f5f545883ef56bf89 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix Found two representations of same collection
by oourfali＠redhat.com 30 Jun '15

30 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix Found two representations of same collection ...................................................................... core: Fix Found two representations of same collection Hibernate throws Found two representations of same collection when adding a VDS. This patch fixes it. Change-Id: Id9714385dc8e9bd6243c09dc9135eb96133b53cd Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1235700 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetJobByJobIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/job/JobRepositoryTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/TransactionManagerMock.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/JobDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepDaoTest.java 11 files changed, 122 insertions(+), 74 deletions(-) Approvals: Moti Asayag: Looks good to me, but someone else must approve Liran Zelkha: Verified Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9714385dc8e9bd6243c09dc9135eb96133b53cd Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0