June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Remove nics from CollectHostNetworkDataVdsCommandPar...
by alkaplan＠redhat.com 29 Jun '15

29 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Remove nics from CollectHostNetworkDataVdsCommandParameters ...................................................................... engine: Remove nics from CollectHostNetworkDataVdsCommandParameters There is no longer use of the nics from the parameters, as nics will be persisted as part of the SetupNetworksCommands. In addition, this class should be removed and use the VdsIdAndVdsVDSCommandParametersBase, as part of a following patch. Change-Id: Id4290345096cdf84ea4e962fea09be455a3d6286 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CollectHostNetworkDataVdsCommandParameters.java 1 file changed, 0 insertions(+), 16 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/35377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4290345096cdf84ea4e962fea09be455a3d6286 Gerrit-PatchSet: 37 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Re-construct SetupNetworks steps
by alkaplan＠redhat.com 29 Jun '15

29 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Re-construct SetupNetworks steps ...................................................................... engine: Re-construct SetupNetworks steps The deprecated SetupNetworks command is being updated to use HostSetupNetworks introduced sequence of actions: 1. DRY - reuse the HostSetupNetworkPoller for polling connectivity to the host while executing the setupnetworks on vdsm. 2. Replaced 'all-in-one' vdsbroker CollectVdsNetworkDate with few steps that separates the concern of persisting the network changes from the network data collected process. SetupNetworks requires specific behavior to preserves nics additional attributes (i.e. labels), hence specifying that logic explicitly as part of this command clarify the action. Change-Id: I79fe45714f0f9ed4348f7c68c2b38cf1ace57fa6 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java 1 file changed, 34 insertions(+), 37 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Objections: Jenkins CI: Fails -- To view, visit https://gerrit.ovirt.org/35376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79fe45714f0f9ed4348f7c68c2b38cf1ace57fa6 Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: host-deploy: enroll vmconsole certificate with correct host ...
by masayag＠redhat.com 29 Jun '15

29 Jun '15

Moti Asayag has submitted this change and it was merged. Change subject: host-deploy: enroll vmconsole certificate with correct host name ...................................................................... host-deploy: enroll vmconsole certificate with correct host name adding -ssh suffix for file name is valid, but not effect the actual subject name. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1223671 Change-Id: Ie9a24782b295bf80ff51385c8066de6b91386480 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeploy.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java 2 files changed, 15 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9a24782b295bf80ff51385c8066de6b91386480 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Replace host polling with HostSetupNetworkPoller
by alkaplan＠redhat.com 29 Jun '15

29 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Replace host polling with HostSetupNetworkPoller ...................................................................... engine: Replace host polling with HostSetupNetworkPoller DRY: same logic spread among various flows. Now there is a single module which is responsible for polling the host that should be used in the host installation flow when network is being configured. Change-Id: Id9b0f9d84386dbf191ca4c3b050f5a4d204c24a7 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java 1 file changed, 4 insertions(+), 34 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/35083 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9b0f9d84386dbf191ca4c3b050f5a4d204c24a7 Gerrit-PatchSet: 40 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: The "isattached" action should return an action object
by juan.hernandez＠redhat.com 29 Jun '15

29 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: The "isattached" action should return an action object ...................................................................... restapi: The "isattached" action should return an action object Currently the "isattached" action of the storage domain resource returns a storage domain object. For example, the following HTTP request: POST /api/storagedomains/{storagedomain:id}/isattached <action> <host id="{host:id}"/> </action> Returns the following response: <storage_domain id="{storagedomain:id}"> <is_attached>true</is_attached> </storage_domain> This isn't correct, because all actions are expected to return an action object. Returning something different causes issues in the SDKs. The returned result should look like this: <action> <status> <state>complete</state> </status> <is_attached>true</is_attached> </action> There is no need to return the storage domain object, only the "is_attached" flag, and it should be an attribute of the action object, not of the storage domain. This patch modifies the storage domain resource so that this action works as described above. Change-Id: I4033daddfca8f6d25ee2a1efd03fa2b65a48c6f4 Bug-Url: https://bugzilla.redhat.com/1234937 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java 2 files changed, 28 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4033daddfca8f6d25ee2a1efd03fa2b65a48c6f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: The "refreshluns" action should return "Action"
by juan.hernandez＠redhat.com 29 Jun '15

29 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: The "refreshluns" action should return "Action" ...................................................................... restapi: The "refreshluns" action should return "Action" Currently the "refreshluns" action returns a storage domain object, but it should return an action object, like all other actions, otherwise the SDKs won't be able to handle it correctly. Change-Id: I138a9dd772781465ac040dc99d96b0a3f355df11 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResourceTest.java 3 files changed, 15 insertions(+), 33 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I138a9dd772781465ac040dc99d96b0a3f355df11 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: update localization files
by ydary＠redhat.com 29 Jun '15

29 Jun '15

Yaniv Dary has submitted this change and it was merged. Change subject: reports: update localization files ...................................................................... reports: update localization files Bug-Url: https://bugzilla.redhat.com/1169693 Bug-Url: https://bugzilla.redhat.com/1179118 Change-Id: Ifd4a439e8e5950654af265638c186d924651eee5 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_de.properties.data M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_es.properties.data M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_fr.properties.data M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_ja.properties.data M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_pt_BR.properties.data M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_zh_CN.properties.data 6 files changed, 284 insertions(+), 38 deletions(-) Approvals: Shirly Radco: Verified Jenkins CI: Passed CI tests Yaniv Dary: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd4a439e8e5950654af265638c186d924651eee5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: post ovirt-live 3.6.0 alpha2
by sbonazzo＠redhat.com 29 Jun '15

29 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: post ovirt-live 3.6.0 alpha2 ...................................................................... post ovirt-live 3.6.0 alpha2 Change-Id: Ib01da5cc8fb5faa64a13e8179edef2982d5b981f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42978 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib01da5cc8fb5faa64a13e8179edef2982d5b981f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: CommandBase - avoid releasing lock if there is a callback
by laravot＠redhat.com 29 Jun '15

29 Jun '15

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - avoid releasing lock if there is a callback ...................................................................... core: CommandBase - avoid releasing lock if there is a callback Currently command can be marked to keep it's acquired lock after the execute phase ends. However, if it doesn't have tasks the locks will be released regardless. This patch changes that, if it was marked to keep the locks after the execute phase and there is a callback, it's the callback responsibllity to run the command endMethod() once polling has finished to release the acquired locks. Change-Id: If8600ee529f68a1b3e2881f4e33f44fec9402beb Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Greg Padgett: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, but someone else must approve Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8600ee529f68a1b3e2881f4e33f44fec9402beb Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: CommandBase - adding noAsyncOperations()
by laravot＠redhat.com 29 Jun '15

29 Jun '15

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - adding noAsyncOperations() ...................................................................... core: CommandBase - adding noAsyncOperations() added a method to check whether the command has running tasks or child commands. Change-Id: I02e6794f0ebeebcb652cea823bb5061c9ccb2844 Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02e6794f0ebeebcb652cea823bb5061c9ccb2844 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0