June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: utils: command line fixes
by oourfali＠redhat.com 03 Jun '15

03 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: utils: command line fixes ...................................................................... aaa: utils: command line fixes * Cases insensitive matching of manage domains provider * use match instead of find to match pattern * moved module.xml to correct directory Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1225080 Change-Id: Ia05e674a77c5b431e07b95cdf4296488348a3249 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- R backend/manager/extension-tool/src/main/modules/org/ovirt/engine/core/extension-tool/main/module.xml M backend/manager/modules/builtin-extensions/src/main/resources/org/ovirt/engine/extensions/aaa/builtin/tools/arguments.properties M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java 3 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ondra Machacek: Verified Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia05e674a77c5b431e07b95cdf4296488348a3249 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: ClientStorage improvements
by vszocs＠redhat.com 02 Jun '15

02 Jun '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: ClientStorage improvements ...................................................................... webadmin,userportal: ClientStorage improvements 1. All key/value pairs persisted through ClientStorage interface now use application-specific key prefix to avoid clashes between WebAdmin vs. UserPortal instances running on the same browser (but not necessarily at the same time) where one instance might read data originally persisted by another instance. Example key names: ENGINE_WebAdmin_MyKey ENGINE_UserPortal_MyKey 2. ClientStorageImpl behavior modified as following: * get{Local,Session}Item -- first use prefixed key, if missing fall back to un-prefixed key for backwards compatibility * set{Local,Session}Item -- use prefixed key (only) 3. Removed unused ClientStorage interface methods: * removeLocalItem * removeSessionItem 4. Added ClientStorageImplTest. 5. In UserPortal SystemModule, removed unnecessary GIN bindings. Change-Id: Iaef8f72feec5dd083fbe4cc962a222dce4f7a99f Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ClientStorage.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ClientStorageImpl.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ClientStorageKeyPrefix.java A frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/system/ClientStorageImplTest.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/SystemModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java 6 files changed, 193 insertions(+), 37 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Alexander Wels: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/41404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaef8f72feec5dd083fbe4cc962a222dce4f7a99f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: host->general->hardware jumps to VM
by awels＠redhat.com 02 Jun '15

02 Jun '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: host->general->hardware jumps to VM ...................................................................... webadmin: host->general->hardware jumps to VM - Because the host hardware is no longer its own sub tab it no longer has a place. So when switching to a different host it would try and switch to the hardware sub tab. This patch makes sure that we stay on the general sub tab instead. Change-Id: I47f1ece04f1112ecbe00b6a4a9a4c0518d297ede Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1217579 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabHostPresenter.java 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47f1ece04f1112ecbe00b6a4a9a4c0518d297ede Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: Persistent client-side logging infra
by vszocs＠redhat.com 02 Jun '15

02 Jun '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Persistent client-side logging infra ...................................................................... webadmin,userportal: Persistent client-side logging infra This patch adds following changes to WebAdmin & UserPortal: 1, New log handler (LocalStorageLogHandler) that uses ClientStorage for persisting log records in browser via HTML5 Web Storage API. Note: this works only when the browser supports HTML5 Web Storage since falling back to cookie-based persistence would essentially waste the max. cookies per domain limit. 2, Disabled FirebugLogHandler since it's marked as deprecated. 3, Global uncaught exception handler that logs runtime errors and prevents them from escaping application code into the browser. Consequence: uncaught exceptions are less likely to "break" the application's behavior and/or appearance. Runtime errors won't appear in browser's JS error console anymore, however they will still be logged by all registered log handlers. List of effective client-side log handlers: (a) ConsoleLogHandler (browser `console.log` API) - works in both Dev & Production mode (b) [NEW] LocalStorageLogHandler (browser Web Storage API) - works in both Dev & Production mode (c) DevelopmentModeLogHandler (DevMode debug session window) - works only in Dev mode (d) SystemLogHandler (DevMode process stdout) - works only in Dev mode LocalStorageLogHandler handles following key/value pairs: LogHead # index of the first log record LogSize # number of log records persisted so far Log_N # specific log record item For now, the only way to inspect client-side log records (including those for uncaught exceptions) is using browser. In Firefox: * Open Menu / Developer / Toggle Tools * on Console tab, type `inspect(localStorage)` Change-Id: I3b0be449ab425b56a1d7c39efeb1793991e58fa7 Bug-Url: https://bugzilla.redhat.com/1049409 Bug-Url: https://bugzilla.redhat.com/1215727 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/logging/ClientLogProvider.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/logging/LocalStorageLogHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ClientStorage.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ClientStorageImpl.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/AddOnlyRingBuffer.java A frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/utils/AddOnlyRingBufferTest.java M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml 14 files changed, 548 insertions(+), 89 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/25444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b0be449ab425b56a1d7c39efeb1793991e58fa7 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove deprecated host update code
by juan.hernandez＠redhat.com 02 Jun '15

02 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove deprecated host update code ...................................................................... restapi: Remove deprecated host update code Remove deprecated code which updates Power-Management fence agents in context of Host update Change-Id: I457fc7a1b64bd8fe4fef78447876881139b0bad5 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java 1 file changed, 0 insertions(+), 30 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I457fc7a1b64bd8fe4fef78447876881139b0bad5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Avoid altering dictionary while removing elements
by juan.hernandez＠redhat.com 02 Jun '15

02 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Avoid altering dictionary while removing elements ...................................................................... sdk: Avoid altering dictionary while removing elements Currently the "clear" method of the "Cache" class iterates the keys of the dictionary and removes them, but this causes errors in Python 3. This patch changes that methods so that it makes a copy of the list of keys and iterates it intead of the original one. Change-Id: Iff458d9e432c47e4c5d9ef7ec3e1178d718be497 Related: https://bugzilla.redhat.com/1096137 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/cache.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me; Ready for merge Jenkins CI: Verified; Looks good to me; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff458d9e432c47e4c5d9ef7ec3e1178d718be497 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Use "print(...)" instead of "print ..."
by juan.hernandez＠redhat.com 02 Jun '15

02 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Use "print(...)" instead of "print ..." ...................................................................... sdk: Use "print(...)" instead of "print ..." This is one step towards supporting Python 3. Change-Id: Ia46adba063589645741eb2d9112806aa1b123817 Related: https://bugzilla.redhat.com/1096137 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/utils/comperator.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Ready for merge Jenkins CI: Looks good to me; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia46adba063589645741eb2d9112806aa1b123817 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Use "except ... as" instead of "except ..., "
by juan.hernandez＠redhat.com 02 Jun '15

02 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Use "except ... as" instead of "except ...," ...................................................................... sdk: Use "except ... as" instead of "except ...," This one step towards supporting Python 3. Change-Id: Ia65745833c3b4399792035fb525712c6ede469cc Related: https://bugzilla.redhat.com/1096137 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/CollectionGetCapabilitiesTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/CollectionGetDisksTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/CollectionGetNotSearchableTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/CollectionGetSearchableTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/EntryPointMethodsTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/SubCollectionGetTemplate M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/infrastructure/connectionspool.py 9 files changed, 174 insertions(+), 174 deletions(-) Approvals: Juan Hernandez: Verified; Ready for merge Jenkins CI: Looks good to me; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia65745833c3b4399792035fb525712c6ede469cc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Use "in" instead of "has_key"
by juan.hernandez＠redhat.com 02 Jun '15

02 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Use "in" instead of "has_key" ...................................................................... sdk: Use "in" instead of "has_key" This one step towards supporting Python 3. Change-Id: I1a3ce525c94cfc4e5b2394f781c6fa2bf1f04787 Related: https://bugzilla.redhat.com/1096137 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/EntryPointTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/SuperAttributesTemplate M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/cache.py M src/ovirtsdk/infrastructure/common.py M src/ovirtsdk/utils/reflectionhelper.py M src/ovirtsdk/xml/params.py 7 files changed, 17 insertions(+), 17 deletions(-) Approvals: Juan Hernandez: Verified; Ready for merge Jenkins CI: Looks good to me; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a3ce525c94cfc4e5b2394f781c6fa2bf1f04787 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Mark VM as problematic when timezone or OS changed
by ofrenkel＠redhat.com 02 Jun '15

02 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: Mark VM as problematic when timezone or OS changed ...................................................................... Mark VM as problematic when timezone or OS changed This patch adds an exclamation mark when the installed OS differes significantly from the configuration. e.g. Windows OS configured and a Linux guest is running. Also when the timezone offset differs from the configuration the exclamation mark is shown. Change-Id: Ia1d6c878a3e700998c77d3ee3248b4ef3302d08b Bug-Url: https://bugzilla.redhat.com/869296 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VmStatusCell.java 3 files changed, 88 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve Vinzenz Feenstra: Verified -- To view, visit https://gerrit.ovirt.org/30508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1d6c878a3e700998c77d3ee3248b4ef3302d08b Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0