June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Avoid print error on Cinder disk removal
by mlipchuk＠redhat.com 28 Jun '15

28 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Avoid print error on Cinder disk removal ...................................................................... core: Avoid print error on Cinder disk removal Fix a bug which prints an error when a Cinder disk gets removed. Change-Id: I9d821496a65353df19070ed7750279b734c9fe5c Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42954 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d821496a65353df19070ed7750279b734c9fe5c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Support clone a VM from Cinder snapshot.
by mlipchuk＠redhat.com 28 Jun '15

28 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support clone a VM from Cinder snapshot. ...................................................................... core: Support clone a VM from Cinder snapshot. Support clonning a VM containning Cinder disks from a snapshot. Change-Id: I28c4114abdc35b842ee7d22da3682e05e7e8025f Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 2 files changed, 24 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28c4114abdc35b842ee7d22da3682e05e7e8025f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Support clone VM from Cinder snapshot.
by mlipchuk＠redhat.com 28 Jun '15

28 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support clone VM from Cinder snapshot. ...................................................................... core: Support clone VM from Cinder snapshot. Support clonning a VM from a VM with Cinder disks. Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I58711c0ac4f0f66bfab043415af71e6533d956bf --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58711c0ac4f0f66bfab043415af71e6533d956bf Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core:[cloneTemplateFromSnapshot] Add default constructor
by mlipchuk＠redhat.com 28 Jun '15

28 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core:[cloneTemplateFromSnapshot] Add default constructor ...................................................................... core:[cloneTemplateFromSnapshot] Add default constructor Add constructor with context to support CoCo callbacks. Change-Id: I9dddbc0ba5dbbc2dbb3b5604a0a42ef17311e50e Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dddbc0ba5dbbc2dbb3b5604a0a42ef17311e50e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core:[cloneVM] Add default constructor with context
by mlipchuk＠redhat.com 28 Jun '15

28 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core:[cloneVM] Add default constructor with context ...................................................................... core:[cloneVM] Add default constructor with context Add constructor with context to support CoCo callbacks Change-Id: I668c4316422439f4022f476856cf99875e8b94cb Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42842 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I668c4316422439f4022f476856cf99875e8b94cb Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Support clone Template from Cinder snapshot.
by mlipchuk＠redhat.com 28 Jun '15

28 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support clone Template from Cinder snapshot. ...................................................................... core: Support clone Template from Cinder snapshot. Support clonning a Template from a snapshot with Cinder disks. Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Idff0b08a454f4f3423a705f338eda85f6afc4144 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42845 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idff0b08a454f4f3423a705f338eda85f6afc4144 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Support clonning a Cinder disk from a snapshot
by mlipchuk＠redhat.com 28 Jun '15

28 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support clonning a Cinder disk from a snapshot ...................................................................... core: Support clonning a Cinder disk from a snapshot Support clonning a disk from snapshot. If the volume fetched from the DB is not active then we determine this volume is cloned from a snapshot. Change-Id: I32eaa9556c2f8c1186841a2dd019416d04878414 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommand.java 2 files changed, 19 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42840 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32eaa9556c2f8c1186841a2dd019416d04878414 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use image id instead of id to get Cinder disk
by mlipchuk＠redhat.com 28 Jun '15

28 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use image id instead of id to get Cinder disk ...................................................................... core: Use image id instead of id to get Cinder disk When clonning a disk use image id instead of disk id to get also a snapshot (for clonning a disk from a snapshot). Change-Id: Ic9f44c43f7028b8af2887880ba193c5bad34f9ff Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommand.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42839 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9f44c43f7028b8af2887880ba193c5bad34f9ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix new disk alias name when creating a VM/Template.
by mlipchuk＠redhat.com 28 Jun '15

28 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix new disk alias name when creating a VM/Template. ...................................................................... core: Fix new disk alias name when creating a VM/Template. Pass disk alias as an argument, so if a user will set new disk aliases when creating a VM form Template or create a Tempalte from a VM, then the new alias will be set for the new disk. Change-Id: I856d4f0945435794d008cf4aca5c193e8493fc6c Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommand.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42838 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I856d4f0945435794d008cf4aca5c193e8493fc6c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: temporary fix for findbugs
by masayag＠redhat.com 28 Jun '15

28 Jun '15

Moti Asayag has submitted this change and it was merged. Change subject: core: temporary fix for findbugs ...................................................................... core: temporary fix for findbugs Findbugs compains about Null pointer dereference. So dropping the reference as a temporary fix. Change-Id: I9a8b6b087af0632dec3be9341f9ff88bdc5c7354 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostValidator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Looks good to me, approved; Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/42948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a8b6b087af0632dec3be9341f9ff88bdc5c7354 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0