July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Move Host Provision Validation To Validator
by oliel＠redhat.com 09 Jul '15

09 Jul '15

Ori Liel has submitted this change and it was merged. Change subject: core: Move Host Provision Validation To Validator ...................................................................... core: Move Host Provision Validation To Validator Bug-Url: https://bugzilla.redhat.com/1183922 Change-Id: I4582d4457d7e2c5632f3480e35a03aaa0d39ddf7 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 99 insertions(+), 35 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4582d4457d7e2c5632f3480e35a03aaa0d39ddf7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Fix Error Message For Provider Connectivity Test (...
by oliel＠redhat.com 09 Jul '15

09 Jul '15

Ori Liel has submitted this change and it was merged. Change subject: webadmin: Fix Error Message For Provider Connectivity Test (#1183472) ...................................................................... webadmin: Fix Error Message For Provider Connectivity Test (#1183472) Bug-Url: https://bugzilla.redhat.com/1183472 Change-Id: I0f59070eb3a8a7c4d2168cfef20a8f2b40e1ccb8 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f59070eb3a8a7c4d2168cfef20a8f2b40e1ccb8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: RestApiSessionMgmtFilter: fix Coverity issues
by masayag＠redhat.com 09 Jul '15

09 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: aaa: RestApiSessionMgmtFilter: fix Coverity issues ...................................................................... aaa: RestApiSessionMgmtFilter: fix Coverity issues FORWARD_NULL FB.REC_CATCH_EXCEPTION + fixup logging Change-Id: I30fe6f775e35f128e5b056fe4b4149b8be1fdb82 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionMgmtFilter.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30fe6f775e35f128e5b056fe4b4149b8be1fdb82 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: UX: addHost form leaves json checkbox locked when...
by emesika＠redhat.com 08 Jul '15

08 Jul '15

Eli Mesika has submitted this change and it was merged. Change subject: webadmin: UX: addHost form leaves json checkbox locked when switching between clusters ...................................................................... webadmin: UX: addHost form leaves json checkbox locked when switching between clusters Edit host dialog should display the protocol saved in the database. Change-Id: Ie12aff2897c53b1de3c68086904110034ed0cee4 Bug-Url: https://bugzilla.redhat.com/1209754 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Passed CI tests Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie12aff2897c53b1de3c68086904110034ed0cee4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Adjust audit log messages to comma's convention
by emesika＠redhat.com 08 Jul '15

08 Jul '15

Eli Mesika has submitted this change and it was merged. Change subject: engine: Adjust audit log messages to comma's convention ...................................................................... engine: Adjust audit log messages to comma's convention The convention in the audit log messages is not to surround the host name with commas. The patch make sure all of the existing messages are aligned. Change-Id: I9bf9f544c67958f7817ee8bce77b0bd95a4f31f7 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved; Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/43216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bf9f544c67958f7817ee8bce77b0bd95a4f31f7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Host name shouldn't be surrounded by commas
by emesika＠redhat.com 08 Jul '15

08 Jul '15

Eli Mesika has submitted this change and it was merged. Change subject: engine: Host name shouldn't be surrounded by commas ...................................................................... engine: Host name shouldn't be surrounded by commas The convention in the audit log messages is not to surround the host name with commas. Change-Id: I55576154f188a1981b132bb8cd049867fb1566ff Bug-Url: https://bugzilla.redhat.com/1238594 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved; Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/43215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55576154f188a1981b132bb8cd049867fb1566ff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: Fix ballooning method name when talking to VDSM over xmlrpc
by alitke＠redhat.com 08 Jul '15

08 Jul '15

Adam Litke has submitted this change and it was merged. Change subject: Fix ballooning method name when talking to VDSM over xmlrpc ...................................................................... Fix ballooning method name when talking to VDSM over xmlrpc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1240640 Change-Id: I4e6cf0cd1074d24db962b7c28e50ab2706e9d14b Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/43278 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani <fromani(a)redhat.com> Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/HypervisorInterfaces/vdsmxmlrpcInterface.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e6cf0cd1074d24db962b7c28e50ab2706e9d14b Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: Honor 'Session-TTL' header
by oliel＠redhat.com 08 Jul '15

08 Jul '15

Ori Liel has submitted this change and it was merged. Change subject: aaa: Honor 'Session-TTL' header ...................................................................... aaa: Honor 'Session-TTL' header Currently API requests may have "Session-TTL=xxx" header on them. This should set the 'soft-limit' (in minutes) for this session in the engine, but in fact is ignored. This patch causes this header to be honored. For requests that open a new session (meaning: cause a log-in), the value of the header is saved and used later every time the session is refreshed (instead of the default ConfigValues.UserSessionTimeOutInterval) Bug-Url: http://bugzilla.redhat.com/1157751 Change-Id: If6d01d1afc2045ee1ed267512e8d5755a6413d4f Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/LoginFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionMgmtFilter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SetSesssionSoftLimitCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetSesssionSoftLimitCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 7 files changed, 144 insertions(+), 36 deletions(-) Approvals: Ori Liel: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43140 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6d01d1afc2045ee1ed267512e8d5755a6413d4f Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Small grammar fixes.
by alkaplan＠redhat.com 08 Jul '15

08 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Small grammar fixes. ...................................................................... webadmin: Small grammar fixes. Change-Id: I01d6bf05cd712ad675a1c33b7973d7cb6c7d1bb4 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved; Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/43335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01d6bf05cd712ad675a1c33b7973d7cb6c7d1bb4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: host-deploy: apply user visible messages logic
by masayag＠redhat.com 08 Jul '15

08 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: host-deploy: apply user visible messages logic ...................................................................... host-deploy: apply user visible messages logic remove the use of InstallerMessages, this class is now being used only for node upgrade and should be removed when that class is migrated to the ovirt-node-upgrade interface. VdsMgmtPacakges issues user visible messages only if it is not in check only mode. VdsDeploy is interacting with user for all messages as in current implementation, the double log/audit was removed in favour of audit only, as it already writes to log. Change-Id: I6480d5d2d43caccc6093300e03a840afca5e899d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeploy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsMgmtPackages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 124 insertions(+), 50 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6480d5d2d43caccc6093300e03a840afca5e899d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0